From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Jiang Biao <benbjiang@gmail.com>,
mathew.j.martineau@linux.intel.com, davem@davemloft.net,
kuba@kernel.org
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, benbjiang@tencent.com,
Jiang Biao <tcs_robot@tencent.com>
Subject: Re: [PATCH] ipv4/mptcp: fix divide error
Date: Tue, 24 Aug 2021 09:36:35 +0200 [thread overview]
Message-ID: <fe512c8b-6f5a-0210-3f23-2c1fc75cd6e5@tessares.net> (raw)
In-Reply-To: <20210824071926.68019-1-benbjiang@gmail.com>
Hi Jiang,
On 24/08/2021 09:19, Jiang Biao wrote:
(...)
> There is a fix divide error reported,
> divide error: 0000 [#1] PREEMPT SMP KASAN
> RIP: 0010:tcp_tso_autosize build/../net/ipv4/tcp_output.c:1975 [inline]
> RIP: 0010:tcp_tso_segs+0x14f/0x250 build/../net/ipv4/tcp_output.c:1992
Thank you for this patch and validating MPTCP on your side!
This issue is actively tracked on our Github project [1] and a patch is
already in our tree [2] but still under validation.
> It's introduced by non-initialized info->mss_now in __mptcp_push_pending.
> Fix it by adding protection in mptcp_push_release.
Indeed, you are right, info->mss_now can be set to 0 in some cases but
that's not normal.
Instead of adding a protection here, we preferred fixing the root cause,
see [2]. Do not hesitate to have a look at the other patch and comment
there if you don't agree with this version.
Except if [2] is difficult to backport, I think we don't need your extra
protection. WDYT?
Cheers,
Matt
[1] https://github.com/multipath-tcp/mptcp_net-next/issues/219
[2]
https://patchwork.kernel.org/project/mptcp/patch/286de8f451b32f60e75d3b8bcc4df515e186b930.1629481305.git.pabeni@redhat.com/
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2021-08-24 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 7:19 Jiang Biao
2021-08-24 7:36 ` Matthieu Baerts [this message]
2021-08-24 7:58 ` Jiang Biao
2021-08-25 17:56 ` Mat Martineau
2021-08-26 3:22 ` Jiang Biao
2021-08-30 3:32 ` Jiang Biao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe512c8b-6f5a-0210-3f23-2c1fc75cd6e5@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=benbjiang@gmail.com \
--cc=benbjiang@tencent.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=tcs_robot@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®