From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E35EC2B9F4 for ; Thu, 17 Jun 2021 09:49:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 413AC613CE for ; Thu, 17 Jun 2021 09:49:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231924AbhFQJvf (ORCPT ); Thu, 17 Jun 2021 05:51:35 -0400 Received: from first.geanix.com ([116.203.34.67]:41918 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231873AbhFQJva (ORCPT ); Thu, 17 Jun 2021 05:51:30 -0400 Received: from localhost (unknown [185.17.218.86]) by first.geanix.com (Postfix) with ESMTPSA id 106774C325D; Thu, 17 Jun 2021 09:49:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1623923361; bh=Uk5FCCq/1hvryiYQiavefB+WTK09cJgC9AtSy84qEt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GnnqdQ5V/UeL4MATP7d7kuaHLuKjFWGWmCX7OvdCB+Ed2c88XZ02kn9IIEDwEq4Jj dItGk5y35TPEhcibTjc85UQ2nG1bImQ96nikqRAcUn4iBEcQrx79IK5HgfDvgRMKm/ XIpCFGFRl9rQE7B4paV1KKTidbeIVA4uOSBTOe7kBO7CF+ZGXXZTAPgZ1sU7EQzo/j K9HdgolAGZZ8ulFj8pmxZXR0cvNVWwwe8xrrBM+2m4LF2uJdkJa53Icp9xpZ9WtNYr +w4vyJSNOQ25set5m5akPFMsB0F9/A2L/ssvf5d3RoTPQt1JK0G2/+KfoZYoLkn5XF 0oKYPjd63/SJQ== From: Esben Haabendal To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Rasmus Villemoes , Claudiu Manoil , "David S. Miller" , Jakub Kicinski Subject: [PATCH 3/6] net: gianfar: Clear CAR registers Date: Thu, 17 Jun 2021 11:49:20 +0200 Message-Id: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The CAR1 and CAR2 registers are W1C style registers, to the memset does not actually clear them. Signed-off-by: Esben Haabendal --- drivers/net/ethernet/freescale/gianfar.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index a0277fe8cc60..ebd1065f39fa 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -3103,6 +3103,9 @@ static void gfar_hw_init(struct gfar_private *priv) /* Mask off the CAM interrupts */ gfar_write(®s->rmon.cam1, 0xffffffff); gfar_write(®s->rmon.cam2, 0xffffffff); + /* Clear the CAR registers (w1c style) */ + gfar_write(®s->rmon.car1, 0xffffffff); + gfar_write(®s->rmon.car2, 0xffffffff); } /* Initialize ECNTRL */ -- 2.32.0