From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020096.outbound.protection.outlook.com [52.101.69.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14C4F2C1593; Tue, 10 Mar 2026 14:17:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.96 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773152229; cv=fail; b=BTeB1AcReBveY47R8U79y/H0XY5hDXJKtx7XfdHspeZby/og5gdOVPrbzth16wP9c3h2IWrQLE/04zYnCwfHYO7mnopPhKqVkc9mIUPySZYhy6543qd825O7H2KvlBh5kkBA8PhnNZMMh89ooWmO1PL9sgBAGC5iUWeA+XNivM0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773152229; c=relaxed/simple; bh=8RP12Cf3WPzrKUeK1CAsce4s2jOg2oq1uu59UL5PjHM=; h=Message-ID:Date:From:Subject:To:Cc:References:In-Reply-To: Content-Type:MIME-Version; b=taosMOXCVolOabu12k13XshPd1ztgwQk6/ecO7ZBTUJ6MTi9fuMOHR2q3mb09XZfFfdXZh4IwRww2OYYrBd0WVZ5p0EXc1u0d9hlNRvEfh1MdATqWQf1McNP56IRCsCYiJM3rvhA479dMlXj1/eYIEpk4K0SryMRgkbTmKp56x0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de; spf=pass smtp.mailfrom=kontron.de; dkim=pass (2048-bit key) header.d=kontron.de header.i=@kontron.de header.b=leAKjPei; arc=fail smtp.client-ip=52.101.69.96 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kontron.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kontron.de header.i=@kontron.de header.b="leAKjPei" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oxVUdsea4rurD60LhtZ4trWYJBe7sWLK2GhWUVHAX7T5gy6V3Ee2uuWVoKaGXUvv2FQl8UVwd3BOlE0bciJpD+slvmnJuYX81xhUzD4g2nnD//B+i9n9495MRW1Mcj20fs3sWhJiXJOqgCwl6If7wUQIl4zfmN4MQk0O06j+qNfStI0DzVvv54UNgTnh5/45l+jIPE5VgLYsaRYVntTfmz9wvAw7Dw4NQunAijOZ4mE/YYGH9s4YjDZbLVcffiT3hN2OCFYaT0/xSMJUuVO81g+V7JV9y5Bmd519Dbpt/s2Z+hILVo703eZnOdL1cA92USd5yLz83aPjjlBud/tzZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HuSLZiRFm/8GvPY7B9QBJxZsAmfA7TRm6XfYxr1lU0o=; b=LXF+Pa6ofJKKueKJINiHYiNQrMptFeTGB+r9eWN3MFsrwLNb8200aXIY4kzQ+Z6/OrljxtSqlhe51+kCxYG73ZMeu75vrvJbaMNj3VkvUt7eIR/TzBSYZV6MQZHYnhlXETfc0B3anWFoc+puZANERVFppK1cu9mGq2Snxty5K1bHTwJxxvwiFDrGmwR5vtaOFXdX5eJQ7+7qtsqDLQhTGDwNbQU8BIhkHbU5UoyK/GELhOg90vT1AC87Xq+WFie3UqaSq44kAV9ceZzNHNV8eTrP2Tlwe5SeHBn+7wsehLZfADN7CUjp7YxbXTuxdSl8UtnoYTy+9XD3lB9RBlYFsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kontron.de; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HuSLZiRFm/8GvPY7B9QBJxZsAmfA7TRm6XfYxr1lU0o=; b=leAKjPeit5KJXCqT4zBe2iKnDO86tHoJ3TyQP6mY9s9oC1GiQ7PpJaiJaCMT1r4vI+29Ed8INNPqn1gQN79X+iYP1ibtm6KZ38ztMa2NziOUo8Yz1ewFrb2R12vbNeLXHEMIzEvfEGh6yOSgEqPx1GlcaCMbKAhKNkarlUDVig/j3kkE142yO5HzY0oYkDCHzCGgcmVyxDNC4O69CDcq82F3X8LyVuzKEP7l+YH/fwyhfIL5SzzH43k+I+ipg7vpweCaQVUYcYHBheT2ep31Ub1YfOxb8TAp5bsL8X+BlNIXR4LzxNPyEmu6USU6ZmNIWRe7SJM+Tu5i5asMndUwXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kontron.de; Received: from AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1fb::23) by GV2PR10MB8040.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:ba::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.25; Tue, 10 Mar 2026 14:17:02 +0000 Received: from AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM ([fe80::a276:4ad7:962:da22]) by AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM ([fe80::a276:4ad7:962:da22%3]) with mapi id 15.20.9678.024; Tue, 10 Mar 2026 14:17:02 +0000 Message-ID: Date: Tue, 10 Mar 2026 15:17:01 +0100 User-Agent: Mozilla Thunderbird From: Frieder Schrempf Subject: Re: [PATCH RFC 4/7] mtd: spinand: toshiba: Add RX sampling delay values To: Miquel Raynal , Frieder Schrempf Cc: Mark Brown , Richard Weinberger , Vignesh Raghavendra , Han Xu , Eberhard Stoll , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, imx@lists.linux.dev References: <20260303-fsl-qspi-rx-sampling-delay-v1-0-9326bbc492d6@kontron.de> <20260303-fsl-qspi-rx-sampling-delay-v1-4-9326bbc492d6@kontron.de> <87ldg1nij3.fsf@bootlin.com> Content-Language: en-US, de-DE In-Reply-To: <87ldg1nij3.fsf@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0174.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b7::20) To AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1fb::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR10MB4277:EE_|GV2PR10MB8040:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b1eaea2-9c3e-4ea4-aad0-08de7eafb306 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: Dk9xqjzOVq4cr3a5dTZBMaTioOjUTm7KaKTRIp7nz4lY1rVRQp5npQpTNGMvww7nUEHDFY1kgQXkOsYhctRJDitNM6eMjaRM9DN2OOM/8WgmxjMu66j5xCkoCd5gA5kKiIlpVIa7XlKcaznlIw5vB46O7dGvdCdgsC+HR7KvUtKVyHhxpDtM1vi5oC9ubgWN97uNjfMmKxDL7jpf8S1LCtMN8XTPNj0WPpNJWq0gRzXr+LQ2FMX/h45us/2EI1ZqKUrPO5+B6nMHDHo/aj1W6PBKM+e/SDyGAdiHmQksLhP3O79KSF5nJJHA/KjBqz4eDB5ZBPSCEDncvmCeU9zp42FAvYFX5l5o9X1fCFa4GMbFreKvjuRDml53rxKF3z6G57MxhqUrtDAFtWZyykqokY2LU6gi2GqnraD1gI8I+qHD9Nyr5HO/Ni2hcptQHe9ucDmFNyvRRUWvFahx8jdJVkIA3wDLt5wwYG/aQ/F6j253ilKrFUXJEGScyuF8G/YqZYHikbPORbnWqSOY+rglciCSr79Va24W7l3BMrE+hWNpdRWZ/PbLsHbKrzsZRxcVuDw5LZwlJXHqX0Pr9QK17JWhUSulCa6dbukrDM4F89viaWXC0tmtmaq349BZz+kEpbyNN0QG87gurG7xNYQVhZj9fyc6CN7XiFYXjdKkX4LABPbwZp2oCA+SZl8kNGY9Gr0TOjxm4R+4Qsy90oNXiAQgScIlQsS5iyH6b+nFHdM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHlrZE1RTGQrVFpsOW03aTQ2MXByZzFuY3VwNnpNSFU2SGpHbVI4dCtuWmsz?= =?utf-8?B?NVR0MGpjblNtZnUxQXZIMytjNFRlbEdLaTBUQ3hLTjdPaXFBait0bVVLRHdF?= =?utf-8?B?U2pBdE11MVRqbitEOHlCWkc0bG1DVDNtdEdkOGxGdXVYU3ppVkd6Yk1oeDRS?= =?utf-8?B?Sk5ZRGIzVWZKK1JyVXlSYXA0UDljWHljVVZPTHdPTWxlV0l2bFh2VVZLODI1?= =?utf-8?B?MStjQ2xmdlZUN0lrMjhQQ2hNbldXa1B1NFQvUnZ3cmU4d0FodDVTTnUzWUtw?= =?utf-8?B?UFNvb0VQRHpYeDJaTnRqc1hHUUxramdwKy9va0RLVFhacTNFTlpVYWlxdmll?= =?utf-8?B?TEhqTWNHRzhyWVFkUTFiS2w0VFZoaWlkd0FTOUd6cDM0ZmpGQXB1K1cvQld4?= =?utf-8?B?eWxUMDJ5LzBiSGNsb08xQ0psWW5IaE9zNW4rUzlmVzdVbE5uaWZORk5HZEli?= =?utf-8?B?M1hORDRmYS9ENTFqSEhudDRzS2ErK09ZWkNBTXJFK1Z1ZTFob2VJNFBHeCtO?= =?utf-8?B?RWUzYTRZaVhIQVBMenprSkVwSVFUelpnNlZraWVMeEdNNndDY2tqQlZqKzVn?= =?utf-8?B?N1ZSK1U0RWR3TDF0R09SQVlGVUdjLzA5RGdrWG52dllteW1XYWV0WU5RS2pX?= =?utf-8?B?N0plOW81OVA5dEZvM0kwTUVhN01KZXJhR0FMUGhXMmZRN2hwV0tMeUQxVjhp?= =?utf-8?B?SDA4RTQ1SFg4Qm5Pejh6UVFtTVlLRnFQYjhrK1ZuWlpHdU11TzA0UFQvbWUx?= =?utf-8?B?ZTVJWjR1aU0zR2NPb2o5Ulp4eUxMOVpGSHlkNHZDVURxc29qdXZJQVc0Yy8y?= =?utf-8?B?WEJ4VXpCeCtabzR6b2FKZUlQdm8xRlVxY3lNMmljOGoxUWI2ZFVLR201cWVu?= =?utf-8?B?cC9YOTdmTGZSTjNpNEZ6YkxKQUhTT1V0VHlNajl1Tzk1dTREakxaVDQ3V0c1?= =?utf-8?B?WENIdjF6T2dGTjJhOTNERGlpaHRGTEw3YVI3akdZMlgvTW9UM0lub3pXYllJ?= =?utf-8?B?QVVXK1VYbjB3QjNtL1hxUzdjbC9POW9Ub1NNNDVUa2lwdWorQjVZdnVPUnlL?= =?utf-8?B?c0RQVGFXMDdFTG1SSExoZmJhUFNuM21XM3h6dExYcHBrTU42VzlPamIvM0NB?= =?utf-8?B?YXpGcjZPMnFGRlMwakZ4Tk54aWd5Z0FjK0gxTXM4b01tbFZLc0Vjd2Z2WW9D?= =?utf-8?B?KzBONnRieEJqSUtsZnZKNUVHQUNqZUM0VVAvaXY3cWlUSEs5L0kwR3ZES3Zh?= =?utf-8?B?c0FyUHFNQTd4cWZjNHFnR01oWW5MaDYwT2VtNEt2UWkyWTdoaFZkSjFGZzBT?= =?utf-8?B?TXltUWVXVW8yeXlaOERhR25Kc3cwSHNESlgxazBCK3dJZUtTVzlpamtHc0tQ?= =?utf-8?B?NEpEMXE5SjV0eFBlOHNjUWxoOU9mUEUxdFpSQzBXUXZkNjFEN0xOeXJmMmIz?= =?utf-8?B?d0QrVVYxSEwwa2dmdU1aM2pvaHF1ZlVTa1J5aExmeUVQS3JRQVpVSHplem1x?= =?utf-8?B?Tktqcmp4NllrK0s0M1FwWE9jNUc5Um9ndThIazdVUXpPQlNITURrUTJSTkxS?= =?utf-8?B?a0FXN1N4RlVkbkxnWGhNRzJ2MTVoWXQ2WkMxbVZ0NDBTMk1FSUhmNUVER25z?= =?utf-8?B?Um1VRityR2ZSWm8yYi9CRTVzNTRzbmhmUUFhdG5DdnV5QVBYRmZxTk9RRmV3?= =?utf-8?B?dWJSc1lVelcrVEZ3Y2tHQzBFL2NKUWZNcDJpbHoxaEZjWnFLcEtKYzYzMmZT?= =?utf-8?B?RnRWTHFaME1vOGI0SzFvaFRSTXhkZlIyNGhvL3o0UGZFeStvR3RzSkJ5K2xK?= =?utf-8?B?dE9kZmgyYmxEU2R0VGgyM1E1TGVRSjRjWklqNWlaVEg3YncxUjlhR2s5NXlY?= =?utf-8?B?OW44LzN2aHltMExVcER4RTQ4NFZDeVhqWlFoTWxtbVlzQVNzTGFYdldrckw3?= =?utf-8?B?dkEvdnI1SmhsSXI1YWYzaU56RHJKMXBzc0duZWZmR1dOOVVYQlhCVkZjc3lX?= =?utf-8?B?b2oxVDUxZ3pPdG1NMlVyVDlpRW4xR2I4MENlWFRuellTUkVHdEhKYkRsanhi?= =?utf-8?B?WWcvODU4UVF4NGNsbGlvQnlwUmVaUmhQLzFaT3lJSkU5SlZKOXJGUHJlNDlI?= =?utf-8?B?N1YrSjdUNXdyZUpKOTBBeVh5MHlYOWZIbXJTeTUzSFdLT3VEQkgybG5MTEgr?= =?utf-8?B?ZXdzYWNBcngzeGRmMlZYbEs4R29jNmRCQThTaHA3cGwvZEh4aTlBeThOejNL?= =?utf-8?B?SVpkT1A2UHAyeVZ2d2xnT1NJUS9ndjcwWitOVVRKWkN3S2NFZjEwR0U4UVlL?= =?utf-8?B?bWh0MVpSRTJWMk8rT2p6RS9NZHBpNk9SUmRYRXpyQk52bE9PaDBvWW9xMnZq?= =?utf-8?Q?huObROzuT2SbZh/w=3D?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1eaea2-9c3e-4ea4-aad0-08de7eafb306 X-MS-Exchange-CrossTenant-AuthSource: AM9PR10MB4277.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2026 14:17:02.2166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b7qwUO3Jc5bffimJFBYHUbKqAJXaDE8GcQT6X1HKKYJaTjH4VriFB6GofR32fPlt/5hU04D+vTkJ162CY3zfsryM5LI51Avb2aHJZO2D7Vw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR10MB8040 On 09.03.26 16:12, Miquel Raynal wrote: > >> @@ -277,7 +291,7 @@ static const struct spinand_info toshiba_spinand_table[] = { >> &update_cache_variants), >> 0, >> SPINAND_ECCINFO(&tx58cxgxsxraix_ooblayout, >> - tx58cxgxsxraix_ecc_get_status)), >> + tx58cxgxsxraix_ecc_get_status), >> /* 1.8V 4Gb (1st generation) */ >> SPINAND_INFO("TH58NYG2S3HBAI4", >> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xAC), >> @@ -288,7 +302,7 @@ static const struct spinand_info toshiba_spinand_table[] = { >> &update_cache_x4_variants), >> SPINAND_HAS_QE_BIT, >> SPINAND_ECCINFO(&tx58cxgxsxraix_ooblayout, >> - tx58cxgxsxraix_ecc_get_status)), >> + tx58cxgxsxraix_ecc_get_status), >> /* 1.8V 8Gb (1st generation) */ >> SPINAND_INFO("TH58NYG3S0HBAI6", >> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xA3), >> @@ -299,7 +313,7 @@ static const struct spinand_info toshiba_spinand_table[] = { >> &update_cache_x4_variants), >> SPINAND_HAS_QE_BIT, >> SPINAND_ECCINFO(&tx58cxgxsxraix_ooblayout, >> - tx58cxgxsxraix_ecc_get_status)), >> + tx58cxgxsxraix_ecc_get_status), >> }; > > Are these 3 changes legitimate? No, they are not. This is a last-minute fixup gone wrong.