From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7EE734AAF9 for ; Thu, 12 Feb 2026 12:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770897927; cv=none; b=b5sD3rCKZxxfGPTHqJPbrKkDs1FRrz2bUPDtcgZJkjjoDgSBeWeAkvkPqFMLwWn9pYLJ8cOUlXewlCD+vzh2f6V77nPFMxp/ziqA0wdZhbpxHrnO4xyJtlH5qiZ/mCTdL3tfNa0xfS9vo/DVv9qlD2rR9h+D+WKiMldn5toBzOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770897927; c=relaxed/simple; bh=o2GFVDqXiSLUKn8UeGbPsRZ1svvguHIXozzWU8zIjZY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KU4XyqNqnCvunmfZnMA8U6X+yNcvnL91/XMheVttDWDL3iIVi9Z4ZLjH8FqeVWoNEeCijulNV+XW+I2kwmwwBQQru9/A6/TdltoyjktTTXb+rPeIV8d6bLwhupYVs6OQcJLOa6tHg8TRvsmpj6epC+/KqXydQsWnBziGEygMR4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VpJqUq1x; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=P1rG4Dbv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VpJqUq1x"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="P1rG4Dbv" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CApNbx357714 for ; Thu, 12 Feb 2026 12:05:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qHpGzoa3aopZAtJxfvEehMpSqEZ816kpOkyer+YIROI=; b=VpJqUq1x4U4uaVZ0 8uMfx/11i4i/O5tLZzXy9biQVtAsH1gyOQ2Mj1AfY4TeKOG/LBF20+CuJyem2Cth psNooWPvjpsD/Tf1BdqcXBY545Clbx176K/2RbxMRGF/16J05Row/CnpYKA+R5fV FStFEkGpClfx8tltg8a1yC3ZAAMpx0PvwInuYx0vzO+qIuQ7whWGT6t7Xarxv74e 7h7Rt4NHZrk4mZpvZCmx9b+fqQm1IVWKRCAFzhW6t0/WOGzzIBkmzLPAk5MjVEJ+ JfzpxWIWTnSW/AMnl3wzEOksBV9rJSUZlL7Ocb34lfRU0bntKCSHIqVahF+X70x/ Y/GgIQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c8uy6bp17-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Feb 2026 12:05:24 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8954937be97so22716416d6.1 for ; Thu, 12 Feb 2026 04:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770897924; x=1771502724; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qHpGzoa3aopZAtJxfvEehMpSqEZ816kpOkyer+YIROI=; b=P1rG4DbvXTwogHQiPHoJA46cssDjLbzEelbSKm44tAYDctVIm0jXhV81hu5vZ4k/oe W/mCZdUZQwFIGYU/Bjl1iY5aSzJcD/Kfk7qXZ0xQHcWntxmSn8outCZ5YFE2hI4MPtlO Ipa9A4UebWQ/qPnZkkQldapqb3adRk2npWpdR85KmkU1yg8RkyWkGjtlfVYVyJsWOPFi lGRO4wtoDavpcfffbA7PJDBQERUlkB+AbDfFUz9/KbWe9yujCxkJz5CVhPfpa6gJ4Yh8 1CjN0Sb5ICL382FMalaEW+ukEgI8SoT8W/PJcA374bWA0we33sMw817BBezZKGp4zs9g 5fTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770897924; x=1771502724; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qHpGzoa3aopZAtJxfvEehMpSqEZ816kpOkyer+YIROI=; b=QCBMSTlzn23TYyf1uRoPPn6PJmWgcYc6kCVG5Q+Sf9/C//8hMrIP53boZuXlqjRCSN 2Mj+1zt/fHuSqdpvX955jlqTxiID0Zf+6zHAc8txH8gPiqOlnfAMBV6iVVH7HwDCu/Fb XMQxkKGmI5Zs4eHbMFJ2Xbvi7ePBzghGhLC8mv+FSQPFjVebkyg4/iOCHK8308C4lPpy qPzrr9+ICiDA6wMvi3DsnHdAy4mRkavoyaXHirRqA/xAJ6hyce5vndwQ4rD7U460G4NJ 40Pz1lDBe5ARr4HfiA5MsgtwnDRQjfHTqSIiCz77hMLldVAyxk0QmLgywLx/2oEcu89g cjqg== X-Forwarded-Encrypted: i=1; AJvYcCXV/Hki2yDWAKuM2S5AhZaWlJksU1fvgh78oL6BB6t4yh/xPgS4lqHU5sxX6IVX+cTDjdh/6aF2FbxyFck=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1VXlw5xZnzzK6sXbwql1LUDgmTMnjh2w8/OxvJuN7yByJiLJf SeBGIS2sdF3MMP9ziBii/0axtrmimhHSj/EEgRb5PoDdbTlGDJLFbYDGvH9J2382HgKWnTVRNJ0 jwlHfMVtCDl2I+vNuuBtYheIEgKJ5MHvy5wMZroxw2Y0/KMr5w8ZTYZT8MIaM+kQgvyg= X-Gm-Gg: AZuq6aI2CLoi7rV8ad0M6Bc5U+f+VQ9rCDTlwl0v2OMgBKHPCByDL5GhwrhpfxCU6Lc 2kZQkRxt6MFhFq03JRUEBcKgOGvcGVcXxTxkEc9klKw/rZ9pEz90LVkM604BINBjmTF+0KXb1VF 8LH42C91IEBQ5eScw/eiePYnDofVDnIVR7uSfD2NcrLIg/MVc9OsC5luxliVshQdzA93TsTShWI JK4qITgiVzAXXSIn4/ph260vvF+dcnpG3/d5+aqkwCXyYfhaLE4P1AFb8lmxKqBHadV3ZZ7pRyv WND+FQjKjRuX0qOCG6hIR9rMfbyfajrrShpsY3BRG0z1ZXe6/Li3ZXStcI8rjuDJyJrYE01+ZSv C0wfF4Q0fE9+JH+RnWDJKKjuyBuzpnxAHBXHi8ZuKkkn8o7MWkuh7LX4eV/9nFlu6+DxIim1Ryh bpNa0= X-Received: by 2002:a05:6214:484a:b0:897:1d50:2336 with SMTP id 6a1803df08f44-89727972a48mr28202976d6.6.1770897923676; Thu, 12 Feb 2026 04:05:23 -0800 (PST) X-Received: by 2002:a05:6214:484a:b0:897:1d50:2336 with SMTP id 6a1803df08f44-89727972a48mr28202586d6.6.1770897923258; Thu, 12 Feb 2026 04:05:23 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65b2da1aceasm1112696a12.19.2026.02.12.04.05.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 04:05:22 -0800 (PST) Message-ID: Date: Thu, 12 Feb 2026 13:05:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] soc: qcom: ice: Remove platform_driver support and expose as a pure library To: Manivannan Sadhasivam Cc: manivannan.sadhasivam@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio , Abel Vesa , Adrian Hunter , Ulf Hansson , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, Sumit Garg , stable@vger.kernel.org, Abel Vesa References: <20260210-qcom-ice-fix-v2-0-9c1ab5d6502c@oss.qualcomm.com> <20260210-qcom-ice-fix-v2-1-9c1ab5d6502c@oss.qualcomm.com> <7d61d324-0d26-47ce-aac6-d17abdcf05cd@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDA4OSBTYWx0ZWRfX+T6QdwT3RxsZ pCnfj4OIR28ifj/TzipMDowwiTsmoYznhwG6KWiFFqVlzNC6k+raFbhyIhOmgRFH+16+BjZu4Lu 8uGMnsGi5+XS8qN0PnSjvAe9xL9I6cRCpn/+/am17TczfYutpo2GcvWtAT2gid3DhBIlY6LwuQ/ FFLassIviMcSBlYUp3dyWr+GeMQhIaoDxi1GIeAyxXVL3FiRXBrSI9CdVBQQaf2Cw/JUvFLPFZG y6f8krL6v3PRrFJqQ9vvTwL7xQggorv1jE2GsiqByphVcp7ec76Hk78NBKWDydYpZMvSVIFDVwN lZMvYK+Y1/3l2urq5VUy4HOR/eD7N96xQ0ZU1CV01eUYTgb8VLAu/JJHyGERtJfA71HavNK8qUn Tq5ku3IaD1425BBvOhYAsA5lMHX5FkOroPCla/7GJu6h2C/bJgTfdOHrkiyn7ekHwtFPfh2qvlZ Gvo40ty/4sid/H5VVYA== X-Authority-Analysis: v=2.4 cv=donWylg4 c=1 sm=1 tr=0 ts=698dc204 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=FGFzfvMP8PCZN11w_dYA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: kPBedkKVZLflLieA9vJc42N1C2F_bEpr X-Proofpoint-ORIG-GUID: kPBedkKVZLflLieA9vJc42N1C2F_bEpr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_03,2026-02-11_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120089 On 2/10/26 1:19 PM, Manivannan Sadhasivam wrote: > On Tue, Feb 10, 2026 at 10:39:54AM +0100, Konrad Dybcio wrote: >> On 2/10/26 7:56 AM, Manivannan Sadhasivam via B4 Relay wrote: >>> From: Manivannan Sadhasivam >>> >>> The current platform driver design causes probe ordering races with >>> consumers (UFS, eMMC) due to ICE's dependency on SCM firmware calls. If ICE >>> probe fails (missing ICE SCM or DT registers), devm_of_qcom_ice_get() loops >>> with -EPROBE_DEFER, leaving consumers non-functional even when ICE should >>> be gracefully disabled. devm_of_qcom_ice_get() cannot know if the ICE >>> driver probe has failed due to above reasons or it is waiting for the SCM >>> driver. >> >> [...] >> >>> -static void qcom_ice_put(const struct qcom_ice *ice) >>> +static void qcom_ice_put(struct kref *kref) >>> { >>> - struct platform_device *pdev = to_platform_device(ice->dev); >>> - >>> - if (!platform_get_resource_byname(pdev, IORESOURCE_MEM, "ice")) >>> - platform_device_put(pdev); >>> + platform_device_put(to_platform_device(ice_handle->dev)); >>> + ice_handle = NULL; >>> } >>> >>> static void devm_of_qcom_ice_put(struct device *dev, void *res) >>> { >>> - qcom_ice_put(*(struct qcom_ice **)res); >>> + const struct qcom_ice *ice = *(struct qcom_ice **)res; >>> + struct platform_device *pdev = to_platform_device(ice->dev); >>> + >>> + if (!platform_get_resource_byname(pdev, IORESOURCE_MEM, "ice")) >>> + kref_put(&ice_handle->refcount, qcom_ice_put); >> >> IIUC this makes the refcount go down only in the legacy DT case - why? >> > > It is the other way around, no? Absence of 'ice' reg range in the consumer node > means it is using *new* binding. Yeah obviously you're right I suppose in the legacy case we don't need any refcounting, since there's only a single reference, from the storage controller device.. This assumption would break if someone had a funny idea to specify the same "ice" range for sdcc and ufs though (via the legacy binding), but let's hope no one does that.. Konrad