From: Randy Dunlap <rdunlap@infradead.org>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: dec: tulip: Random spelling fixes throughout the file pnic2.c
Date: Thu, 11 Mar 2021 23:23:05 -0800 [thread overview]
Message-ID: <fe57b506-b737-e3a5-025f-a9cad45a1dca@infradead.org> (raw)
In-Reply-To: <20210312070542.31309-1-unixbhaskar@gmail.com>
On 3/11/21 11:05 PM, Bhaskar Chowdhury wrote:
>
> Random spelling fixes throughout the file.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> drivers/net/ethernet/dec/tulip/pnic2.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/pnic2.c b/drivers/net/ethernet/dec/tulip/pnic2.c
> index 412adaa7fdf8..04daffb8db2a 100644
> --- a/drivers/net/ethernet/dec/tulip/pnic2.c
> +++ b/drivers/net/ethernet/dec/tulip/pnic2.c
> @@ -107,7 +107,7 @@ void pnic2_start_nway(struct net_device *dev)
> */
> csr14 = (ioread32(ioaddr + CSR14) & 0xfff0ee39);
>
> - /* bit 17 - advetise 100baseTx-FD */
> + /* bit 17 - advertise 100baseTx-FD */
OK above. But:
https://en.wikipedia.org/wiki/Autonegotiation
> if (tp->sym_advertise & 0x0100) csr14 |= 0x00020000;
>
> /* bit 16 - advertise 100baseTx-HD */
> @@ -116,7 +116,7 @@ void pnic2_start_nway(struct net_device *dev)
> /* bit 6 - advertise 10baseT-HD */
> if (tp->sym_advertise & 0x0020) csr14 |= 0x00000040;
>
> - /* Now set bit 12 Link Test Enable, Bit 7 Autonegotiation Enable
> + /* Now set bit 12 Link Test Enable, Bit 7 Auto negotiation Enable
> * and bit 0 Don't PowerDown 10baseT
> */
> csr14 |= 0x00001184;
> @@ -157,7 +157,7 @@ void pnic2_start_nway(struct net_device *dev)
> /* all set up so now force the negotiation to begin */
>
> /* read in current values and mask off all but the
> - * Autonegotiation bits 14:12. Writing a 001 to those bits
> + * Auto negotiation bits 14:12. Writing a 001 to those bits
> * should start the autonegotiation
> */
> csr12 = (ioread32(ioaddr + CSR12) & 0xffff8fff);
> @@ -290,7 +290,7 @@ void pnic2_lnk_change(struct net_device *dev, int csr5)
> csr14 = (ioread32(ioaddr + CSR14) & 0xffffff7f);
> iowrite32(csr14,ioaddr + CSR14);
>
> - /* what should we do when autonegotiate fails?
> + /* what should we do when auto negotiate fails?
> * should we try again or default to baseline
> * case. I just don't know.
> *
> --
--
~Randy
prev parent reply other threads:[~2021-03-12 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 7:05 Bhaskar Chowdhury
2021-03-12 7:23 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe57b506-b737-e3a5-025f-a9cad45a1dca@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=unixbhaskar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®