From: Yu-cheng Yu <yu-cheng.yu@intel.com>
To: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@suse.de>,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
"Ravi V. Shankar" <ravi.v.shankar@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Yu-cheng Yu <yu-cheng.yu@intel.com>
Subject: [PATCH v4 08/10] x86/xsaves: Fix XSTATE component offset print out
Date: Fri, 4 Mar 2016 10:12:37 -0800 [thread overview]
Message-ID: <fe57f0f675ff02336140d834bf09c0e96edd206b.1457038929.git.yu-cheng.yu@intel.com> (raw)
In-Reply-To: <cover.1457038929.git.yu-cheng.yu@intel.com>
In-Reply-To: <cover.1457038929.git.yu-cheng.yu@intel.com>
Component offset print out was incorrect for XSAVES. Correct it and move
to a separate function.
Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
---
arch/x86/kernel/fpu/xstate.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index b9d4d59..2e80d6f 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -251,8 +251,6 @@ static void __init setup_xstate_features(void)
WARN_ONCE(last_good_offset > xstate_offsets[i],
"x86/fpu: misordered xstate at %d\n", last_good_offset);
last_good_offset = xstate_offsets[i];
-
- printk(KERN_INFO "x86/fpu: xstate_offset[%d]: %4d, xstate_sizes[%d]: %4d\n", i, ebx, i, eax);
}
}
@@ -355,6 +353,21 @@ static void __init setup_xstate_comp(void)
}
/*
+ * Print out xstate component offsets and sizes
+ */
+static void __init print_xstate_offset_size(void)
+{
+ int i;
+
+ for (i = FIRST_EXTENDED_XFEATURE; i < XFEATURE_MAX; i++) {
+ if (!xfeature_enabled(i))
+ continue;
+ pr_info("x86/fpu: xstate_offset[%d]: %4d, xstate_sizes[%d]: %4d\n",
+ i, xstate_comp_offsets[i], i, xstate_sizes[i]);
+ }
+}
+
+/*
* setup the xstate image representing the init state
*/
static void __init setup_init_fpu_buf(void)
@@ -687,6 +700,7 @@ void __init fpu__init_system_xstate(void)
fpu__init_prepare_fx_sw_frame();
setup_init_fpu_buf();
setup_xstate_comp();
+ print_xstate_offset_size();
pr_info("x86/fpu: Enabled xstate features 0x%llx, context size is %d bytes, using '%s' format.\n",
xfeatures_mask,
--
1.9.1
next prev parent reply other threads:[~2016-03-04 18:17 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 18:12 [PATCH v4 0/10] x86/xsaves: Fix XSAVES known issues Yu-cheng Yu
2016-03-04 18:12 ` [PATCH v4 01/10] x86/xsaves: Define and use user_xstate_size for xstate size in signal context Yu-cheng Yu
2016-03-04 18:12 ` [PATCH v4 02/10] x86/xsaves: Rename xstate_size to kernel_xstate_size to explicitly distinguish xstate size in kernel from user space Yu-cheng Yu
2016-03-04 18:12 ` [PATCH v4 03/10] x86/xsaves: Keep init_fpstate.xsave.header.xfeatures as zero for init optimization Yu-cheng Yu
2016-03-04 18:12 ` [PATCH v4 04/10] x86/xsaves: Introduce a new check that allows correct xstates copy from kernel to user directly Yu-cheng Yu
2016-04-29 20:09 ` Dave Hansen
2016-04-29 22:43 ` Yu-cheng Yu
2016-04-30 0:36 ` Dave Hansen
2016-05-02 15:57 ` Yu-cheng Yu
2016-05-02 16:06 ` Dave Hansen
2016-05-02 16:34 ` Yu-cheng Yu
2016-05-02 16:43 ` Dave Hansen
2016-05-02 17:19 ` Yu-cheng Yu
2016-05-02 17:33 ` Dave Hansen
2016-05-02 21:18 ` Yu-cheng Yu
2016-05-02 21:24 ` Yu-cheng Yu
2016-05-02 21:32 ` Dave Hansen
2016-05-02 22:17 ` Yu-cheng Yu
2016-05-02 22:37 ` Dave Hansen
2016-03-04 18:12 ` [PATCH v4 05/10] x86/xsaves: Align xstate components according to CPUID Yu-cheng Yu
2016-04-29 20:11 ` Dave Hansen
2016-03-04 18:12 ` [PATCH v4 06/10] x86/xsaves: Supervisor state component offset Yu-cheng Yu
2016-03-04 18:12 ` [PATCH v4 07/10] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu
2016-04-29 20:16 ` Dave Hansen
2016-04-29 20:38 ` Borislav Petkov
2016-04-29 20:40 ` Dave Hansen
2016-04-29 20:46 ` Borislav Petkov
2016-04-29 20:25 ` Dave Hansen
2016-04-29 22:30 ` Yu-cheng Yu
2016-04-29 22:36 ` Dave Hansen
2016-04-29 22:38 ` Yu-cheng Yu
2016-03-04 18:12 ` Yu-cheng Yu [this message]
2016-04-29 20:26 ` [PATCH v4 08/10] x86/xsaves: Fix XSTATE component offset print out Dave Hansen
2016-03-04 18:12 ` [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components Yu-cheng Yu
2016-04-29 20:28 ` Dave Hansen
2016-04-29 22:07 ` Yu-cheng Yu
2016-04-29 22:13 ` Dave Hansen
2016-04-29 22:15 ` Yu-cheng Yu
2016-03-04 18:12 ` [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Yu-cheng Yu
2016-04-29 20:32 ` Dave Hansen
2016-04-29 23:12 ` Yu-cheng Yu
2016-04-30 0:40 ` Dave Hansen
2016-05-02 16:11 ` Yu-cheng Yu
2016-05-04 22:15 ` Dave Hansen
2016-05-04 22:21 ` Yu-cheng Yu
2016-05-04 22:41 ` Dave Hansen
2016-05-04 22:46 ` Yu-cheng Yu
2016-05-04 22:46 ` Dave Hansen
2016-04-29 18:09 ` [PATCH v4 0/10] x86/xsaves: Fix XSAVES known issues Dave Hansen
2016-04-29 19:43 ` Ingo Molnar
2016-04-29 19:57 ` Yu-cheng Yu
2016-04-29 20:03 ` Dave Hansen
2016-04-29 20:07 ` Yu-cheng Yu
2016-04-29 20:25 ` Andy Lutomirski
2016-04-29 20:40 ` Dave Hansen
2016-04-29 20:49 ` Andy Lutomirski
2016-04-29 22:42 ` Dave Hansen
2016-04-30 7:53 ` Ingo Molnar
2016-05-02 16:28 ` Dave Hansen
2016-05-02 18:32 ` Ingo Molnar
2016-04-29 20:37 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe57f0f675ff02336140d834bf09c0e96edd206b.1457038929.git.yu-cheng.yu@intel.com \
--to=yu-cheng.yu@intel.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®