From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965450AbeAMDlD (ORCPT + 1 other); Fri, 12 Jan 2018 22:41:03 -0500 Received: from server.coly.li ([162.144.45.48]:35534 "EHLO server.coly.li" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965415AbeAMDlC (ORCPT ); Fri, 12 Jan 2018 22:41:02 -0500 Subject: Re: [PATCH] bcache: io.c: Fix check against error_limit in case of io errors To: Pavel Vazharov , mlyle@lyle.org, kent.overstreet@gmail.com Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org References: <1515766051-13380-1-git-send-email-freakpv@gmail.com> From: Coly Li Message-ID: Date: Sat, 13 Jan 2018 11:40:54 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515766051-13380-1-git-send-email-freakpv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.coly.li X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - coly.li X-Get-Message-Sender-Via: server.coly.li: authenticated_id: i@coly.li X-Authenticated-Sender: server.coly.li: i@coly.li X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 12/01/2018 10:07 PM, Pavel Vazharov wrote: > The actual sysfs io_error_limit value is left shifted IO_ERROR_SHIFT > times before it is stored in the error_limit. > This fixes the un-registering of the cache set when the io_errors reach > the error_limit value. > > Signed-off-by: Pavel Vazharov > --- > drivers/md/bcache/io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/io.c b/drivers/md/bcache/io.c > index fac97ec..1ef6ae2 100644 > --- a/drivers/md/bcache/io.c > +++ b/drivers/md/bcache/io.c > @@ -93,7 +93,7 @@ void bch_count_io_errors(struct cache *ca, blk_status_t error, const char *m) > &ca->io_errors); > errors >>= IO_ERROR_SHIFT; > > - if (errors < ca->set->error_limit) > + if (errors < (ca->set->error_limit >> IO_ERROR_SHIFT)) > pr_err("%s: IO error on %s, recovering", > bdevname(ca->bdev, buf), m); > else > Hi Pavel, A similar fix is also in my device failure patch set, its name is, bcache: set error_limit correctly The difference is, I remove the bit shift of error_limit. -- Coly Li