From: David Ahern <dsahern@kernel.org>
To: Wang Liang <wangliang74@huawei.com>, Simon Horman <horms@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, fw@strlen.de, daniel@iogearbox.net,
yuehaibing@huawei.com, zhangchangzhong@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: fix NULL pointer dereference in l3mdev_l3_rcv
Date: Tue, 18 Mar 2025 20:08:50 -0600 [thread overview]
Message-ID: <fe5947e2-8a91-48f5-9037-f3a48b55fbd6@kernel.org> (raw)
In-Reply-To: <94a34aa3-a823-4550-b16a-179e6f6d6292@huawei.com>
On 3/18/25 3:07 AM, Wang Liang wrote:
>>> It seems to me that checking master->l3mdev_ops like this is racy.
>> vrf device leaves the l3mdev ops set; that is probably the better way
>> to go.
>
> Thanks.
>
> Only l3s ipvlan set the dev->l3mdev_ops to NULL at present, I will delete
> 'dev->l3mdev_ops = NULL' in ipvlan_l3s_unregister(), is that ok?
>
I think that avoids the race you saw. vrf has had the ops for 9 years or
so and not seen that problem.
next prev parent reply other threads:[~2025-03-19 2:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 1:27 Wang Liang
2025-03-18 14:38 ` Simon Horman
2025-03-18 15:02 ` David Ahern
2025-03-19 2:07 ` Wang Liang
2025-03-19 2:08 ` David Ahern [this message]
2025-03-20 13:37 ` Simon Horman
2025-03-21 8:51 ` Wang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe5947e2-8a91-48f5-9037-f3a48b55fbd6@kernel.org \
--to=dsahern@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangliang74@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®