From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "kas@kernel.org" <kas@kernel.org>, "ardb@kernel.org" <ardb@kernel.org>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Zhao, Yan Y" <yan.y.zhao@intel.com>,
"x86@kernel.org" <x86@kernel.org>, "bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH 0/3] Move memory acceptance x86 arch code into EFI stub
Date: Thu, 24 Sep 2026 23:30:10 +0000 [thread overview]
Message-ID: <fe5b400e19742ae3666cd7b3e4bd22164024293f.camel@intel.com> (raw)
In-Reply-To: <arUNjv0rSaAM2xmk@thinkstation>
On Thu, 2026-09-24 at 12:46 +0100, Kiryl Shutsemau wrote:
> > Is there any way we could make some progress here?
> >
> > Ultimately, the thing I am after is to get rid of the call from the
> > decompressor to EFI stub's snprintf(), which I want to remove. For
> > the time being, I am more than happy leaving the memory acceptance where
> > it is, and just dropping the call to snprintf().
>
> Please go ahead with the move. Rick's questions are about what
> tdx_accept_memory() should return, not about where the caller lives,
> and can be sorted out separately.
Yep. I tried to do a quick smoke test and got a similar build error as Boris. I
guess you will send a new revision?
ld: warning: orphan section `.altinstructions' from
`drivers/firmware/efi/libstub/x86-stub.stub.o' being placed in section
`.altinstructions'
ld: warning: orphan section `.altinstr_replacement' from
`drivers/firmware/efi/libstub/x86-stub.stub.o' being placed in section
`.altinstr_replacement'
ld: Unexpected GOT/PLT entries detected!
ld: Unexpected run-time procedure linkages detected!
ld: Unexpected run-time relocations (.rela) detected!
ld: arch/x86/boot/compressed/tdx-shared.o: in function `tdx_panic.cold':
tdx-shared.c:(.text.unlikely+0xc): undefined reference to `__fortify_panic'
ld: tdx-shared.c:(.text.unlikely+0x1e): undefined reference to `__fortify_panic'
ld: drivers/firmware/efi/libstub/x86-stub.stub.o: in function
`arch_accept_memory':
x86-stub.c:(.text+0x17f5): undefined reference to `pv_ops'
ld: drivers/firmware/efi/libstub/x86-stub.stub.o:(.altinstr_replacement+0x1):
undefined reference to `BUG_func'
ld: arch/x86/boot/compressed/vmlinux: hidden symbol `__SCK__WARN_trap' isn't
defined
ld: final link failed: bad value
prev parent reply other threads:[~2026-09-24 23:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 18:37 Ard Biesheuvel
2026-09-14 18:37 ` [PATCH 1/3] x86/tdx: Share tdx_panic() with the " Ard Biesheuvel
2026-09-15 0:02 ` Borislav Petkov
2026-09-15 3:11 ` Borislav Petkov
2026-09-16 7:05 ` Ard Biesheuvel
2026-09-14 18:37 ` [PATCH 2/3] x86/boot: Move unaccepted memory handling out of the decompressor Ard Biesheuvel
2026-09-14 18:37 ` [PATCH 3/3] x86/boot: Drop unused implementation of panic() Ard Biesheuvel
2026-09-14 23:26 ` [PATCH 0/3] Move memory acceptance x86 arch code into EFI stub Borislav Petkov
2026-09-16 18:16 ` Edgecombe, Rick P
2026-09-17 13:32 ` Kiryl Shutsemau
2026-09-17 18:29 ` Edgecombe, Rick P
2026-09-17 23:19 ` Ard Biesheuvel
2026-09-17 23:52 ` Edgecombe, Rick P
2026-09-18 2:12 ` Yan Zhao
2026-09-18 5:28 ` Yan Zhao
2026-09-18 10:45 ` Kiryl Shutsemau
2026-09-23 14:34 ` Ard Biesheuvel
2026-09-24 11:46 ` Kiryl Shutsemau
2026-09-24 23:30 ` Edgecombe, Rick P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe5b400e19742ae3666cd7b3e4bd22164024293f.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=kas@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®