From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4580F46AEFA for ; Tue, 10 Mar 2026 12:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773144316; cv=none; b=N883rG5dyp6/uXHpq3HiwRMlhjSZsGype/InakVX20abPE5mWh5liVZ5l1Qrc1kOZNSToD0T6EIAdxHsDOVdLlhFawwZeSGFPhIUsyOVqV83PjGOsVrHlIdv6opfZewvYb6o9WDg04vDXicnrkjOU8joOxAejIRndXsRkyU5Jbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773144316; c=relaxed/simple; bh=UPNSnzaNstwMAqgCUiJAj9O9oSkFKISI+ZEMSLuKWBk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HJs8noC7LSzBBtip313B8UaIcpdmSJP3VmSETfJ50Z2/lqmi9KtW0YbUt9uWQkzG/O7dFAGwlX01K6+tM176EuuH/dt6pQmzdeuQiPCh/Ip5kFkS9PHLUZL/VizHe46Rica86kMhTEdsBahrd1/st0RnfJ+v1Nx8NCuftPY0Zsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Np5CKVoD; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Np5CKVoD" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4853f2826f7so18466575e9.1 for ; Tue, 10 Mar 2026 05:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773144312; x=1773749112; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UGYa5Q4cyUckI5eNtSwyfOWNmMFs0j1Kmh9C/7v1S9A=; b=Np5CKVoDHGNLcdrJZzQQyQZ5T2ssDNlotf4xekCjmk/s4L84VyjAqZNezvGUDr8hFe +Di87NZlnqlbeQ48YA7nJD9l6jdbTKBiJuptLeVXXapW92yYzQU616Opqp6TciyEgxsh HA8+MCcHBVeH1UZlySGviNS1DBU/RVm2EpMzgMoYBAGj5sEfrwq+LK9SynlgiCSJA82Y RBKg4YrzOyq7vr1ZZGXUo6mdSgfg/k6O7eWt1F4bdVad2jWpzCGOk7jJ4+jf0vlXVBwB +oc3TqmV951iu2c7edMU0DoDm5EVrKOY5gj90q5I4QVKuf6efIl5VUoXvEgK16zeFqsp z5FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773144312; x=1773749112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UGYa5Q4cyUckI5eNtSwyfOWNmMFs0j1Kmh9C/7v1S9A=; b=WI06GHd+sfTaaXazBU9V2iw7ftmBs66qwJ8MU7ubjgW4VsTysay92xyRRqQiUp2z/m XB+SarNcI+XUTnkGjgi1nA2iWinCUHzvmOdBX9SGfUCL3K3FOJh0E8k35qm52IQVpumg Tq5i71nQZcnwLBLs1qXd5YEgyjY+xzyodWtmRW6ammMFR8gaf6dVxmTQrm6ZcsBIfmaB HbuN8aF84cJvcytYWJfCR7CfdVm3naZpvcAk76GuoNPVsXTRXtMI6akYsRYTBMJMYWw/ czG4uoeBhX3THIYnh1Zs8qRpCvyvfBAJuuwXop+CXnN6BOiT+T5uqPyZTJXYQTQLtP9J jaEg== X-Gm-Message-State: AOJu0YwA4sM/2MUwbseNDrZ0xZxAUdiHiM9RzuxJCtzMzfGkFMMg8GOG 9UHaosIGl56CEvy5zn2jyZShRhRx0vsW6cP1YB2XmSi/0kkzRyd0BGSr75LE4Wnb7VQ= X-Gm-Gg: ATEYQzzY9R8Jhr0SPd1L5b0b78YtddifVF2WsV1sA9VCt5wyUYFc5dnPB/ud8fDK/i5 5PxcelXVdmdGm/Cw1W6zFfMyUTg4ltgN/DvSYNH3L5j4wyu3BmHi+HquTmOqVHWmYKIwKAFgl+d TDs5a+OOAgvuEwMJt5lUS2zFR56tKps1O0ijprwjMxw37Ck9DXrBq7VcM93Wotyoe5+EYKrs9Vi dHBYzOvw7jIYqYD17dOT0sHhAmPmGjnuWEG2+Uqqkr1rSemkCg/PsFhJtqnctBqOLUbhHvNIPKw 03wFxpPV0LiWSnoqROguQ7yGkpCz7H8jfWBG3ZuNpBiG/nb8Sl8pZssCjXfTeFrM8/hOhUPj1mI xGqwqIRQ96MizE5O9FYIrDFpVVAT8a01WH8yAYpkaDvdp58GlTpVPDbJsn2TZIY0JchoZMoM5Tt QlAjc0fpmmO4QaTR+LeyP08Mb9fnzjp98= X-Received: by 2002:a05:600c:64ce:b0:485:3ca4:4ef4 with SMTP id 5b1f17b1804b1-4853ca451d9mr96446965e9.9.1773144312371; Tue, 10 Mar 2026 05:05:12 -0700 (PDT) Received: from [10.11.12.108] ([79.115.63.77]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485358cd26bsm133729565e9.8.2026.03.10.05.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 05:05:12 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 14:05:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT] mailbox: exynos: drop superfluous mbox setting per channel To: Wolfram Sang , linux-renesas-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jassi Brar , Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260309074210.2279-2-wsa+renesas@sang-engineering.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <20260309074210.2279-2-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/9/26 9:39 AM, Wolfram Sang wrote: > The core initializes the 'mbox' field exactly like this, so don't > duplicate it in the driver. > > Signed-off-by: Wolfram Sang Reviewed-by: Tudor Ambarus Tested-by: Tudor Ambarus > --- > > Only build-tested. Found because I made the same mistake in my > to-be-upstreamed driver and then looked for that pattern. Testing would > be still much appreciated! > > drivers/mailbox/exynos-mailbox.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mailbox.c > index 5f2d3b81c1db..d2355b128ba4 100644 > --- a/drivers/mailbox/exynos-mailbox.c > +++ b/drivers/mailbox/exynos-mailbox.c > @@ -99,7 +99,6 @@ static int exynos_mbox_probe(struct platform_device *pdev) > struct mbox_controller *mbox; > struct mbox_chan *chans; > struct clk *pclk; > - int i; > > exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL); > if (!exynos_mbox) > @@ -129,9 +128,6 @@ static int exynos_mbox_probe(struct platform_device *pdev) > mbox->ops = &exynos_mbox_chan_ops; > mbox->of_xlate = exynos_mbox_of_xlate; > > - for (i = 0; i < EXYNOS_MBOX_CHAN_COUNT; i++) > - chans[i].mbox = mbox; > - > exynos_mbox->mbox = mbox; > > platform_set_drvdata(pdev, exynos_mbox);