From: Reinette Chatre <reinette.chatre@intel.com>
To: "Moger, Babu" <Babu.Moger@amd.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "corbet@lwn.net" <corbet@lwn.net>,
"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"qianyue.zj@alibaba-inc.com" <qianyue.zj@alibaba-inc.com>,
"xiaochen.shen@intel.com" <xiaochen.shen@intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"Singh, Brijesh" <brijesh.singh@amd.com>,
"Hurwitz, Sherry" <sherry.hurwitz@amd.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
"luto@kernel.org" <luto@kernel.org>,
"joro@8bytes.org" <joro@8bytes.org>,
"jannh@google.com" <jannh@google.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"rian@alum.mit.edu" <rian@alum.mit.edu>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v9 10/13] x86/resctrl: Fix the messages in rdt_last_cmd_printf and rdt_last_cmd_puts
Date: Mon, 26 Nov 2018 14:16:24 -0800 [thread overview]
Message-ID: <fe5c4f4b-e233-875c-1f33-f22c5986b041@intel.com> (raw)
In-Reply-To: <20181121202811.4492-11-babu.moger@amd.com>
Hi Babu and Borislav,
Two typos seemed to have slipped through into the merged commit ...
On 11/21/2018 12:28 PM, Moger, Babu wrote:
> @@ -163,14 +163,14 @@ int parse_cbm(struct rdt_parse_data *data, struct rdt_resource *r,
> * either is exclusive.
> */
> if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, true)) {
> - rdt_last_cmd_printf("overlaps with exclusive group\n");
> + rdt_last_cmd_printf("Overlaps with exclusive group\n");
> return -EINVAL;
> }
>
> if (rdtgroup_cbm_overlaps(r, d, cbm_val, rdtgrp->closid, false)) {
> if (rdtgrp->mode == RDT_MODE_EXCLUSIVE ||
> rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP) {
> - rdt_last_cmd_printf("overlaps with other group\n");
> + rdt_last_cmd_printf("0verlaps with other group\n");
> return -EINVAL;
> }
> }
There is a zero instead of O used in second "Overlaps".
> @@ -1235,7 +1235,7 @@ static ssize_t rdtgroup_mode_write(struct kernfs_open_file *of,
> goto out;
> rdtgrp->mode = RDT_MODE_PSEUDO_LOCKSETUP;
> } else {
> - rdt_last_cmd_printf("unknown/unsupported mode\n");
> + rdt_last_cmd_printf("Unknown orunsupported mode\n");
> ret = -EINVAL;
> }
Missing a space.
Reinette
next prev parent reply other threads:[~2018-11-26 22:16 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 20:28 [PATCH v9 00/13] arch/resctrl: AMD QoS support Moger, Babu
2018-11-21 20:28 ` [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory Moger, Babu
2018-11-22 18:06 ` Borislav Petkov
2018-11-22 21:45 ` [tip:x86/cache] x86/resctrl: Rename and move rdt files to a separate directory tip-bot for Babu Moger
2018-11-23 7:28 ` [PATCH v9 01/13] x86/resctrl: Rename and move rdt files to new directory Ingo Molnar
2018-11-23 8:22 ` Borislav Petkov
2018-11-23 8:41 ` Ingo Molnar
2018-11-23 9:00 ` Borislav Petkov
2018-11-23 11:41 ` Ingo Molnar
2018-11-23 12:43 ` Thomas Gleixner
2018-11-26 18:31 ` Luck, Tony
2018-11-26 19:05 ` Borislav Petkov
2018-12-23 18:27 ` [PATCH v9 00/13] arch/resctrl: AMD QoS support Jan Engelhardt
2018-12-26 17:14 ` Moger, Babu
2018-11-21 20:28 ` [PATCH v9 02/13] x86/resctrl: Rename the RDT functions and definitions Moger, Babu
2018-11-22 21:46 ` [tip:x86/cache] " tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 03/13] x86/resctrl: Re-arrange RDT init code Moger, Babu
2018-11-22 21:47 ` [tip:x86/cache] x86/resctrl: Re-arrange the " tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 04/13] x86/resctrl: Bring all the macros to resctrl/internal.h Moger, Babu
2018-11-22 21:47 ` [tip:x86/cache] x86/resctrl: Move " tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 05/13] x86/resctrl: Initialize the resource functions that are different Moger, Babu
2018-11-22 21:48 ` [tip:x86/cache] x86/resctrl: Initialize the vendor-specific resource functions tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 06/13] x86/resctrl: Bring cbm_validate function into the resource structure Moger, Babu
2018-11-22 21:48 ` [tip:x86/cache] x86/resctrl: Bring cbm_validate() " tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 07/13] x86/resctrl: Add vendor check for MBA software controller Moger, Babu
2018-11-22 21:49 ` [tip:x86/cache] x86/resctrl: Add vendor check for the " tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 08/13] x86/resctrl: Rename config parameter INTEL_RDT to RESCTRL Moger, Babu
2018-11-22 18:46 ` Borislav Petkov
2018-11-22 21:49 ` [tip:x86/cache] x86/resctrl: Rename the config option " tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 09/13] x86/resctrl: Add AMD feature bit X86_FEATURE_MBA in cpuid bits array Moger, Babu
2018-11-22 21:50 ` [tip:x86/cache] x86/resctrl: Add AMD's X86_FEATURE_MBA to the scattered CPUID features tip-bot for Sherry Hurwitz
2018-11-21 20:28 ` [PATCH v9 10/13] x86/resctrl: Fix the messages in rdt_last_cmd_printf and rdt_last_cmd_puts Moger, Babu
2018-11-22 21:51 ` [tip:x86/cache] x86/resctrl: Fixup the user-visible strings tip-bot for Babu Moger
2018-11-26 22:16 ` Reinette Chatre [this message]
2018-11-26 22:28 ` [PATCH v9 10/13] x86/resctrl: Fix the messages in rdt_last_cmd_printf and rdt_last_cmd_puts Borislav Petkov
2018-11-26 22:44 ` Reinette Chatre
2018-11-21 20:28 ` [PATCH v9 11/13] x86/resctrl: Introduce QOS feature for AMD Moger, Babu
2018-11-22 21:51 ` [tip:x86/cache] x86/resctrl: Introduce AMD QOS feature tip-bot for Babu Moger
2018-11-21 20:28 ` [PATCH v9 12/13] Documentation: Rename and update intel_rdt_ui.txt to resctrl_ui.txt Moger, Babu
2018-11-22 21:52 ` [tip:x86/cache] " tip-bot for Babu Moger
2018-11-25 9:07 ` [PATCH v9 12/13] " Pavel Machek
2018-11-21 20:28 ` [PATCH v9 13/13] MAINTAINERS: Update the file and documentation names in arch/x86 Moger, Babu
2018-11-22 21:52 ` [tip:x86/cache] MAINTAINERS: Update resctrl filename patterns tip-bot for Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe5c4f4b-e233-875c-1f33-f22c5986b041@intel.com \
--to=reinette.chatre@intel.com \
--cc=Babu.Moger@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=joro@8bytes.org \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=qianyue.zj@alibaba-inc.com \
--cc=rafael@kernel.org \
--cc=rian@alum.mit.edu \
--cc=sherry.hurwitz@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome