From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 151414014AA for ; Tue, 9 Jun 2026 13:31:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011871; cv=none; b=gYcskkmThffEqESsIKgg+INi2RDoClmGNdbiF1D1GmHErIsWAsAQsFJRV5Bvwt85/Ueqvn94tw6csdyKliPDzU1U5rVkCFkULWkq/2hhGwLx0SCfDoEw0/ThdOtLTsjGPFT6ziHrb381HajZOlJdJ5jlMzHjPrg88IPBuZVC+Tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011871; c=relaxed/simple; bh=PciPETuIrHifr8R1hM7guiG4dpObdPvFcrjqt2Wz96g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mEE7JqYlHWXvZjvMN93HSPPcVFUV2Vtp2UVrb6r3bRirFUs4Ev78tC0x+v4Oiovm2/o0/QCfbidKf97PvaFdPHXT7YCWNnt65aD97nI9VDFNWKfTlJN/nRbhFQ/KVigDgrvRttfQs+1zp3FHvaFx3MTTNlh4H70YM14Ch3erC00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IyKCWtXT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BCf0LeOH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IyKCWtXT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BCf0LeOH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659ClVJA2706177 for ; Tue, 9 Jun 2026 13:31:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n3rIzOQooj4MOQACqpysb+d+qYmh7nMWfhScfIEjQME=; b=IyKCWtXThJnH3jGi FBuiLBA3+AkcvNWAMTnTJVj8H+CRQgbUNoUModwQuoMfMIoQwwuIMLAwE163yFoD IgXBDUf9csguFsdEfijrL1tABqEpNcloP/NgmM2/zAWbJLEqU6uIrGfDZUjZhit6 faHNnBwoK2zpb/SRLUHLncvLQUGoBT7irXmIL/YeLJt2a5BvBe4S8oKrU+i/LGhr IxU5BpGjUNE5LPIpVizYuDQy/HM0bm4+/G3SzJHP7NVudRygKLFFal5r7PpeBFq1 XoBq3v7En6XLHZqsuiJi+msDHmvz6qebpypF/xom/nKR410qskGDh2G2YSTSKvtr VIlnAw== Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epfdt19nr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 13:31:08 +0000 (GMT) Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-43ccdc1edc6so1513318fac.1 for ; Tue, 09 Jun 2026 06:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781011867; x=1781616667; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n3rIzOQooj4MOQACqpysb+d+qYmh7nMWfhScfIEjQME=; b=BCf0LeOHWAf5JcEv/4tsNlnROUOY65+gUZDZcS5b00gQoEQu/fg8JmLUSWEq6HhUAQ pvgJyPI7enx3HepqHioERZn3P/MrSGfjhDDamFrn7S+LEldxLzsyi3h8ghW2ZAs/0n1U kn/znkRTk79y8HiXL382go+4k68360fsMcImLrD7Ya4ONdMeB9KDXIamQpVBjPzAPV4R ry42IdHtlMbAc6mp5ACkAA2APS43zRBOk/5JoHanuVio9VqOCsCn3SXiA70Utd7Z3LdH SagkoOwwXpD/kQ0EhpgJOiPujWsut+aHGlvoKGxIX1FeJ5LV/+/MTEsiTQLci5mnDBB8 VxGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781011867; x=1781616667; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n3rIzOQooj4MOQACqpysb+d+qYmh7nMWfhScfIEjQME=; b=UnF8wR2I2lcdbJd4oLSH+ywVIfGJPMQ6a2jGNdt9og2VlcSAdsKVGhgGvYbcpF60q1 aeEYS+n/sWlgbPvG8PUn7YCWNR0t8gCLvcHvSSzHFGPrSe9GVH2YQOMtwoiQMPHS782G 6NyRMqU20ZL7xVWiH0UI3Re1CaJh+rCtkRFb/0dxiAMNFjy43D1jB447Aw/rgDdiV/pN PNC1PdegLxNmVP5eV5A1tkJ78oBs2I7zXJtNlQ4ngS7t3CZCWlpfVzH3tzxbLs+cOsKN F1GaVe8qwcbAycPriPU4j18ETR1zGegdYmG/NWxtmFlucSL8peF5J9bAoyYVQXgrePIB GnPA== X-Forwarded-Encrypted: i=1; AFNElJ/mapWpcUmCLqlr7HuBDr4YGYFyjuLJ1QOyfGNE4a1QpYaj2BYRMRaNYOfBNSSa+am1d8MvfBZUYQZMKQY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6G1LMxAbVrxkwdqILfcYd2c9LOpKJ7CwgpjyVjlsaCO3Cdoa7 NbutiRG0kfFUhjLn2d11iStT3nAH8wgoiyGyMEjR66oPvAhfhFeZ7HW/lZovnSjyWb9LooGZCJ+ xHJHC6hL3qcRhmIjmWL6ljvuAxkF9c279ZpSQ+ggAja8DX2tG4nNrUCNXScT+hQgr3zc= X-Gm-Gg: Acq92OEXVZFDl/i7IoBJ0CGQrPScdrNwoDiOEdZla6cQQuEjSk8OQJjEkgbKLVCTFA+ MnDDP/NV7ClNH+N5J0EVNJnyU9WkGKX5Dum/VTOwP3kmhOHxkRxF4WdwQQipIa3X34Cjnf/bWJ8 8JxWsDO52CRQCAAEOVqDkHGrWrVLq1lerVymqxN5Mh3SEDOS5Fjd+ngaTuegTW8DAUmxI2oLmzs C599dk0/iax6UMjUtF0K5G3Gz6eYvtdufw1SSMckuvpaVmxpGdKiUpMyArN82psGD6HIaGFQpqF s0P1C77+BWTAmIJysGQ03VO9iJmiaG0zjypGJBw9xFO7WfeYu+xvKRFr79MsOcT0gEO8c1k3fTr phZTlMfr05oi6PphZrwcM6nHAo+o7q7ZtjQUTmZ4hFklfwaVpz+i7e1M3 X-Received: by 2002:a4a:db85:0:b0:69d:513e:1a69 with SMTP id 006d021491bc7-69e68bce04bmr4357197eaf.2.1781011867316; Tue, 09 Jun 2026 06:31:07 -0700 (PDT) X-Received: by 2002:a4a:db85:0:b0:69d:513e:1a69 with SMTP id 006d021491bc7-69e68bce04bmr4357168eaf.2.1781011866448; Tue, 09 Jun 2026 06:31:06 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf055500875sm1029528666b.53.2026.06.09.06.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 06:31:05 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 15:31:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] powercap: qcom: Add SPEL powercap driver To: Manaf Meethalavalappu Pallikunhi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio , Daniel Lezcano Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Gaurav Kohli References: <20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com> <20260519-qcom_spel_driver_upstream-v1-2-75356d1b7f94@oss.qualcomm.com> <7ea2f2cc-ef11-4727-810c-e32e815bd973@oss.qualcomm.com> <8f045340-a6c8-41c7-b1c7-6d9b87b05d90@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <8f045340-a6c8-41c7-b1c7-6d9b87b05d90@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: OMlhjLkm5aAI-m136CjvdKJ-T930tvSP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEyOCBTYWx0ZWRfX5NUeWkPM/xEL d2jOEV20/aiZUcR8wvDdzh/F+8hfXKjSPfHJnJUNb36IipS4Uii41hjGeKPFoM5LXTOdH+LuCfc LSTOcBUatlsBUkHMndBkudCLyAO8KcF6WUAygsp/2u6t5TjRQuaZMqkiSlqmK/1wOFGfkecWhBB Zp5PGcnn1eXi9UyXB2wYqkYMjGcE6U/z2CvpLsbdGNYN8AdG5vZ98yP0eZBEuxV5+QvNHOwkpKM X2f0/PM3soGpYGcYSrBLUNyFRr1PUN63XdmdpOk4hMkuy4DUWZiVgyosSq7MG6JnZrZPkm9+Vde WU5+W1CmuclddxjeT9WOBLykln343PlJRfRY1Dlg9EU16r6y+MTpmI6NSQvVcaTnTcsMkX0p9a3 ztkum0qxMozbLh3arpX1CZ02e6ldVHzo8BiZ00EBVw5Dfc/QRJXRXSVGEcWTMXjDzkq/lVctZ6t Mpl4ZT7BSVPT1pc3QoA== X-Proofpoint-GUID: OMlhjLkm5aAI-m136CjvdKJ-T930tvSP X-Authority-Analysis: v=2.4 cv=doTrzVg4 c=1 sm=1 tr=0 ts=6a28159c cx=c_pps a=nSjmGuzVYOmhOUYzIAhsAg==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=VKwP4syk8cgDA61-jkoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1zu1i0D7hVQfj8NKfPKu:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090128 On 6/9/26 3:23 PM, Manaf Meethalavalappu Pallikunhi wrote: > Hi Konrad, > > > On 5/21/2026 4:46 PM, Konrad Dybcio wrote: >> On 5/19/26 12:49 PM, Manaf Meethalavalappu Pallikunhi wrote: >>> The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware >>> based power monitoring and limiting capabilities for various power >>> domains including System, SoC, CPU clusters, GPU, and various other >>> subsystems. >>> >>> The driver integrates with the Linux powercap framework, exposing SPEL >>> capabilities through powercap sysfs interfaces. >>> >>> Signed-off-by: Manaf Meethalavalappu Pallikunhi >>> --- [...] >>> +static void spel_remove(struct platform_device *pdev) >>> +{ >>> +    struct spel_system *sp = platform_get_drvdata(pdev); >>> +    int i; >>> + >>> +    if (!sp) >>> +        return; >>> + >>> +    /* Unregister in reverse order: children first, then SOC, then SYS */ >>> +    for (i = SPEL_DOMAIN_MAX - 1; i >= 0; i--) >>> +        powercap_unregister_zone(sp->control_type, &sp->domains[i].power_zone); >> >> Could you try adding a devm_ variant of these register functions? > > Powercap framework doesn't support any devm_* API, you meant add this support in framework in this series ? Yes, this should be fairly trivial - look at e.g. drivers/regulator/devres.c : devm_of_regulator_get Konrad