From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 737A8C433DB for ; Tue, 9 Feb 2021 03:43:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3264364EAC for ; Tue, 9 Feb 2021 03:43:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbhBIDmj (ORCPT ); Mon, 8 Feb 2021 22:42:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20011 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbhBIDcI (ORCPT ); Mon, 8 Feb 2021 22:32:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612841399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JRORgz0YSFQe9iXRMxk94+EQKeid0Wnlsj0cWrgcF38=; b=g2F5YmKnyR6wkcaDbfkBQeKb/BEQ47E1FjZbkFIVlfYDxJUsA6Nl9i6jQijp1oBFekEm0F d/Vsz07pxmIWj5Kw4uDMFxnPNUKjN95oQR6wlHdiCxZ+NV6WSFuBj6Dsi3V+RyS8jIS28r 5+FTc1yw5mGKkE4do22vPCA5KwQGrHs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-RmmPPVr_MhiQFaTzDjLydA-1; Mon, 08 Feb 2021 22:29:56 -0500 X-MC-Unique: RmmPPVr_MhiQFaTzDjLydA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D960107ACED; Tue, 9 Feb 2021 03:29:55 +0000 (UTC) Received: from [10.72.13.32] (ovpn-13-32.pek2.redhat.com [10.72.13.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 84A4663B8C; Tue, 9 Feb 2021 03:29:47 +0000 (UTC) Subject: Re: [PATCH V3 16/19] virtio-pci: introduce modern device module To: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, shahafs@mellanox.com, lulu@redhat.com, sgarzare@redhat.com, rdunlap@infradead.org References: <20210104065503.199631-1-jasowang@redhat.com> <20210104065503.199631-17-jasowang@redhat.com> <20210205103214-mutt-send-email-mst@kernel.org> <24cb3ebe-1248-3e31-0716-cf498cf1d728@redhat.com> <20210208070253-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: Date: Tue, 9 Feb 2021 11:29:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210208070253-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/8 下午8:04, Michael S. Tsirkin wrote: > On Mon, Feb 08, 2021 at 01:42:27PM +0800, Jason Wang wrote: >> On 2021/2/5 下午11:34, Michael S. Tsirkin wrote: >>> On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote: >>>> Signed-off-by: Jason Wang >>> I don't exactly get why we need to split the modern driver out, >>> and it can confuse people who are used to be seeing virtio-pci. >> >> The virtio-pci module still there. No user visible changes. Just some codes >> that could be shared with other driver were split out. >> > What I am saying is this: we can have virtio-vdpa depend on > virtio-pci without splitting the common code out to an > extra module. Ok. > >>> The vdpa thing so far looks like a development tool, why do >>> we care that it depends on a bit of extra code? >> >> If I'm not misunderstanding, trying to share codes is proposed by you here: >> >> https://lkml.org/lkml/2020/6/10/232 >> >> We also had the plan to convert IFCVF to use this library. >> >> Thanks > If that happens then an extra module might become useful. So does it make sense that I post a new version and let's merge it first. Then Intel or I can convert IFCVF to use the library? Thanks >