From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46468C00528 for ; Thu, 3 Aug 2023 11:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235691AbjHCL7h (ORCPT ); Thu, 3 Aug 2023 07:59:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234690AbjHCL7f (ORCPT ); Thu, 3 Aug 2023 07:59:35 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A09426BA; Thu, 3 Aug 2023 04:59:34 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A8065A4; Thu, 3 Aug 2023 13:58:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691063908; bh=RT7rKebX3umkthzwSncQznVIc6lMU58Y2I9IpWZTk/8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tq+ScKaZYYq+H6B6wdd5zeVOtNtUgExQY5hP+bgvKqV06m0VK1FC7Yg33ZCAaCbrs fHIuXquq/ne8ECWvSmU+QkKZPukMbRqp5QMa0kCn+veLRCEZoI/zeV1QarKlCyqPHF tpU26fubATYc8Vy8rbG76j5+itcnONCGI2AuQBrk= Message-ID: Date: Thu, 3 Aug 2023 14:59:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] media: i2c: ds90ub9x3: Fix use of uninitialized variables Content-Language: en-US To: Andy Shevchenko Cc: Mauro Carvalho Chehab , Laurent Pinchart , Sakari Ailus , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230803-ub9xx-uninit-vars-v1-0-284a5455260f@ideasonboard.com> <20230803-ub9xx-uninit-vars-v1-1-284a5455260f@ideasonboard.com> From: Tomi Valkeinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2023 14:57, Andy Shevchenko wrote: > On Thu, Aug 03, 2023 at 11:41:38AM +0300, Tomi Valkeinen wrote: >> smatch reports some uninitialized variables: >> >> drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v1'. >> drivers/media/i2c/ds90ub913.c:481 ub913_log_status() error: uninitialized symbol 'v2'. >> drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_local_data'. >> drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'. >> drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'. >> >> These are used only for printing debug information, and the use of an >> uninitialized variable only happens if an i2c transaction has failed, >> which will print an error. Thus, fix the errors just by initializing the >> variables to 0. >> >> Fixes: 6363db1c9d45 ("media: i2c: add DS90UB953 driver") >> Fixes: c158d0d4ff15 ("media: i2c: add DS90UB913 driver") > > I would prefer two separate changes on per driver basis. This is a good > practice to make backporting easier (generally speaking). Yes, I almost did that, but then somehow got hit by acute laziness... I'll send a v2 with split patches. Tomi