From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39589415F3B for ; Fri, 2 Oct 2026 07:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790925782; cv=none; b=LO1FjFXC4I1eZWfEMm8CXtKwqRnyqID/1MUx+abyWM/HVvizRgeD4M/Qg4TOCTjpQ4ApFND/XPIQ9HxZPflrj3IQUEQXTRAZTOSoGUKWRWNZtB/rw+FINDQUT6neHGI1pKJbRUaQ2HBk83AY/BN1S4L+WCeiF1tZ1WU3jSinDNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790925782; c=relaxed/simple; bh=lsrf0jsN7EgcEDWYmJA3Mw8QxEs/CL0J8Fp7vM7zsAw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Jx9lb41JVnrxavBF646FDRyKsVJOUkYYHZHW5fXgHsl5EHU6muY0yWAXVzZCyhI6ZSlpVkJSHqeBZnr4dJ4IJEDbrSTZw6Wv1hOm5DfbLWCvMF+qZFwpDYl6oa0QuGr3phevuntuieaHhdD4cM81wELmMWRMoJtzmxtn3DHclKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from edelgard.fodlan.icenowy.me (unknown [112.94.101.54]) by APP-03 (Coremail) with SMTP id rQCowAC3wT_CW79qxa5fCQ--.28708S2; Fri, 02 Oct 2026 15:22:43 +0800 (CST) Message-ID: Subject: Re: [PATCH] drm/verisilicon: use ERR_CAST instead of ERR_PTR(PTR_ERR()) From: Icenowy Zheng To: Aryan Sinha , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Fri, 02 Oct 2026 15:22:42 +0800 In-Reply-To: <20261001163104.51165-1-sinha.aryan03@gmail.com> References: <20261001163104.51165-1-sinha.aryan03@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID:rQCowAC3wT_CW79qxa5fCQ--.28708S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Kr1xAr4fGr4UJr13tr4ktFb_yoW8AFyrpa yjvay0yryrZw47Xr9rAa1qkFy5AasrKwsagr47JwsYvr4vyF1DWFn8Ary5AF98Jay7GrWS qF4vkF1FkryI9FUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkYb7Iv0xC_Zr1lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCY1x0262kKe7AKxVWUAVWUtwCF04k2 0xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI 8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41l IxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIx AIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2 jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU89Z23UUUUU== X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ =E5=9C=A8 2026-10-01=E5=9B=9B=E7=9A=84 22:00 +0530=EF=BC=8CAryan Sinha=E5= =86=99=E9=81=93=EF=BC=9A > ERR_CAST says the same thing without the round trip through an error > code. Yes, I didn't know this thing yet when I was creating this driver. ``` Reviewed-by: Icenowy Zheng ``` Thanks for this patch! Icenowy >=20 > Signed-off-by: Aryan Sinha > --- > =C2=A0drivers/gpu/drm/verisilicon/vs_bridge.c | 2 +- > =C2=A0drivers/gpu/drm/verisilicon/vs_crtc.c=C2=A0=C2=A0 | 2 +- > =C2=A02 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/verisilicon/vs_bridge.c > b/drivers/gpu/drm/verisilicon/vs_bridge.c > index dc7c85b07..32f9984d8 100644 > --- a/drivers/gpu/drm/verisilicon/vs_bridge.c > +++ b/drivers/gpu/drm/verisilicon/vs_bridge.c > @@ -322,7 +322,7 @@ struct vs_bridge *vs_bridge_init(struct > drm_device *drm_dev, > =C2=A0 bridge =3D devm_drm_bridge_alloc(drm_dev->dev, struct > vs_bridge, base, > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bridge_funcs); > =C2=A0 if (IS_ERR(bridge)) > - return ERR_PTR(PTR_ERR(bridge)); > + return ERR_CAST(bridge); > =C2=A0 > =C2=A0 bridge->crtc =3D crtc; > =C2=A0 bridge->intf =3D intf; > diff --git a/drivers/gpu/drm/verisilicon/vs_crtc.c > b/drivers/gpu/drm/verisilicon/vs_crtc.c > index 0b8a35d09..af8e33c96 100644 > --- a/drivers/gpu/drm/verisilicon/vs_crtc.c > +++ b/drivers/gpu/drm/verisilicon/vs_crtc.c > @@ -172,7 +172,7 @@ struct vs_crtc *vs_crtc_init(struct drm_device > *drm_dev, struct vs_dc *dc, > =C2=A0 primary =3D vs_primary_plane_init(drm_dev, dc); > =C2=A0 if (IS_ERR(primary)) { > =C2=A0 drm_err(drm_dev, "Couldn't create the primary > plane\n"); > - return ERR_PTR(PTR_ERR(primary)); > + return ERR_CAST(primary); > =C2=A0 } > =C2=A0 > =C2=A0 /* Create our cursor plane */