From: fangxiaozhi 00110321 <fangxiaozhi@huawei.com>
To: <linux-usb@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <zihan@huawei.com>,
<Lin.Lei@huawei.com>, <greg@kroah.com>, <neil.yi@huawei.com>,
<wangyuhua@huawei.com>, <huqiao36@huawei.com>, <balbi@ti.com>,
<mdharm-usb@one-eyed-alien.net>, <sebastian@breakpoint.cc>
Subject: [PATCH 1/1]linux-usb: fix the product IDs to be little endian in initializers.c
Date: Wed, 6 Feb 2013 17:24:12 +0800 [thread overview]
Message-ID: <fe6feaa260b9.60b9fe6feaa2@huawei.com> (raw)
From: fangxiaozhi <huananhu@huawei.com>
1. The idProduct is little endian, so make the product ID's value to be little endian. Make no break on big endian processors.
Signed-off-by: fangxiaozhi <huananhu@huawei.com>
--------------------------------------------------------------------
diff -uprN linux-3.8-rc6_orig/drivers/usb/storage/initializers.c linux-3.8-rc6/drivers/usb/storage/initializers.c
--- linux-3.8-rc6_orig/drivers/usb/storage/initializers.c 2013-02-06 14:48:51.564355283 +0800
+++ linux-3.8-rc6/drivers/usb/storage/initializers.c 2013-02-06 15:11:40.925434289 +0800
@@ -152,12 +152,15 @@ static int usb_stor_huawei_dongles_pid(s
* means the dongle in the single port mode,
* and a switch command is required to be sent. */
if (idesc && idesc->bInterfaceNumber == 0) {
- if ((idProduct == 0x1001)
- || (idProduct == 0x1003)
- || (idProduct == 0x1004)
- || (idProduct >= 0x1401 && idProduct <= 0x1500)
- || (idProduct >= 0x1505 && idProduct <= 0x1600)
- || (idProduct >= 0x1c02 && idProduct <= 0x2202)) {
+ if ((idProduct == cpu_to_le16(0x1001))
+ || (idProduct == cpu_to_le16(0x1003))
+ || (idProduct == cpu_to_le16(0x1004))
+ || (idProduct >= cpu_to_le16(0x1401)
+ && idProduct <= cpu_to_le16(0x1500))
+ || (idProduct >= cpu_to_le16(0x1505)
+ && idProduct <= cpu_to_le16(0x1600))
+ || (idProduct >= cpu_to_le16(0x1c02)
+ && idProduct <= cpu_to_le16(0x2202))) {
return 1;
}
}
@@ -169,7 +172,7 @@ int usb_stor_huawei_init(struct us_data
int result = 0;
if (usb_stor_huawei_dongles_pid(us)) {
- if (us->pusb_dev->descriptor.idProduct >= 0x1446)
+ if (us->pusb_dev->descriptor.idProduct >= cpu_to_le16(0x1446))
result = usb_stor_huawei_scsi_init(us);
else
result = usb_stor_huawei_feature_init(us);
next reply other threads:[~2013-02-06 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 9:24 fangxiaozhi 00110321 [this message]
2013-02-06 17:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe6feaa260b9.60b9fe6feaa2@huawei.com \
--to=fangxiaozhi@huawei.com \
--cc=Lin.Lei@huawei.com \
--cc=balbi@ti.com \
--cc=greg@kroah.com \
--cc=huqiao36@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=neil.yi@huawei.com \
--cc=sebastian@breakpoint.cc \
--cc=wangyuhua@huawei.com \
--cc=zihan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome