mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Gordeev <agordeev@linux.ibm.com>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/5] s390/char: replace page allocator calls with k[mz]alloc()
Date: Fri, 20 Nov 2026 08:02:50 +0100	[thread overview]
Message-ID: <fe72024b-da3d-44ba-ad41-79dd5da7fac2-agordeev@linux.ibm.com> (raw)
In-Reply-To: <20261108-s390-char-ready-v1-0-3db507722530@kernel.org>

On Sun, Nov 08, 2026 at 10:48:57AM +0200, Mike Rapoport (Microsoft) wrote:
> This the next episode of conversion of page allocator calls to kmalloc
> family :)
> 
> This series covers s390 character drivers other than SCLP.
> 
> = tl;dr cover letter copied from the previous posts:
> 
> This is a (small) part of larger work of replacing page allocator calls
> with kmalloc.
> 
> My initial intention a few month ago was to remove ugly casts [1], but then
> willy pointed out that Linus objected to something like this [2] and it
> looks like more than a decade old technical debt.
> 
> Largely, anything that doesn't need struct page (or a memdesc in the
> future) should just use kmalloc() or kvmalloc() to allocate memory.
> kmalloc() guarantees alignment, physical contiguity and working
> virt_to_phys() and beside nicer API that returns void * on alloc and
> doesn't require to know the allocation size on free, kmalloc() provides
> better debugging capabilities than page allocator.
> 
> Another thing is that touching these allocation sites gives the reviewers
> opportunity to see if a PAGE_SIZE buffer is actually needed or maybe
> another size is appropriate.
> 
> For larger allocations that don't need physically contiguous memory
> kvmalloc() can be a better option that __get_free_pages() because under
> memory pressure it's is easier to allocate several order-0 pages than a
> physically contiguous chunk with the same number of pages.
> 
> And last, but not least, removing needless calls to page allocator should
> help with memdesc (aka project folio) conversion. There will be way less
> places to audit to see if the user was actually using struct page.
> 
> The patches are deliberately kept small, so that every conversion can be
> reviewed, and if needed reverted, on its own.
> 
> Also in git:
> https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git gfp-to-kmalloc/s390-char
> 
> [1] https://lore.kernel.org/all/20251018093002.3660549-1-rppt@kernel.org/
> [2] https://lore.kernel.org/all/CA+55aFwp4iy4rtX2gE2WjBGFL=NxMVnoFeHqYa2j1dYOMMGqxg@mail.gmail.com/
> 
> ---
> Mike Rapoport (Microsoft) (5):
>       s390/zcore: Replace __get_free_page() with kmalloc()
>       s390/vmur: Replace __get_free_page() with kmalloc()
>       s390/vmlogrdr: Replace get_zeroed_page() with kzalloc()
>       s390/uvdevice: Replace get_zeroed_page() with kzalloc()
>       s390/hmcdrv: Replace page allocator calls with k[mz]alloc()
> 
>  drivers/s390/char/diag_ftp.c     |  5 +++--
>  drivers/s390/char/hmcdrv_cache.c | 18 +++++++++---------
>  drivers/s390/char/hmcdrv_ftp.c   | 14 +++++++-------
>  drivers/s390/char/uvdevice.c     |  4 ++--
>  drivers/s390/char/vmlogrdr.c     |  4 ++--
>  drivers/s390/char/vmur.c         |  8 ++++----
>  drivers/s390/char/zcore.c        |  8 ++++----
>  7 files changed, 31 insertions(+), 30 deletions(-)

> Sincerely yours,
> Mike.

Applied, thanks!

      parent reply	other threads:[~2026-11-20  7:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  8:48 Mike Rapoport (Microsoft)
2026-11-08  8:48 ` [PATCH 1/5] s390/zcore: Replace __get_free_page() with kmalloc() Mike Rapoport (Microsoft)
2026-11-16 13:10   ` Heiko Carstens
2026-11-08  8:48 ` [PATCH 2/5] s390/vmur: " Mike Rapoport (Microsoft)
2026-11-16 13:12   ` Heiko Carstens
2026-11-08  8:49 ` [PATCH 3/5] s390/vmlogrdr: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-16 13:14   ` Heiko Carstens
2026-11-08  8:49 ` [PATCH 4/5] s390/uvdevice: " Mike Rapoport (Microsoft)
2026-11-16 13:15   ` Heiko Carstens
2026-11-08  8:49 ` [PATCH 5/5] s390/hmcdrv: Replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-16 13:46   ` Heiko Carstens
2026-11-17 12:44     ` Mike Rapoport
2026-11-18 14:26       ` Heiko Carstens
2026-11-20  7:02 ` Alexander Gordeev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe72024b-da3d-44ba-ad41-79dd5da7fac2-agordeev@linux.ibm.com \
    --to=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®