From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@osdl.org>, Holger Macht <hmacht@suse.de>
Cc: Brice.Goglin@ens-lyon.org, linux-kernel@vger.kernel.org,
Andy Whitcroft <apw@shadowen.org>
Subject: [PATCH] backlight users need to select BACKLIGHT_CLASS_DEVICE
Date: Tue, 17 Oct 2006 13:54:22 +0100 [thread overview]
Message-ID: <fe75efd7d8608c949bd6be9c78ed54c4@pinky> (raw)
In-Reply-To: <45349744.9040508@ens-lyon.org>
I seem to have a similar issue, but with ACPI_TOSHIBA=y. It does not
look like the backlight support is intended to be optional. I also
note that ACPI_SONY is already select'ing BACKLIGHT_CLASS_DEVICE
directly.
The attached patch seems like the right thing. I have tested this
with the config I had showing the problem. My kernels now compile
again.
Seems that this change comes in from the following patch:
add-support-for-the-generic-backlight-device-to-the-toshiba-acpi-driver
Does this seem sane?
Holger?
-apw
=== 8< ===
backlight users need to select BACKLIGHT_CLASS_DEVICE
When compiling 2.6.19-rc2-mm1 we get the following link
failures:
drivers/built-in.o(.init.text+0x3076): In function `toshiba_acpi_init':
: undefined reference to `backlight_device_register'
drivers/built-in.o(.exit.text+0x170): In function `toshiba_acpi_exit':
: undefined reference to `backlight_device_unregister'
When we build an ACPI module which provides backlight
support we need to ensure that the backlight class
device is selected.
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 335da3e..819331d 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -179,7 +179,7 @@ config ACPI_NUMA
config ACPI_ASUS
tristate "ASUS/Medion Laptop Extras"
depends on X86
- select BACKLIGHT_DEVICE
+ select BACKLIGHT_CLASS_DEVICE
---help---
This driver provides support for extra features of ACPI-compatible
ASUS laptops. As some of Medion laptops are made by ASUS, it may also
@@ -208,7 +208,7 @@ config ACPI_ASUS
config ACPI_IBM
tristate "IBM ThinkPad Laptop Extras"
depends on X86
- select BACKLIGHT_DEVICE
+ select BACKLIGHT_CLASS_DEVICE
---help---
This is a Linux ACPI driver for the IBM ThinkPad laptops. It adds
support for Fn-Fx key combinations, Bluetooth control, video
@@ -234,7 +234,7 @@ config ACPI_IBM_DOCK
config ACPI_TOSHIBA
tristate "Toshiba Laptop Extras"
depends on X86
- select BACKLIGHT_DEVICE
+ select BACKLIGHT_CLASS_DEVICE
---help---
This driver adds support for access to certain system settings
on "legacy free" Toshiba laptops. These laptops can be recognized by
next prev parent reply other threads:[~2006-10-17 12:59 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 6:06 2.6.19-rc2-mm1 Andrew Morton
[not found] ` <a44ae5cd0610170003r77595cc0p8ed66badde952859@mail.gmail.com>
2006-10-17 7:36 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-17 8:41 ` 2.6.19-rc2-mm1 Brice Goglin
2006-10-17 12:54 ` Andy Whitcroft [this message]
2006-10-17 13:17 ` 2.6.19-rc2-mm1 Rafael J. Wysocki
2006-10-17 14:23 ` 2.6.19-rc2-mm1 Andy Whitcroft
2006-10-17 16:07 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-17 18:22 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 22:44 ` 2.6.19-rc2-mm1 Dylan Taft
2006-10-17 15:45 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-17 18:29 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-20 13:40 ` 2.6.19-rc2-mm1 Carsten Otte
2006-10-17 19:37 ` 2.6.19-rc2-mm1 Jeremy Fitzhardinge
2006-10-17 20:22 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 10:05 ` 2.6.19-rc2-mm1 Michael Ellerman
2006-10-18 19:05 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-17 19:53 ` [2.6.19-rc2-mm1] error: too few arguments to function ‘crypto_alloc_hash’ Andrew James Wade
2006-10-17 21:19 ` Edward Shishkin
2006-10-18 16:53 ` Andrew James Wade
2006-10-18 15:33 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 15:48 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 17:15 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 17:26 ` 2.6.19-rc2-mm1 Chris Mason
2006-10-18 17:32 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 17:41 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 17:56 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 17:58 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 18:14 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 18:22 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 18:31 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 23:59 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 22:44 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 23:01 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-18 23:25 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 0:07 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-19 0:21 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 15:28 ` 2.6.19-rc2-mm1 Badari Pulavarty
2006-10-19 12:32 ` 2.6.19-rc2-mm1 Andi Kleen
2006-10-19 16:18 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 16:57 ` 2.6.19-rc2-mm1 Andi Kleen
2006-10-18 18:27 ` 2.6.19-rc2-mm1 Gabriel C
2006-10-18 19:18 ` 2.6.19-rc2-mm1 Rafael J. Wysocki
2006-10-18 19:33 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-18 19:42 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-18 20:20 ` 2.6.19-rc2-mm1 Rafael J. Wysocki
2006-10-18 20:26 ` 2.6.19-rc2-mm1 Cedric Le Goater
2006-10-18 22:23 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 16:05 ` 2.6.19-rc2-mm1 Carsten Otte
2006-10-19 18:10 ` 2.6.19-rc2-mm1 Nick Piggin
2006-10-20 7:37 ` 2.6.19-rc2-mm1 Carsten Otte
2006-10-18 20:22 ` 2.6.19-rc2-mm1 Gabriel C
2006-10-18 18:42 ` 2.6.19-rc2-mm1 Gabriel C
2006-10-18 21:44 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 22:29 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 22:41 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 22:46 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-18 22:57 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 23:04 ` 2.6.19-rc2-mm1 Jiri Kosina
2006-10-18 23:12 ` 2.6.19-rc2-mm1 Andrew Morton
2006-10-19 14:45 ` 2.6.19-rc2-mm1 // errors in verify_redzone_free() Mariusz Kozlowski
2006-10-19 17:03 ` Andrew Morton
2006-10-19 17:17 ` Jean Tourrilhes
2006-10-19 17:25 ` Andrew Morton
2006-10-19 17:47 ` Jean Tourrilhes
2006-10-19 18:31 ` Mariusz Kozlowski
2006-10-19 18:33 ` Jean Tourrilhes
2006-10-19 17:33 ` Mariusz Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe75efd7d8608c949bd6be9c78ed54c4@pinky \
--to=apw@shadowen.org \
--cc=Brice.Goglin@ens-lyon.org \
--cc=akpm@osdl.org \
--cc=hmacht@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome