From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Chen Ni <nichen@iscas.ac.cn>, <neil.armstrong@linaro.org>,
<sam@ravnborg.org>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
<daniel@ffwll.ch>, <sre@kernel.org>,
<michael.riesch@wolfvision.net>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/panel: sitronix-st7789v: Add check for of_drm_get_panel_orientation
Date: Tue, 28 May 2024 09:39:29 -0700 [thread overview]
Message-ID: <fe7a27b4-c245-4a02-a0c6-8f8603146938@quicinc.com> (raw)
In-Reply-To: <20240528030832.2529471-1-nichen@iscas.ac.cn>
On 5/27/2024 8:08 PM, Chen Ni wrote:
> Add check for the return value of of_drm_get_panel_orientation() and
> return the error if it fails in order to catch the error.
>
> Fixes: b27c0f6d208d ("drm/panel: sitronix-st7789v: add panel orientation support")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Hi Chen Ni,
Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Thanks,
Jessica Zhang
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index 88e80fe98112..8b15e225bf37 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -643,7 +643,9 @@ static int st7789v_probe(struct spi_device *spi)
> if (ret)
> return dev_err_probe(dev, ret, "Failed to get backlight\n");
>
> - of_drm_get_panel_orientation(spi->dev.of_node, &ctx->orientation);
> + ret = of_drm_get_panel_orientation(spi->dev.of_node, &ctx->orientation);
> + if (ret)
> + return dev_err_probe(&spi->dev, ret, "Failed to get orientation\n");
>
> drm_panel_add(&ctx->panel);
>
> --
> 2.25.1
>
prev parent reply other threads:[~2024-05-28 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 3:08 Chen Ni
2024-05-28 8:50 ` Michael Riesch
2024-05-28 16:39 ` Jessica Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7a27b4-c245-4a02-a0c6-8f8603146938@quicinc.com \
--to=quic_jesszhan@quicinc.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michael.riesch@wolfvision.net \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nichen@iscas.ac.cn \
--cc=sam@ravnborg.org \
--cc=sre@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®