From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933165AbdCKS5Z (ORCPT ); Sat, 11 Mar 2017 13:57:25 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:37239 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754943AbdCKS5R (ORCPT ); Sat, 11 Mar 2017 13:57:17 -0500 Subject: Re: [PATCH v1 10/10] staging: iio: gyro: Remove exceptional & on function name To: simran singhal , lars@metafoo.de References: <1489242404-12352-1-git-send-email-singhalsimran0@gmail.com> <1489242404-12352-11-git-send-email-singhalsimran0@gmail.com> <563954e3-76f4-d563-1328-3525d15ffdff@kernel.org> Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com From: Jonathan Cameron Message-ID: Date: Sat, 11 Mar 2017 18:57:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <563954e3-76f4-d563-1328-3525d15ffdff@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/17 18:48, Jonathan Cameron wrote: > On 11/03/17 14:26, simran singhal wrote: >> Remove & from function pointers to conform to the style found elsewhere >> in the file. Done using the following semantic patch >> >> // >> @r@ >> identifier f; >> @@ >> >> f(...) { ... } >> @@ >> identifier r.f; >> @@ >> >> - &f >> + f >> // >> >> Signed-off-by: simran singhal > Again, I couldn't identify any other function pointers in this file > so have amended the patch description to reflect that. > > I also added a note that will hopefully prevent anyone seeing > this patch deciding to send me the several hundred patches it > 'might' - I haven't checked - take to clean up the whole subsystem. > > Thanks for the whole series. > > Applied to the togreg branhc of iio.git and pushed out as testing. I spoke to soon. Something odd going on with kernel.org wrt to my connection to it at least. Will try to push out again later. Jonathan > > Jonathan >> --- >> drivers/staging/iio/gyro/adis16060_core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c >> index ab816a2..c9d46e7 100644 >> --- a/drivers/staging/iio/gyro/adis16060_core.c >> +++ b/drivers/staging/iio/gyro/adis16060_core.c >> @@ -117,7 +117,7 @@ static int adis16060_read_raw(struct iio_dev *indio_dev, >> } >> >> static const struct iio_info adis16060_info = { >> - .read_raw = &adis16060_read_raw, >> + .read_raw = adis16060_read_raw, >> .driver_module = THIS_MODULE, >> }; >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >