From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B6A5385D63 for ; Mon, 13 Jul 2026 11:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783941290; cv=none; b=uPXQqex7O5rXjm4ag6FYZPZKbSPjtYLDTQZ1YvJGIbefCL8nTqF4SZxIhuwuxVOvl7J6hPyDo2cE3S/K7cAgfC8RvrgDL7um3k6IsRKLK3isyraVNw7hBoamUa1PxTviKKO7GNXmvtYY758xfHt/C6yHLjoMSKDAAlDKZ15xXfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783941290; c=relaxed/simple; bh=zAetDQromy2N8RZpHM74SaWCREepLFBCH0p5HhPOOoc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=otpgFUyHvJ+1bn7hRGI6iXruVxZwJIjZisbwcqa4lH2Bek7XMAWDzSzLeFZXt7mVqxS5AAmKFqP9Ln2nruSymrVLZRyT+8AqydC5eOuNLYVCUYWwSICuiN7BwObvl+RooRjuxWqmtldNaHjHhIe86YUA9CsO7SrPAls5AhKE1n4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FtySJ19h; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FtySJ19h" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c9c26a5fb98so1779533a12.0 for ; Mon, 13 Jul 2026 04:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783941289; x=1784546089; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Qy05wQX9tQW4cKDrF9CYFi6hXbTRcwSo4hY7x3uhFf0=; b=FtySJ19hZBI4tdywwYcBsPGpfz42JiVbkyBy+NR+1n7oqF7m+Y2Lt0KepaaXjLa2oX rePVoB7fqJjPFiXfq1kbi39ELlEpOXmjk1E8E0sMGk+6eThEwxnFNLl+XczNX8gsDwTh LT21FaGS+HfUuQ/MSLk6OoZnirWwgULqiee/LVE65T7OQJSEsYD+JPh/pZueL8Dvl6Bq GqzPr+9afm0t9DUyLp2xm9RYnFLj6NpMfOsnPzwePReehcHfsTY+XBAQjIOQw7053+l1 8QXJkLXSHFQm+T8fRnnpg3w0tA0BNx4M1nTJxSRGBVfsWaIy0gjnjvqq7l3wrFZoKLpq 9aYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783941289; x=1784546089; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Qy05wQX9tQW4cKDrF9CYFi6hXbTRcwSo4hY7x3uhFf0=; b=OxnAlLQSbAb6hdzWIqFUwVAHf2qHdsdGC6UXFmV3QmH7MvdAIc/g1lbr3TCyQPfNl2 97p0den6l8TWdRGo6huXnSVokwdCLBTftD9/nItaXZUh8b7e/dUofFfGaMd2UBBRVlWw YQWfFnVibXbhAvovSS8z4mckCwKNVSJCOvxsV6vR7u8IDTWKTe3Ig7IWsq1lXrsx38w3 QHd7hU9boSvUEaMUZ8GzWJBGAY9I9N5bST3rrktTHbzSe3PLSjeQQgtOFEVO4rfj7K8+ 02dzUF6aq0PYkLBzOWC6PbhdhXmXeN0GoRWIQwpcMqay3Ep0f2ZrPisSF1q8guKTbtt+ EU3w== X-Forwarded-Encrypted: i=1; AHgh+Rolt85bsJTGhXjF8T/mnyMS+lR9x7HNcAdOgXgW7V8IPllJ1/jOgcPjxo7xAtpsh4UfvMxJwirTrkUdXEU=@vger.kernel.org X-Gm-Message-State: AOJu0YxrVd4u/X2e2gXLjUhcCnjk3EU46/q15nosAKkP+Dt+I2Sy91nO 4zg1nQnc0mksZ8xsnxqqTmTBwN1dF1972ahp1dF3c/a409gjDXAtVthk X-Gm-Gg: AfdE7cmRCeHNLe+4lanPHLAmgWc5mNVn6etNLrJpVCMkEmBMK6nEiNZiVmH/8A67Xwa Lf6y5ljtv2CUsddGpi+cXUckeilg//zLuGprT8TqDq4mpAIj5uVFP1cBD8mkJwuMOufFlsWnVFI H0kiueFwmEM/QJDe4nxnKr65ColEuJnniO6VKzoZ36UwPeE0oScHdV5CrRjcKrtIdGfhl1RMp9n agNOhiJhmbY2HIqwDtHN+iCBg2zWNAg6GCpreDUSqSFxDmIbBZqzJU91FHghq30Jik8qThi3q7L M3poQn8rZrOfsmQ9DvDJSGQ22hyN5q/NMD7LFGGF/TWX04K1MzzWV+aHc6SRe7CHME88eNDjfTn VVnU5FY6fzg19FJ2bUrGvoRkDQaFFla3d7zjNprKQMvSU4qe4rGh1wA1O4gaQyyXcP+doertihP Z7/H2tHh0FBfOi43tz/OCR9FXGrG/z8fXldVgWixqI3qP1kUEVjxCzciekbGHNSB86xmk= X-Received: by 2002:a05:6a20:cf85:b0:3c0:b598:4983 with SMTP id adf61e73a8af0-3c0f0bc744dmr14145797637.30.1783941288539; Mon, 13 Jul 2026 04:14:48 -0700 (PDT) Received: from [192.168.68.63] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b87b92b27sm27749509c88.6.2026.07.13.04.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 04:14:48 -0700 (PDT) Message-ID: Date: Mon, 13 Jul 2026 04:14:47 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: opp: Allow optional -vN suffix in opp-microvolt property name To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Ilia Lin , Viresh Kumar , Nishanth Menon , Stephen Boyd , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20260527-expressatt_cpufreq-v2-0-b9b7726ccb6d@gmail.com> <20260527-expressatt_cpufreq-v2-1-b9b7726ccb6d@gmail.com> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/27/26 23:35, Dmitry Baryshkov wrote: > On Wed, May 27, 2026 at 08:39:28PM -0700, Rudraksha Gupta wrote: >> The qcom-cpufreq-nvmem driver generates prop_name as >> "speed%d-pvs%d-v%d" for Krait SoCs, resulting in property names like >> opp-microvolt-speed0-pvs0-v0. The existing schema regex only allows >> opp-microvolt-speed[0-9]+-pvs[0-9]+ without the trailing version >> suffix. >> >> Extend the regex to optionally match a -v[0-9]+ suffix so that >> devicetrees using the full prop_name pass schema validation. >> >> Assisted-by: Claude:claude-opus-4.6 >> Signed-off-by: Rudraksha Gupta >> --- >> Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml >> index fd04d060c1de..846f49a99484 100644 >> --- a/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml >> +++ b/Documentation/devicetree/bindings/opp/opp-v2-kryo-cpu.yaml >> @@ -81,7 +81,7 @@ patternProperties: >> required-opps: true >> >> patternProperties: >> - '^opp-microvolt-speed[0-9]+-pvs[0-9]+$': true >> + '^opp-microvolt-speed[0-9]+-pvs[0-9]+(-v[0-9]+)?$': true > I think this should be fixed differently. There is no version for > MSM8960 / APQ8064, per design. It is only applicable to MSM8974 / > APQ8084. You also need to scale the core voltages. Would you consider > picking up the relevant parts of [1]? (also see [2] and [3])? > > I got stuck because I couldn't implement L2 plumbing properly and never > pushed the series further. On both MSM8960 and APQ8064 we can scale L2 > cache to follow the CPU frequency. I tried adding the driver for it, but > RobH requested using cpu_subsys, but there each cache device gets > created multiple times. Maybe I should fix that in the end, then we can > scale the L2 too. > > [1] https://lore.kernel.org/linux-arm-msm/20231002185940.1271800-1-dmitry.baryshkov@linaro.org/ > > [2] https://lore.kernel.org/linux-arm-msm/20230827115033.935089-1-dmitry.baryshkov@linaro.org/ > > [3] https://lore.kernel.org/linux-arm-msm/20230702175045.122041-1-dmitry.baryshkov@linaro.org/ Hi Dmitry, Sorry for responding back so late. I'm not too sure I follow what is required for the CPU frequency patch, but I can attempt it using AI. Would you have more information and any specific patches from the patch series that I should take a look at? I'm also considering putting CPU frequency in the backlog. Currently Antony has Wi-Fi/bluetooth working (Which is depending on https://lore.kernel.org/all/20260527-expressatt_camera_flash-v6-0-de0f150024e4@gmail.com. Waiting for Lee Jones's review and I will send my Wi-Fi/bluetooth enablement patch afterwards) and I've also separately gotten display fully working and cameras partially working. Currently I'm trying to get audio working and recently I was able to hear a click and pop. However, I seem to be struggling to get Q6/hexagon working. This seems to be required for the modem as well so directly controlling audio seems to be a temporary solution. Would you have any tips? My source code repo is here: https://codeberg.org/LogicalErzor/linux/src/branch/expressatt I feel these subsystems will be more important getting in compared to CPU frequency. Unless I'm misjudging CPU frequency work and it's simpler than expected. Thanks, Rudraksha