From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 902CE3B4E8B; Thu, 18 Jun 2026 08:39:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781771959; cv=none; b=s0M6LuP0JnHH4kF8M8aYufq90D5oUq+HdfTMD+qGAJo3wO6Zo4M3P2WXFQPBXTCy8zJ8rqsWrlryQLvPvuiquImGFnw6bazHos9liP60yCL7WHzLKct5pYJzGHDaptVtjlvqz1HHXEHfIZ8XNsjG/CeHfTMPm3qJuRROi1wRczc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781771959; c=relaxed/simple; bh=00Sh3h7guBWY5L2puvf4zlaEaH/SsYgyBTF6Tbvqf10=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UuZZqrbNPi2kAfr9a/M8EIKkQD8jCaVSKEkTZNnMJ2dA4op6hYAx5AvTBUpBL/Kaf8WcB8fg0meLxn1declv9qTh6Cbl/uucaMc9WwOcuXthE0+oW/yh2XGSIUQVZ75l9fBHaqM4fewwpTumKx7HaXQamJvIw7HlntGW5ZLc4+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=hzcvqf7G; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="hzcvqf7G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1781771955; bh=00Sh3h7guBWY5L2puvf4zlaEaH/SsYgyBTF6Tbvqf10=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hzcvqf7GuKHpdHlXk2wp0uWxEnywUQE5XOLR4Qi5aLbyJU5+IpgYUYwTwNWqBRnr4 lXDy+UR9gQb4JO5rI0JuckPmTPgC1ZhGImgZ1BrEZLq3BFNWOb8rH9LHUh6fYqSOWA AoTCuEB3aW8WJfm/O0fJdxn+24bVVqy3Mw+0ibEcrP5btrCOCYrjst8zWINPzouYsk uld2UHSmgRmuGyblJP51TUv784fFUvdhTDnK4GNVyg3VkGSiPRJIFTmyvH7xZkD+om 4xXsiDMLuZ/SjppHamWcOXOFAXxvU9jbGJfMDjPDCFqFKocc8pSQLhZQNAXlREwnj4 mAsGjpwQx0m8w== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id AC13917E05DE; Thu, 18 Jun 2026 10:39:14 +0200 (CEST) Message-ID: Date: Thu, 18 Jun 2026 11:39:14 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/9] dt-bindings: display: vop2: Add missing reset properties To: Diederik de Haas , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli Cc: kernel@collabora.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260617-dw-hdmi-qp-yuv-v1-0-a665cfd06d7d@collabora.com> <20260617-dw-hdmi-qp-yuv-v1-1-a665cfd06d7d@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Diederik, On 6/18/26 10:58 AM, Diederik de Haas wrote: > Hi Cristian, > > Thanks for this series :-) Just 1 nit (at the end) ... > > On Wed Jun 17, 2026 at 8:52 PM CEST, Cristian Ciocaltea wrote: >> Document the VOP2 resets corresponding to the AXI, AHB and DCLK_VP0..2 >> clocks, which are common to all supported SoCs, plus DCLK_VP3 which is >> provided only on RK3588. >> >> Signed-off-by: Cristian Ciocaltea >> --- >> .../bindings/display/rockchip/rockchip-vop2.yaml | 42 ++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> index 93da1fb9adc4..d3bc5380f910 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml [...] >> @@ -289,6 +321,16 @@ examples: >> "dclk_vp0", >> "dclk_vp1", >> "dclk_vp2"; >> + resets = <&cru SRST_A_VOP>, >> + <&cru SRST_H_VOP>, >> + <&cru SRST_VOP0>, >> + <&cru SRST_VOP1>, >> + <&cru SRST_VOP2>; >> + reset-names = "axi", >> + "ahb", >> + "dclk_vp0", >> + "dclk_vp1", >> + "dclk_vp2"; >> power-domains = <&power RK3568_PD_VO>; > > Place reset* props below power-domains (like in patch 9) ? > So everyone who copies your example has the correct sorting order. The example doesn't strictly follow that ordering either — see e.g. the iommus property — so I placed the resets right after the clocks, which keeps the related properties grouped together. That said, I don't have a strong preference. Heiko, is there a convention you'd like the Rockchip bindings to follow here? Happy to reorder if so. Regards, Cristian > > Cheers, > Diederik > >> rockchip,grf = <&grf>; >> iommus = <&vop_mmu>; >