From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23CA4C7EE2F for ; Tue, 30 May 2023 15:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbjE3Pa4 (ORCPT ); Tue, 30 May 2023 11:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbjE3Pax (ORCPT ); Tue, 30 May 2023 11:30:53 -0400 Received: from mail.tuxedocomputers.com (mail.tuxedocomputers.com [157.90.84.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93794C7; Tue, 30 May 2023 08:30:51 -0700 (PDT) Received: from [192.168.178.25] (host-212-18-30-247.customer.m-online.net [212.18.30.247]) (Authenticated sender: wse@tuxedocomputers.com) by mail.tuxedocomputers.com (Postfix) with ESMTPSA id 877E82FC0073; Tue, 30 May 2023 17:30:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxedocomputers.com; s=default; t=1685460649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NAekkNJ91ucrLIslysTWlQCuNuST6srDBKEWW2bK6Mo=; b=qEZDK44NVdqpg1+rzrDXlcwupOzeJedAwpZi32dVcZJ5L59k3L3Y6S/zSjvarosO+wFE6X vETY2DoX/0G447KKZvmfO//RCgDCceb6LPWHp+p3KX18hgTsGUr5DENv8/Bh+h0Yk2Y/Gy mYNDl5uPl5OALX7rYL4hxcfgU35xotw= Authentication-Results: mail.tuxedocomputers.com; auth=pass smtp.auth=wse@tuxedocomputers.com smtp.mailfrom=wse@tuxedocomputers.com Message-ID: Date: Tue, 30 May 2023 17:30:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] input: Add new keyboard backlight control keys to match modern notebooks Content-Language: en-US To: Dmitry Torokhov , Bastien Nocera Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230530110550.18289-1-wse@tuxedocomputers.com> From: Werner Sembach In-Reply-To: <20230530110550.18289-1-wse@tuxedocomputers.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 30.05.23 um 13:05 schrieb Werner Sembach: > The old three KEY_KBDILLUM* keycodes don't reflect the current situation > modern notebooks anymore. Especially the ones with RGB keyboards. > > e.g. > - Clevo NL50NU has a toggle, an up, a down and a color-cycle key > - TongFang PH4ARX1 doesn't have a toggle key, but one that cycles through > off, half-brightness, and full-brightness. > > Also, on some devices these keys are already implemented in firmware. It > would still be nice if there is a way to let userspace know when one of > these keys is pressed to display the OSD, but don't advice it to actually > do anything. This is the intended purpose of the KEY_KBDILLUMCHANGE define. Nevermind the KEY_KBDILLUMCHANGE. I just found out there is already a way to communicate this from kernel to userspace via sysfs https://docs.kernel.org/leds/leds-class.html#led-registration-api -> brightness_hw_changed > > Signed-off-by: Werner Sembach > --- > include/uapi/linux/input-event-codes.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h > index 022a520e31fc2..05287bf9a77f7 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -803,6 +803,10 @@ > #define BTN_TRIGGER_HAPPY39 0x2e6 > #define BTN_TRIGGER_HAPPY40 0x2e7 > > +#define KEY_KBDILLUMCYCLE 0x2e8 > +#define KEY_KBDILLUMCOLORCYCLE 0x2e9 > +#define KEY_KBDILLUMCHANGE 0x2ea > + > /* We avoid low common keys in module aliases so they don't get huge. */ > #define KEY_MIN_INTERESTING KEY_MUTE > #define KEY_MAX 0x2ff