From: Dave Jiang <dave.jiang@intel.com>
To: Shen Lichuan <shenlichuan@vivo.com>,
dan.j.williams@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, pankaj.gupta.linux@gmail.com
Cc: nvdimm@lists.linux.dev, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] nvdimm: Correct some typos in comments
Date: Thu, 26 Sep 2024 08:15:16 -0700 [thread overview]
Message-ID: <fe8bc21c-b684-4a51-a1c4-2b58412a38d1@intel.com> (raw)
In-Reply-To: <20240926075700.10122-1-shenlichuan@vivo.com>
On 9/26/24 12:57 AM, Shen Lichuan wrote:
> Fixed some confusing typos that were currently identified with codespell,
> the details are as follows:
>
> -in the code comments:
> drivers/nvdimm/nd_virtio.c:100: repsonse ==> response
> drivers/nvdimm/pfn_devs.c:542: namepace ==> namespace
> drivers/nvdimm/pmem.c:319: reenable ==> re-enable
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/nvdimm/nd_virtio.c | 2 +-
> drivers/nvdimm/pfn_devs.c | 2 +-
> drivers/nvdimm/pmem.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
> index f55d60922b87..c3f07be4aa22 100644
> --- a/drivers/nvdimm/nd_virtio.c
> +++ b/drivers/nvdimm/nd_virtio.c
> @@ -97,7 +97,7 @@ static int virtio_pmem_flush(struct nd_region *nd_region)
> dev_info(&vdev->dev, "failed to send command to virtio pmem device\n");
> err = -EIO;
> } else {
> - /* A host repsonse results in "host_ack" getting called */
> + /* A host response results in "host_ack" getting called */
> wait_event(req_data->host_acked, req_data->done);
> err = le32_to_cpu(req_data->resp.ret);
> }
> diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c
> index 586348125b61..cfdfe0eaa512 100644
> --- a/drivers/nvdimm/pfn_devs.c
> +++ b/drivers/nvdimm/pfn_devs.c
> @@ -539,7 +539,7 @@ int nd_pfn_validate(struct nd_pfn *nd_pfn, const char *sig)
>
> if (!nd_pfn->uuid) {
> /*
> - * When probing a namepace via nd_pfn_probe() the uuid
> + * When probing a namespace via nd_pfn_probe() the uuid
> * is NULL (see: nd_pfn_devinit()) we init settings from
> * pfn_sb
> */
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 210fb77f51ba..d81faa9d89c9 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -316,7 +316,7 @@ static long pmem_dax_direct_access(struct dax_device *dax_dev,
> * range, filesystem turns the normal pwrite to a dax_recovery_write.
> *
> * The recovery write consists of clearing media poison, clearing page
> - * HWPoison bit, reenable page-wide read-write permission, flush the
> + * HWPoison bit, re-enable page-wide read-write permission, flush the
> * caches and finally write. A competing pread thread will be held
> * off during the recovery process since data read back might not be
> * valid, and this is achieved by clearing the badblock records after
next prev parent reply other threads:[~2024-09-26 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 7:57 Shen Lichuan
2024-09-26 15:15 ` Dave Jiang [this message]
2024-10-01 7:41 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe8bc21c-b684-4a51-a1c4-2b58412a38d1@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=opensource.kernel@vivo.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=shenlichuan@vivo.com \
--cc=virtualization@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®