From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD41DC3A5A7 for ; Wed, 4 Sep 2019 09:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA69C2339D for ; Wed, 4 Sep 2019 09:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729481AbfIDJLk (ORCPT ); Wed, 4 Sep 2019 05:11:40 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37264 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727348AbfIDJLj (ORCPT ); Wed, 4 Sep 2019 05:11:39 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x849BHpD007615 for ; Wed, 4 Sep 2019 05:11:38 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ut80s4va1-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 04 Sep 2019 05:11:34 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Sep 2019 10:10:58 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 4 Sep 2019 10:10:54 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x849Arww59637980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Sep 2019 09:10:53 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 36FBA4204C; Wed, 4 Sep 2019 09:10:53 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5CC0F4204B; Wed, 4 Sep 2019 09:10:50 +0000 (GMT) Received: from [9.199.58.251] (unknown [9.199.58.251]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 4 Sep 2019 09:10:50 +0000 (GMT) Subject: Re: [PATCH v3 3/3] Powerpc64/Watchpoint: Rewrite ptrace-hwbreak.c selftest To: Christophe Leroy , mpe@ellerman.id.au, mikey@neuling.org Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, naveen.n.rao@linux.vnet.ibm.com, ravi.bangoria@linux.ibm.com References: <20190710045445.31037-1-ravi.bangoria@linux.ibm.com> <20190710045445.31037-4-ravi.bangoria@linux.ibm.com> From: Ravi Bangoria Date: Wed, 4 Sep 2019 14:40:49 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19090409-0012-0000-0000-000003468330 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19090409-0013-0000-0000-00002180D470 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-09-04_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909040093 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/19 11:44 AM, Christophe Leroy wrote: > > > Le 10/07/2019 à 06:54, Ravi Bangoria a écrit : >> ptrace-hwbreak.c selftest is logically broken. On powerpc, when >> watchpoint is created with ptrace, signals are generated before >> executing the instruction and user has to manually singlestep >> the instruction with watchpoint disabled, which selftest never >> does and thus it keeps on getting the signal at the same >> instruction. If we fix it, selftest fails because the logical >> connection between tracer(parent) and tracee(child) is also >> broken. Rewrite the selftest and add new tests for unaligned >> access. > > On the 8xx, signals are generated after executing the instruction. > > Can we make the test work in both case ? Sure. I don't mind. I guess, it should be trivial to do that. But I'm still waiting for Mikey / Mpe's replay on actual patches. Mikey, mpe, is it ok to not ignore actual events but generate false positive events? Is there any other better approach? Ravi