mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>,
	Carlos O'Donell <carlos@redhat.com>,
	Florian Weimer <fweimer@redhat.com>,
	Michael Jeanson <mjeanson@efficios.com>
Subject: Re: [PATCH v1 2/2] rseq: slice ext: Ensure rseq feature size differs from original rseq size
Date: Wed, 18 Feb 2026 14:01:17 -0500	[thread overview]
Message-ID: <fe964e91-7364-458f-bce6-df52933bbfcf@efficios.com> (raw)
In-Reply-To: <20260218165214.1164084-3-mathieu.desnoyers@efficios.com>

On 2026-02-18 11:52, Mathieu Desnoyers wrote:
[...]
> 
> The effect of this change is to increase the size and alignment of
> the rseq area from 32 to 64 bytes before we actually have fields using
> that memory.
> 
[...]
> -} __attribute__((aligned(4 * sizeof(__u64))));
> +} __attribute__((aligned(8 * sizeof(__u64))));

Actually bumping the alignment from 32 to 64 is not correct here,
because the kernel still has to deal with legacy userspace which
align struct rseq on 32 bytes only.

What I can do instead is change the value returned by
getauxval(AT_RSEQ_ALIGN) from 32 to 64, thus requesting
that newer userspace align its allocation on 64-byte.

I'll prepare an updated patch series.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

      reply	other threads:[~2026-02-18 19:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 16:52 [PATCH v1 0/2] Last minute rseq fixes for 7.0 Mathieu Desnoyers
2026-02-18 16:52 ` [PATCH v1 1/2] rseq: Clarify rseq registration rseq_size bound check comment Mathieu Desnoyers
2026-02-18 16:52 ` [PATCH v1 2/2] rseq: slice ext: Ensure rseq feature size differs from original rseq size Mathieu Desnoyers
2026-02-18 19:01   ` Mathieu Desnoyers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe964e91-7364-458f-bce6-df52933bbfcf@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mjeanson@efficios.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome