mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arun Raghavan" <arun@arunraghavan.net>
To: "Fabio Estevam" <festevam@gmail.com>
Cc: "Shengjiu Wang" <shengjiu.wang@gmail.com>,
	"Xiubo Li" <Xiubo.Lee@gmail.com>,
	"Nicolin Chen" <nicoleotsuka@gmail.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Pieterjan Camerlynck" <p.camerlynck@televic.com>,
	linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	"Arun Raghavan" <arun@asymptotic.io>
Subject: Re: [PATCH v3] ASoC: fsl_sai: Force a software reset when starting in consumer mode
Date: Thu, 26 Jun 2025 08:27:58 -0400	[thread overview]
Message-ID: <fe9956b2-4d71-4a57-ab70-6ff64c4525cf@app.fastmail.com> (raw)
In-Reply-To: <CAOMZO5BgsU0ijdoaZs5e=qwb2PYZsEnx_RxfgQ+dosL8hPRKyA@mail.gmail.com>

On Thu, 26 Jun 2025, at 7:58 AM, Fabio Estevam wrote:
> Hi Arun,
>
> On Thu, Jun 26, 2025 at 8:52 AM Arun Raghavan
> <arun@arunraghavan.net> wrote:
>>
>> From: Arun Raghavan <arun@asymptotic.io>
>>
>> On an imx8mm platform with an external clock provider, when running
>> the receiver (arecord) and triggering an xrun with xrun_injection, we
>> see a channel swap/offset. This happens sometimes when running only
>> the receiver, but occurs reliably if a transmitter (aplay) is also
>> concurrently running.
>>
>> It seems that the SAI loses track of frame sync during the trigger
>> stop -> trigger start cycle that occurs during an xrun. Doing just a
>> FIFO reset in this case does not suffice, and only a software reset
>> seems to get it back on track.
>>
>> This looks like the same h/w bug that is already handled for the
>> producer case, so we now do the reset unconditionally on config
>> disable.
>>
>> Signed-off-by: Arun Raghavan <arun@asymptotic.io> Reported-by:
>> Pieterjan Camerlynck <p.camerlynck@televic.com>
>
> What about adding a Fixes tag and Cc stable so that it gets backported
> to the stable trees?

Sure! Will send in a v4 with both of these.

The commit that added the initial fix (3e3f8bd56955 ("ASoC: fsl_sai: fix
no frame clk in master mode")) refers to an errata, but I could find
anything in a couple of imx8* errata I checked.

I was wondering if there's any public documentation of this that I can
refer (and link) to?

Cheers,
Arun

  reply	other threads:[~2025-06-26 12:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-26 11:52 Arun Raghavan
2025-06-26 11:58 ` Fabio Estevam
2025-06-26 12:27   ` Arun Raghavan [this message]
2025-06-26 12:51     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe9956b2-4d71-4a57-ab70-6ff64c4525cf@app.fastmail.com \
    --to=arun@arunraghavan.net \
    --cc=Xiubo.Lee@gmail.com \
    --cc=arun@asymptotic.io \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=p.camerlynck@televic.com \
    --cc=perex@perex.cz \
    --cc=shengjiu.wang@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®