From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B1F27FD59 for ; Sun, 1 Feb 2026 18:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769971513; cv=none; b=ROW2ARqkTccWMSIhrz4fz0w6OqT+Mc7c0W1V2PkWDYsX1r7bQCugoS/p33iYNLFCmOOVgudw7oofwodySxi/GBwO8ZYUBzvpoAI0Tubqb2pNo1VyJlYxJN+wJTpO2yV8uE/jdSYeurIMK2OYHimmnHzoHTAGVsJ0I+1dt2AEVaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769971513; c=relaxed/simple; bh=LQgQQD9AmuPzorHnhKvFOzsRBup414VCck4EdvcVNLQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SUJAcpgYKZUhWd6HyL4A/9F7cC0UdsceIlwnws8ScBOEo57yKNn2bUjIctj0cYo1LZmIJE3qIedx8UYeenWkeo5Evp6lp6a12wSHcVSCBg/I7TGdq1ovSIPjMbbaXNNlWmGbZIxOk4ntDEWbNhTHQoEWTfUZCkbfvv3JLa+EbvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=2AL3TAQ3; arc=none smtp.client-ip=209.85.210.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="2AL3TAQ3" Received: by mail-ot1-f67.google.com with SMTP id 46e09a7af769-7cfd8ca8191so1462509a34.3 for ; Sun, 01 Feb 2026 10:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769971509; x=1770576309; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Akl38qoflsvYXDrfSQS4UdKQ+8WjmfeZhRt65gKmSWg=; b=2AL3TAQ36k8/kME8b7gM6J0TI3/G9vFX5oPb6PJBT9JRSyY/Q8tplyzhCchG2AcCGX UiuRIameoV5ChfR4wMML1uF/xrr20bTweofEmoh6vXOurUsqyzQXOfHDhMO8dzFTAqE6 d9XlFg2ySdpiiCEJnyQGrch2rBGIej32os8hwVbmdc+EdWsU9gUMrb/qB9fcOwoqTgTn lbJYGrCmB/bhY8/4aBSEA5ByRb0fY+OVXAD6AgEtxIp68zddTsbzTHHqm7kCHWsS+sH6 A3wtfU+L0AhMjYQoo7kFdi2gt6C7oMJey9xJkEFAUnO6121QlbRQ5i26S3Lc526gO6y0 sALw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769971509; x=1770576309; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Akl38qoflsvYXDrfSQS4UdKQ+8WjmfeZhRt65gKmSWg=; b=K7/p2EXqkB3fqce7rFz0gTvaNP3DZOeaWyrG4fWXkUHQmA19dFFoc7GgExjV5Hdn+Q oI9WmtupJ6SslPQ2CME9BgG5dOPVRpGjelN0r2qW+XvVahhTDywiAjEjtzi+lIeD48GT QsG1N3NpDMG/ttH0DUWZSLcX1HJwUbiFn+nXWucg2KFrrH57a0AQlTDceK9eM9hQYyjz oUTCEkPj1OpjVo3qB1jOQiy80zGXJS5AIdUMZ3tfOW9CGNyPF6ZVh0omHWozYZj9w8u3 MDAsdOlMhtJ1mDikEXDAjWavumEm7sj8ruKIx6FgW/vvd2fyA/SCWz4UjDpK2EWySGgH hk5g== X-Forwarded-Encrypted: i=1; AJvYcCW1iJW0bHh2Wj73C9Rj8etdQeEoc72Iulb1Wk8wDvi7SycRTdVnDTRwvAZWIdhCqmV0x72vGf07yuddxIk=@vger.kernel.org X-Gm-Message-State: AOJu0YxDbkYPHDOM4X9UTOgZ5S1CPkL0LozTBLt99J10x05uhpFuXSsA aS8xRrK4lfNzPqHPs3Nhnc2ZnOHmPdB7oK6V1fGcFa8pvtHVgPbi31mhDQDR1rBHP9bvMXnlo7o a/G3L5YQ= X-Gm-Gg: AZuq6aI9Bg213ifMvjByJP4pmspvey6IIfdkUP6aVgUwBCY1BqwUfXdBVxBdCZ/EYNd NoxD2hOxhwbQPrYan6frMS8FUapidEcIrGdMA2Gdo2fET3vuq4Bzdte28t90YUuwg0w+6bNxYBt BIxQuw6JONMRBTD6avggnns6Jk/8k2VtLHvDgeSJPAj4W/Pj+VzOcl6LR9uMgl3GjE4qfJWGOGj vugnzgXnQu4jAiS/H7lQ+g3kirImeDvFfxi1Ot7J3HoFfS/aeWbzPQgcCsMbP9w7raaitvFIBds 7eZbfV/85e1GMCi2SqluiZUTNoCHGDTM8VWpHbNU6oHkx3igVdR+ZnJFK1cZhlKkF44RSWF7PWQ U1z398M+wfNxlYv2Rumm11i1zWufkCehwf7eHsMn08JZps+IHLy0UfGQ3G4WdkukvVZ4aVjb/ME IHqiyGo1hK+gSKnuvQjE/pSYzjMRjfAQFc4aiNl1v+GvIJPi1fSDjHRQG07Blt X-Received: by 2002:a05:6830:650b:b0:7c7:5458:75f8 with SMTP id 46e09a7af769-7d1a53284e5mr4480816a34.29.1769971509098; Sun, 01 Feb 2026 10:45:09 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:66ee:10f7:4858:7df6? ([2600:8803:e7e4:500:66ee:10f7:4858:7df6]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d18c67065esm9327775a34.6.2026.02.01.10.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Feb 2026 10:45:08 -0800 (PST) Message-ID: Date: Sun, 1 Feb 2026 12:45:07 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: Add binding document for cm36686 To: Erikas Bitovtas , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Tsai Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260201-cm36686-v1-0-4949a2a9ba63@gmail.com> <20260201-cm36686-v1-1-4949a2a9ba63@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260201-cm36686-v1-1-4949a2a9ba63@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/1/26 11:03 AM, Erikas Bitovtas wrote: > Document the Capella cm36686 ambient light and proximity sensor devicetree > bindings. > > Signed-off-by: Erikas Bitovtas > --- > .../bindings/iio/light/capella,cm36686.yaml | 74 ++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml b/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml > new file mode 100644 > index 000000000000..5f0a585e3d87 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/capella,cm36686.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/capella,cm36686.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Capella cm36686 I2C Ambient Light and Proximity sensor > + > +maintainers: > + - Erikas Bitovtas > + > +properties: > + compatible: > + enum: > + - capella,cm36686 > + - capella,cm36672p The cover letter mentioned that one is fully compatible with the other, so we should have a fallback here. compatible: oneOf: - const: capella,cm36672p - items: -const: capella,cm36686 - const: capella,cm36672p > + > + reg: > + maxItems: 1 > + description: > + I2C slave address of the device. Must be 0x60 for both cm36686 > + and cm36672p sensors. > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: > + description: > + Regulator that provides power to the sensor. > + > + vddio-supply: > + description: > + Regulator used to power IO and I2C bus. > + > + vled-supply: > + description: > + Regulator used to power proximity LED > + > + proximity-near-level: true > + > + capella,proximity-led-current: Should use the standard -microamp suffix [1]. [1]: https://github.com/devicetree-org/dt-schema/blob/d16dc68b093e59ec4ae6a32a2e1179cb9cc0fada/dtschema/schemas/property-units.yaml#L86C4-L86C13 > + description: > + Current for proximity IR LED (in uA) > + $ref: /schemas/types.yaml#/definitions/uint32 Then we don't need the $ref. > + enum: [50, 75, 100, 120, 140, 160, 180, 200] Should have a default: value since this isn't a required property. > + > +additionalProperties: false > + > +required: > + - compatible > + - reg Power supplies should be required. > + > +examples: > + - | > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@60 { > + compatible = "capella,cm36686"; > + reg = <0x60>; > + > + vdd-supply = <&pm8916_l8>; > + vddio-supply = <&pm8916_l6>; > + vled-supply = <®_prox_vled>; > + > + interrupts-extended = <&tlmm 113 IRQ_TYPE_EDGE_FALLING>; > + > + proximity-near-level = <30>; > + capella,proximity-led-current = <100>; > + }; > + }; >