From: Andrew Lunn <andrew@lunn.ch>
To: "Lucien.Jheng" <lucienzx159@gmail.com>
Cc: linux-clk@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, daniel@makrotopia.org,
ericwouds@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, joseph.lin@airoha.com,
wenshin.chung@airoha.com, lucien.jheng@airoha.com,
albert-al.lee@airoha.com
Subject: Re: [PATCH v1 net-next PATCH 1/1] net: phy: air_en8811h: Introduce resume/suspend and clk_restore_context to ensure correct CKO settings after network interface reinitialization.
Date: Sun, 29 Jun 2025 20:10:21 +0200 [thread overview]
Message-ID: <fe9a6e67-2790-489b-a5fa-a03ec041f48e@lunn.ch> (raw)
In-Reply-To: <20250629115911.51392-1-lucienzx159@gmail.com>
> +static void en8811h_clk_restore_context(struct clk_hw *hw)
> +{
> + if (!__clk_get_enable_count(hw->clk))
Using a __ functions seems wrong, they are supposed to be internal.
How about clk_ops save_context() and restore_context()?
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2025-06-29 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-29 11:59 Lucien.Jheng
2025-06-29 14:23 ` kernel test robot
2025-06-29 18:10 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe9a6e67-2790-489b-a5fa-a03ec041f48e@lunn.ch \
--to=andrew@lunn.ch \
--cc=albert-al.lee@airoha.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joseph.lin@airoha.com \
--cc=kuba@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lucien.jheng@airoha.com \
--cc=lucienzx159@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wenshin.chung@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®