From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: Hugh Dickins <hugh@veritas.com>
Cc: Zachary Amsden <zach@vmware.com>,
Jan Beulich <jbeulich@novell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386: PAE entries must have their low word cleared first
Date: Wed, 26 Apr 2006 17:12:44 +0100 [thread overview]
Message-ID: <fea09d592b7075d7c7525ba294a15b0f@cl.cam.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0604261652320.12529@blonde.wat.veritas.com>
On 26 Apr 2006, at 16:57, Hugh Dickins wrote:
>> Proposed fix for ptep_get_and_clear_full PAE bug. Pte_clear had the
>> same
>> bug, so use the same fix for both.
>
> You need to expand that comment with text from Jan & Keir's patch:
> Andrew will want to know just what this bug was. The patch looks
> good to me, except for the unnecessary do { } while (0) in the
> definition of pte_clear: ah, you're only copying what was already
> there, can't blame you for that, let's not worry about it.
I agree: the patch comment is rather brief, but the patch itself looks
good. I suppose switching PAE's set_pte() from smp_wmb() to wmb() would
logically belong in a separate patch.
-- Keir
next prev parent reply other threads:[~2006-04-26 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 13:46 Jan Beulich
2006-04-26 14:46 ` Hugh Dickins
2006-04-26 15:06 ` Keir Fraser
2006-04-26 15:44 ` Zachary Amsden
2006-04-26 15:57 ` Hugh Dickins
2006-04-26 16:12 ` Keir Fraser [this message]
2006-04-26 15:45 ` Hugh Dickins
2006-04-26 16:06 ` Nick Piggin
2006-04-26 15:58 ` Nick Piggin
2006-04-27 10:27 ` Sonny Rao
2006-04-27 13:39 ` Nick Piggin
2006-04-26 22:11 Brunner, Richard
2006-04-26 22:22 ` Zachary Amsden
2006-04-26 22:27 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fea09d592b7075d7c7525ba294a15b0f@cl.cam.ac.uk \
--to=keir.fraser@cl.cam.ac.uk \
--cc=hugh@veritas.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®