From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82AC2C43381 for ; Thu, 28 Feb 2019 07:25:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 500A1218E0 for ; Thu, 28 Feb 2019 07:25:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731267AbfB1HZo (ORCPT ); Thu, 28 Feb 2019 02:25:44 -0500 Received: from mga06.intel.com ([134.134.136.31]:6405 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730951AbfB1HZo (ORCPT ); Thu, 28 Feb 2019 02:25:44 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2019 23:20:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,422,1544515200"; d="scan'208";a="127860960" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.56]) ([10.237.72.56]) by fmsmga008.fm.intel.com with ESMTP; 27 Feb 2019 23:20:38 -0800 Subject: Re: [bug report][stable] perf probe: failed to add events To: Joseph Qi , Arnaldo Carvalho de Melo Cc: Alexander Shishkin , Greg KH , "linux-kernel@vger.kernel.org" , luto@kernel.org, Jiufei Xue , Xu Yu , peterz@infradead.org, mingo@redhat.com References: <1a4240a8-288b-45d0-073d-d5cb8f0c63eb@linux.alibaba.com> <20190226090505.GA24409@kroah.com> <20190226130802.GA10343@kroah.com> <20190226142009.GC26786@kernel.org> <3b233ff2-e87a-1c61-d516-6c4cdecb4f01@intel.com> <8e798942-0e71-c88f-866f-88e55177e286@linux.alibaba.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 28 Feb 2019 09:19:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <8e798942-0e71-c88f-866f-88e55177e286@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/02/19 4:07 AM, Joseph Qi wrote: > Hi Adrian, > > On 19/2/27 20:39, Adrian Hunter wrote: >> Seems to be fixed by this: >> >> From: Adrian Hunter >> Date: Wed, 27 Feb 2019 05:35:25 +0200 >> Subject: [PATCH] perf probe: Fix getting the kernel map >> >> Since commit 4d99e4136580 ("perf machine: Workaround missing maps for x86 >> PTI entry trampolines"), perf tools has been creating more than one kernel >> map, however 'perf probe' assumed there could be only one. >> >> Fix by using machine__kernel_map() to get the main kernel map. >> >> Signed-off-by: Adrian Hunter >> Fixes: 4d99e4136580 ("perf machine: Workaround missing maps for x86 PTI entry trampolines") > > Below is my investigation result before, FYI. > the first bad commit (v4.18 ~ v4.19): > d83212d5dd67 kallsyms, x86: Export addresses of PTI entry trampolines Yes we should add a fixes tag for that also. > revert this commit on 4.19.0, it works. > the first good commit again (v4.19 ~ v4.20): > bf904d2762ee x86/pti/64: Remove the SYSCALL64 entry trampoline > backported this commit as well as the related commit 98f05b5138f0 on > v4.19.24, it works. > > And I've tested your fix on v4.19.24, it also works. > Tested-by: Joseph Qi >