From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6491A3A0EA5 for ; Mon, 20 Apr 2026 12:50:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689446; cv=none; b=OtIClZkrLqran1JCR3V9dGr9h/f7s8Jdnd2w0pNybMVOq8L7LfFPoVgVdM4edLgWx/6X+mlCraqotMClmw7QNChY0nvG1xgvNZlC+NoMb9QYMRfnYIdLhKBXVWHpWN6/nzHoQ5HrO0FEbVcRdoniWKPmY1QesFhdGXROWG8bYIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689446; c=relaxed/simple; bh=xGH+Tbv6Ot2NIFWvdduKCymUO4Ct3OBttETzUcGBWZ8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dv+Tv3PH+VqpcaMnhO1UaL1wtoRupBfQ/RdIuuUrx+GvcEWZSAqaF7c/V8tWZhssgl2crobOI64VnqG36UnbjyxLolJaFN59Plaou6Uwr9V4WH14jybzWvgbTXG8Mmczt4DxS12kyOWQ0ZhNwk44KPjCfXrsnlMAVbfeXLrQCOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iGbhMUp+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lQ+8F3F4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iGbhMUp+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lQ+8F3F4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776689444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YJcG0BVg25HZ2E/z9uEY2PXmC8ZZQ0Dy/q/+TJStPMY=; b=iGbhMUp+mOsUpon+xH39dAXASkRveFClob3YiI8Xxg/7saEtw0L4c4/Q1/Q/c3LJdzCfHs +uhf0BCWlgP8vxAd7/702gyxGlRD6L+L1l1qf75sVWkJSiwPTgnO/68e36kQgeCuIvy3AU sbFFWIX0WS4P9kAvUt2sr4awKp8L8AM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-Qn60V-b_MnSsZglcfAMAeg-1; Mon, 20 Apr 2026 08:50:43 -0400 X-MC-Unique: Qn60V-b_MnSsZglcfAMAeg-1 X-Mimecast-MFC-AGG-ID: Qn60V-b_MnSsZglcfAMAeg_1776689442 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-488e097a270so22536345e9.1 for ; Mon, 20 Apr 2026 05:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776689442; x=1777294242; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YJcG0BVg25HZ2E/z9uEY2PXmC8ZZQ0Dy/q/+TJStPMY=; b=lQ+8F3F4M0EltZx+7OuHjTLIzTkttSPbiDR+9MkHs2gWuN7yufqaXq1OjMxTceRK6O 1Me3MfGl0zHAoIFMaqW0TlFQTqA5yvo/NTwVBy+T2aeFuVggDc+igF6WDxuuB0Oqu6Y/ nYOydCQ9UfY4vzkssjtj/h1AcFV13Y+k8biecdxcTGfImkT2pcxZPl4uQB4C8pluSJ8R 8h8zwRJ5EjIM1awigpx3kuQrFQpermQYnuNk88iqYzi1T/Pk3GrCu9wxm7dZv2rjClLK /9+ud1bt4zMlMOI9UxVQUDgpUVQfki5L2QCEXPjtTZN7++jBdYifrdCSBzo33KW9tUSl CZ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776689442; x=1777294242; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJcG0BVg25HZ2E/z9uEY2PXmC8ZZQ0Dy/q/+TJStPMY=; b=BHXWySsFMUgzjqcrzcD95FbDaqZy8oMqp7pMYCUO2I9GQI8hUKFlcDKofMpdArRMpx cMtvGLAxf7/EddwmIVEjcPLTmfFo2DHiaeWfmRVt3MGFK+J7TdiIkzE9ZW3iTPiMB9By OrHJlmbMVXPSD5VPHXMkE+O5aJgOQVj9B8hCWcK5pG+JmDUNnbnOusAehEodYsmPJIk0 nQKZZhLFcAZDmP4ktjtKxvmlGJPObVsG56SbEbTnpc6DYfY0wbk9+aEaK77xWEN2UAbN Ik5GMHkG5113lCxAIk704hRc5vjSJI/83989sEouLBWGqo4AJDk/0/kM7uEc0egGdRk1 kL3g== X-Gm-Message-State: AOJu0Yy6evILz9K2JIsN+moQS+48+FmrLySTCMusN6w9KL1Niy4SPSpp JspZE/4WgXPO/E1Bpq3bIqx1uLcRmwL++73e0wzaHnv3M2z5CvHwC02MEEW3REhxYXsNeLplUZs +SQS2rexQGA4kchTJQqbw+LY3JUJ2+HZnmpFGq6l6pZ8pn+Hn7Gp9200dGi+00BBc17IiwkuLCi 7cJglAnLLH7AFwBXeQe0kwT8EqyqDwqlebEzSP3p5xFvo= X-Gm-Gg: AeBDiev2LLmhkTua+7vV56O8GtfezcgR5bYMZfdG+iomU65nCF4FT7rMBSZT9b7LMm+ eVvxc77geWc1O0NWFDbDbeXmbGptMRd1aARm3PTmCwbKOu7m3gRQn/c+KphaxyXbUiRSoAlX6nS WV4T0gC1tM81Ah7uR9op5G+GvPiDMjAkxkXTAsz9YXURnuZX4YyHLq0GHUubX26eCoF/DtRrBzt wnrbfyEPZyvRWuJYVyvSfnjdh9q9xUSAXYhNcCDZQZtN2CmnFbfo71dP0XIQTT0pUIn2EkGLrSc JpeXCoKAagF6GqpEohSme9MvWa6yWbiUA/KHL6ucqkyjbTLQdBInUR6tNdeYGOh/CcktC2GjtVa BhmayMMMitHsqk7awAJ66oO4QuSFB4nJdTYpYLfX0OmWbB748QFXBUA== X-Received: by 2002:a05:600c:4f0c:b0:489:1c1f:35e6 with SMTP id 5b1f17b1804b1-4891c1f38c8mr61834955e9.6.1776689441768; Mon, 20 Apr 2026 05:50:41 -0700 (PDT) X-Received: by 2002:a05:600c:4f0c:b0:489:1c1f:35e6 with SMTP id 5b1f17b1804b1-4891c1f38c8mr61834045e9.6.1776689441052; Mon, 20 Apr 2026 05:50:41 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-21.inter.net.il. [80.230.25.21]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7bf696sm89203495e9.32.2026.04.20.05.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 05:50:40 -0700 (PDT) Date: Mon, 20 Apr 2026 08:50:38 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Andrew Morton , David Hildenbrand , Vlastimil Babka , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Jason Wang , Andrea Arcangeli , linux-mm@kvack.org, virtualization@lists.linux.dev, Johannes Weiner , Zi Yan , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport Subject: [PATCH RFC v2 07/18] mm: post_alloc_hook: use PG_zeroed to skip zeroing, return pghint_t Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Add pghint_t *hints parameter to post_alloc_hook() and prep_new_page(). post_alloc_hook() reads PageZeroed, clears it, and returns PGHINT_ZEROED via hints. This provides a single point where PG_zeroed is consumed and cleared, regardless of whether the page came through PCP or buddy. The flag is set in page_del_and_expand() and survives both paths until post_alloc_hook() consumes it. Only get_page_from_freelist() passes hints through prep_new_page(); all other callers (compaction, bulk alloc, split, contig) pass NULL. Signed-off-by: Michael S. Tsirkin Assisted-by: Claude:claude-opus-4-6 Assisted-by: cursor-agent:GPT-5.4-xhigh --- mm/compaction.c | 4 ++-- mm/internal.h | 3 ++- mm/page_alloc.c | 25 +++++++++++++++++-------- 3 files changed, 21 insertions(+), 11 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 1e8f8eca318c..6fcce7756613 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -82,7 +82,7 @@ static inline bool is_via_compact_memory(int order) { return false; } static struct page *mark_allocated_noprof(struct page *page, unsigned int order, gfp_t gfp_flags) { - post_alloc_hook(page, order, __GFP_MOVABLE); + post_alloc_hook(page, order, __GFP_MOVABLE, NULL); set_page_refcounted(page); return page; } @@ -1833,7 +1833,7 @@ static struct folio *compaction_alloc_noprof(struct folio *src, unsigned long da } dst = (struct folio *)freepage; - post_alloc_hook(&dst->page, order, __GFP_MOVABLE); + post_alloc_hook(&dst->page, order, __GFP_MOVABLE, NULL); set_page_refcounted(&dst->page); if (order) prep_compound_page(&dst->page, order); diff --git a/mm/internal.h b/mm/internal.h index 686667b956c0..2964cdfcd31f 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -887,7 +887,8 @@ static inline void prep_compound_tail(struct page *head, int tail_idx) set_page_private(p, 0); } -void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags); +void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags, + pghint_t *hints); extern bool free_pages_prepare(struct page *page, unsigned int order); extern int user_min_free_kbytes; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ece61d02ea96..a4cfd645599a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1863,13 +1863,21 @@ static inline bool should_skip_init(gfp_t flags) } inline void post_alloc_hook(struct page *page, unsigned int order, - gfp_t gfp_flags) + gfp_t gfp_flags, pghint_t *hints) { bool init = !want_init_on_free() && want_init_on_alloc(gfp_flags) && !should_skip_init(gfp_flags); bool zero_tags = init && (gfp_flags & __GFP_ZEROTAGS); + bool zeroed = PageZeroed(page); int i; + __ClearPageZeroed(page); + if (hints) + *hints = zeroed ? PGHINT_ZEROED : 0; + + if (zeroed && !zero_tags) + init = false; + set_page_private(page, 0); arch_alloc_page(page, order); @@ -1918,9 +1926,9 @@ inline void post_alloc_hook(struct page *page, unsigned int order, } static void prep_new_page(struct page *page, unsigned int order, gfp_t gfp_flags, - unsigned int alloc_flags) + unsigned int alloc_flags, pghint_t *hints) { - post_alloc_hook(page, order, gfp_flags); + post_alloc_hook(page, order, gfp_flags, hints); if (order && (gfp_flags & __GFP_COMP)) prep_compound_page(page, order); @@ -3991,7 +3999,8 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, page = rmqueue(zonelist_zone(ac->preferred_zoneref), zone, order, gfp_mask, alloc_flags, ac->migratetype); if (page) { - prep_new_page(page, order, gfp_mask, alloc_flags); + prep_new_page(page, order, gfp_mask, alloc_flags, + hints); /* * If this is a high-order atomic allocation then check @@ -4227,7 +4236,7 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, /* Prep a captured page if available */ if (page) - prep_new_page(page, order, gfp_mask, alloc_flags); + prep_new_page(page, order, gfp_mask, alloc_flags, NULL); /* Try get a page from the freelist if available */ if (!page) @@ -5223,7 +5232,7 @@ unsigned long alloc_pages_bulk_noprof(gfp_t gfp, int preferred_nid, } nr_account++; - prep_new_page(page, 0, gfp, 0); + prep_new_page(page, 0, gfp, 0, NULL); set_page_refcounted(page); page_array[nr_populated++] = page; } @@ -6958,7 +6967,7 @@ static void split_free_frozen_pages(struct list_head *list, gfp_t gfp_mask) list_for_each_entry_safe(page, next, &list[order], lru) { int i; - post_alloc_hook(page, order, gfp_mask); + post_alloc_hook(page, order, gfp_mask, NULL); if (!order) continue; @@ -7164,7 +7173,7 @@ int alloc_contig_frozen_range_noprof(unsigned long start, unsigned long end, struct page *head = pfn_to_page(start); check_new_pages(head, order); - prep_new_page(head, order, gfp_mask, 0); + prep_new_page(head, order, gfp_mask, 0, NULL); } else { ret = -EINVAL; WARN(true, "PFN range: requested [%lu, %lu), allocated [%lu, %lu)\n", -- MST