From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E059536212F for ; Mon, 29 Jun 2026 10:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782727887; cv=none; b=icDD9FWvnwummL7Ht0llA4h8vvXgtunnBGrGXLF1Wdv5+9+FBGE4m5OrHmj96RxUNZ6lu6H67iYsEz8EFWfEK2JSM6JUaH1eNXyiv6l8G0Ed5PeBMnhIHFSvUzr3HYFMKR2+w9xtn9CFaO91szCAyjAc/De8+HH9iC3e91I8X8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782727887; c=relaxed/simple; bh=KYymsWgZvfsa2Vf73oVvMIKmJDi/+uDmv+OT8hnk7hQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SZeru/L3JMoeAYwyYqGlIdRaVPgh9lyfg/TZlkrUkYg0ou2wBYY1WJ+ZWCGOGskrB2v+RGho/QO/BL34Hszfk3N/bN9Kcg0uNxHlOG1VQkat+DLGfk/3i1LGW46mkBSEimqCx+8btMXf5P3POYGIwBOOQbdTwKN3IDssj0AGIBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nsbxWSzk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iYN42hPw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nsbxWSzk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iYN42hPw" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T6r4OJ2088790 for ; Mon, 29 Jun 2026 10:11:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wlXJMssS9Ms0Gy8FZlFlkBj6U2eJhiWyPzITidulEQY=; b=nsbxWSzkWFVVwFOV 3gs12zCZbydLBjJ2r+sbn7rO3cZF6yxBa4OwuwGj6pcZNodG3C7M2g41UnJlw+Zv vWQM0Kll7R0FtpiqllsdCEuGjqk+xLxJWJyfIz+HuRALmrzyFv7l6jRA/Lv4cHYd fjR3PrZ/fKAGVvOYpR4lFqgMUWIBifrDmF4pTzt4pqvWCaf+plRBTr+UGQlTQ6Om gnkcvqdNFeCPv00iz2FgQ9W2T/wWpu7NMLVhKEbxHm3GteE6n3Oeh8cZ6LSdpW/0 kSGDgEdwNStdcRcwOjEFuc+VEWVUmtlv7sztbmtsIk6hwNdSpjg64t826l52gc1D 1Pyn4w== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3k7vh576-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 10:11:23 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92daa1a0f7eso59176985a.3 for ; Mon, 29 Jun 2026 03:11:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782727883; x=1783332683; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wlXJMssS9Ms0Gy8FZlFlkBj6U2eJhiWyPzITidulEQY=; b=iYN42hPwTxu2XMNnwiUbNtBO6gi8CLZQaPRD+qnimCAc3Xo0t9TOy1PD/QUGn42mVx kaDkGxG1C/vjHaqMIcuyv8/TVXUrCZhGWLdrF6a/bqxBE0ylG6gVhQDRjFODIHFrnai1 TSBHOQsiZHFeDqm26IHmtKk/L0TgKWRiDwhJTZeiiFHeM7mqhDd23pknZ3+dHN1v5pU6 k9Sd/8UNQCWsaw5AC0uGTw1xSEPZgd0uxRBMN8QJwvUMjN61Ex6VRDkH/IUs3o7552U3 XpRSIcYEe1pFTGHq0a4PvkmLOEvb52UAGru2ONHFsQ4jpyN1wVAeD0o2kvFrDoJKGA1b 2bWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782727883; x=1783332683; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wlXJMssS9Ms0Gy8FZlFlkBj6U2eJhiWyPzITidulEQY=; b=MrEVWz76HNPknQlrRs0K6LCvh6XISdu93KqJ+ZNGmal/c3nUktOtdXPXlWacHwxAd7 H9sUZcvtZozmL0+MX3EbX2f2aprvDJJMgor8KHa6zTnRfs6beZLnhiw/FlmgREhoLtBF Xh4wPKv5uE0RommCEkAOXovDLA3lF98vTc+4mLHV4VYv0VnwJ4Dr0v/jMH2E/Feo4q0g JBP7rErfXiBgY6YlUut3LjtEMx+4+mCWtxtKuZp29ivcE2GjYqnnAuDXUAvrgInY5M0M ns/H3qIFx6+okiLaMOQSxu4/GV4mUi0HzzBFOCBFFxXNeR6LjZ59A7pkq+V72odBadwB fy3w== X-Forwarded-Encrypted: i=1; AFNElJ9uOhRm4n5BR0lDVxtL9/d6G3zyNtSG0QhwtxFcQ8likxRSism5elpkN6/kx/tP/d/wTpksKiY4EWBW1vM=@vger.kernel.org X-Gm-Message-State: AOJu0YyJ5we+qV4cEMWV8jV7C7Z9mhYdiU5Vm0iA6LT8OpCTsppl/2TO vLa+deoCevjb6+OMExUPTmFHhPCUYxOJXJFBVzzZd/Ag8bpl8MuMnebAaCKmNMuW3Gu+57FYwVC SGHC3hPvnZSZpE18U1bRiyAeKRoRQp0avzfPE3SsPY3O3IGjeBuvBFaTXKUiytg6qhquCuTKVgv c= X-Gm-Gg: AfdE7ck4o2MhP805OqBGvDSIRZw6tyimRTLx3wlb1/Doa3iz5yOqmgnPkIABFgEMfDq jgW/yw9YdwvfZSkwo+EOY52YJqfI+tjZBd/W8R9zQrw/P5cQbffLkO2YperdZHkpdSWRd7Qvqzs 2t+P6GVgBJNYW5L4SQwv8YRYrVlRvcMT+5BVj7JNFL7NPJgtXw9gjX1fNJ1C63ayjWnb19++Li1 xX3fLtHuIkI9uKqVZ5PJZRLfEAW8jKnSQmAf/nTxYOYjiCAeJ+Z6EyGSkGrG7GNnKts9VD/hzB8 M9RMdY1FO69QSEutEeGNl5gKtbszkm/G4FekiTA+T1oTDj0JBObtwOUgQvqJq4ndu6Kl3u8cSq2 g0M+qRE701U+xsV3PhjdmGVdj1Mbczigtncg= X-Received: by 2002:ac8:57d3:0:b0:51b:f9e7:7fac with SMTP id d75a77b69052e-51bf9e78346mr27350181cf.5.1782727883107; Mon, 29 Jun 2026 03:11:23 -0700 (PDT) X-Received: by 2002:ac8:57d3:0:b0:51b:f9e7:7fac with SMTP id d75a77b69052e-51bf9e78346mr27349831cf.5.1782727882440; Mon, 29 Jun 2026 03:11:22 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12660ae60esm151121566b.17.2026.06.29.03.11.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 03:11:21 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 12:11:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] driver: core: introduce dev_add_sync_state() To: Brian Masney , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Ulf Hansson , Bjorn Andersson , Michael Turquette , Stephen Boyd , Russell King , Neil Armstrong , Xuyang Dong , Jens Glathe , Hans de Goede , Maxime Ripard , Saravana Kannan , Abel Vesa Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org References: <20260626-clk-sync-state-v1-0-4156d8196dc8@redhat.com> <20260626-clk-sync-state-v1-1-4156d8196dc8@redhat.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260626-clk-sync-state-v1-1-4156d8196dc8@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: ERG0ujBLF1IZl4aCg8US2oF6crzxja1_ X-Authority-Analysis: v=2.4 cv=CqCPtH4D c=1 sm=1 tr=0 ts=6a4244cb cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=20KFwNOVAAAA:8 a=QSepnEzQFVSc_k0dkj0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA4MiBTYWx0ZWRfX7uShppqXSlsX blZzMC2udWDhsrEhcxqcBBY+lvW2T7TcJLkCJh5JrCer4UQ/8LZzZwcjDTowd0kxYuZJlAm8uTE THSgH9NNYgcHzzF9LM8t+Pc0oCS4ACE= X-Proofpoint-ORIG-GUID: ERG0ujBLF1IZl4aCg8US2oF6crzxja1_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA4MiBTYWx0ZWRfX4pZG9h+VE4IU rm4ZHSu+CyV9eug47DZhA8BgPg7bLTVMPwSx9URO6HJlqb4yMvEDy0Z2M1468os2IKOnDk5NZy8 J8+qjAvJTwOIS2y5y0kLMUtFtZyRllc77kpTKVXumo8vfk7O7oeeJsX5FINaDm1y+W/jAqhBCQn swpujcFX/BwgoATd0YFsgTxZtUfHkdpwgC+TQjumXNOE5cNNzzS0diTZlyUlm2N0NE7CLDEfLwl +/Emm3Q8QFZVM8l1vn8Gx5T0USDgZAMXg/7wJzf3Vaojzvt6UhrIpyFpG4CcxKtHyznwaDv6fSg b95WIvthxiomtSHEu8Q5arwi3aT4mh4ehjgtz8XdbD33OY0ZYHDSowHq8wTBk5k5WVU7p/7HkRY rxzBY44b/7eUi/6kFzZZFzxtNMIjL2kvMC0H5XFR8jn3cBK+SP+4i0erN7SfO2V8LMMuVDxG+Zt 4NuD9LieUg+2rCJqZ4A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 priorityscore=1501 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290082 On 6/26/26 6:32 PM, Brian Masney wrote: > We have cases where a device node represents a provider for multiple > types of resources, like clocks, power-domains, resets, etc. We > currently have dev_set_drv_sync_state() where a framework or driver > can set the sync_state callback for a device node, however it currently > only supports a single sync_state callback. > > The pmdomain subsystem currently sets up a sync_state callback in the > core framework, and the clk subsystem will setup it's own separate > sync_state callback in the core framework. These can collide with each > other on some types of devices that have multiple types of resources. > Additionally, some clk drivers already have their own separate > sync_state callback already defined. > > Let's introduce support for allowing drivers and frameworks to add their > own sync_state callback via a new function dev_add_sync_state() so that > multiple sync_state callbacks can coexist. > > Link: https://lore.kernel.org/linux-clk/CAPx+jO9JiV16ePLk59hTQzEMnA96Va6Ns4jqJbwyZ6oTT0AjXA@mail.gmail.com/ > Signed-off-by: Brian Masney > Assisted-by: Claude:claude-opus-4-6 > --- [...] > +int dev_add_sync_state(struct device *dev, > + void (*fn)(struct device *dev)) > +{ > + struct sync_state_entry *entry; > + > + if (!dev || !dev->driver) > + return 0; > + > + list_for_each_entry(entry, &dev->sync_state_list, node) > + if (entry->fn == fn) > + return 0; Do we expect this to be a valid call, i.e. should we WARN_ON here? Konrad