From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F7CC433EF for ; Tue, 8 Feb 2022 15:59:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382587AbiBHP7c (ORCPT ); Tue, 8 Feb 2022 10:59:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382495AbiBHP71 (ORCPT ); Tue, 8 Feb 2022 10:59:27 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A38C0613CA for ; Tue, 8 Feb 2022 07:59:24 -0800 (PST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id EB1C13F32B for ; Tue, 8 Feb 2022 15:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644335962; bh=GCejdhR+a/xBJu0EdDNmDz0h5nAc0bdug5YEZYD9D0o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d6dKpMYQ7SqpS6VioALkwrSX/7lH0jVSalazDnvVWhF4ZpEoixxyrA/mbodWQNFxw bC16r3FexJ8wqrnnr7hd/yqQv1FS1G5ml4nZOeexf7hMGRwuhW2HWF567xxuJBmiPJ dqbWBkpONGPWH24tHGJ8QMD6O9jtdUJcXzcBQ6rZAAEdelmY5sr+Bg0HYH3WRIMkKn 1otuQiX0zGw/LpPHHQblBqr50OAzBoTYmhlrjrA8Uf8kZs/1CcRruSVU1B7N4q5eFi pbXWebr1t5dj9SoW08IVipWBoiUKeFEU8Kg4I2kY5ckW/zAoshtvBAcugabtWceZrZ WX3wjj22etH/A== Received: by mail-ej1-f71.google.com with SMTP id ka12-20020a170907990c00b006c41c582397so4433899ejc.11 for ; Tue, 08 Feb 2022 07:59:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GCejdhR+a/xBJu0EdDNmDz0h5nAc0bdug5YEZYD9D0o=; b=6avZ2Ob/gLA3NUsgCmqfwaZRKUxAduUWQXoxMAssFvB7nto5muRQeNur9H8HnDG2AB NXSxEMlNTYSBkXefSAktpn8swpnyA61bTEJ4X6fsRt6waAzfdzz4HsZz4qPsazJjQfqY 0QAD/qvYTD95HPiit1mC3zIek4Snwzr2KJXR3/f8TV5vxR4lFE1UOWAzmn4wkirPxbd1 1Bis6pbHttiEA9XtCHKcKvE4Iicyl8tpsuYfXGTSHPt7d/BCc90drrJHUVdKJfni3Gb0 XWg+hVIzfJUspS/dAlkPiUTHMBYbbOuP9SexS7VLfr8m2lTfr6iHIk+REB7xCKbC+Fr5 WlLw== X-Gm-Message-State: AOAM533pmNnFuNBVS6Na7ZZkqDtc5N7rXBxC43YXbxx+YsfyCf/BFex3 sa3dL1w/PFWo1aSpSoiYjep9hqudFh84yQE50u/6TOpr3uF2jGN4kzKfZOU/27FY4upng22zE3r O7ejTbQfbQHewcGbkY4Rb3OI3wEe2nztEuk8TPViqOQ== X-Received: by 2002:a17:907:60d0:: with SMTP id hv16mr4209716ejc.668.1644335962378; Tue, 08 Feb 2022 07:59:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzMWiC01ysSyAaBuDoWTE5s3bHip+jTOUASLhVK6NUfNE19TNoA/lCw7TRiHSeEzA5hH0AUg== X-Received: by 2002:a17:907:60d0:: with SMTP id hv16mr4209691ejc.668.1644335962134; Tue, 08 Feb 2022 07:59:22 -0800 (PST) Received: from [192.168.0.94] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id q4sm4956884ejb.109.2022.02.08.07.59.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Feb 2022 07:59:21 -0800 (PST) Message-ID: Date: Tue, 8 Feb 2022 16:59:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 3/3] dt-bindings: crypto: Convert Atmel SHA to yaml Content-Language: en-US To: Tudor Ambarus , herbert@gondor.apana.org.au Cc: nicolas.ferre@microchip.com, claudiu.beznea@microchip.com, alexandre.belloni@bootlin.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kavyasree.kotagiri@microchip.com, devicetree@vger.kernel.org References: <20220208104918.226156-1-tudor.ambarus@microchip.com> <20220208104918.226156-4-tudor.ambarus@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20220208104918.226156-4-tudor.ambarus@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2022 11:49, Tudor Ambarus wrote: > Convert Atmel SHA documentation to yaml format. With the conversion the > clock and clock-names properties are made mandatory. The driver returns > -EINVAL if "sha_clk" is not found, reflect that in the bindings and make > the clock and clock-names properties mandatory. Update the example to > better describe how one should define the dt node. > > Signed-off-by: Tudor Ambarus > --- > .../crypto/atmel,at91sam9g46-sha.yaml | 59 +++++++++++++++++++ > .../bindings/crypto/atmel-crypto.txt | 25 -------- > 2 files changed, 59 insertions(+), 25 deletions(-) > create mode 100644 Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml > delete mode 100644 Documentation/devicetree/bindings/crypto/atmel-crypto.txt > > diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml > new file mode 100644 > index 000000000000..e454f4468dc5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-sha.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/crypto/atmel,at91sam9g46-sha.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Atmel Secure Hash Algorithm (SHA) HW cryptographic accelerator > + > +maintainers: > + - Tudor Ambarus > + > +properties: > + compatible: > + const: atmel,at91sam9g46-sha > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: sha_clk > + > + dmas: > + maxItems: 1 > + description: TX DMA Channel > + One-item-description should work as well, so if you are going to resend: + dmas: + items: + - description: TX DMA Channel but the code looks equivalent, so: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof