From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 00FDCEB64D9
	for <linux-kernel@archiver.kernel.org>; Tue,  4 Jul 2023 12:36:10 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230349AbjGDMgK (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 4 Jul 2023 08:36:10 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48232 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229441AbjGDMgI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Jul 2023 08:36:08 -0400
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 800FBD8
        for <linux-kernel@vger.kernel.org>; Tue,  4 Jul 2023 05:36:07 -0700 (PDT)
Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57])
        by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QwMgm0bCZzTmJt;
        Tue,  4 Jul 2023 20:35:00 +0800 (CST)
Received: from [10.174.151.185] (10.174.151.185) by
 canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.27; Tue, 4 Jul 2023 20:36:00 +0800
Subject: Re: [PATCH] mm: page_alloc: avoid false page outside zone error info
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20230704111823.940331-1-linmiaohe@huawei.com>
 <ZKQM2lg7524dIAQl@casper.infradead.org>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <feb41501-163a-58d6-1996-8d6ebc9d800e@huawei.com>
Date:   Tue, 4 Jul 2023 20:36:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <ZKQM2lg7524dIAQl@casper.infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.174.151.185]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 canpemm500002.china.huawei.com (7.192.104.244)
X-CFilter-Loop: Reflected
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023/7/4 20:13, Matthew Wilcox wrote:
> On Tue, Jul 04, 2023 at 07:18:23PM +0800, Miaohe Lin wrote:
>> @@ -470,6 +470,8 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page)
>>  		sp = zone->spanned_pages;
>>  		if (!zone_spans_pfn(zone, pfn))
>>  			ret = 1;
>> +		else
>> +			ret = 0;
> 
> Surely 'ret = zone_spans_pfn(zone, pfn);' ?

Do you mean 'ret = !zone_spans_pfn(zone, pfn);'?  This format looks fine to me.

> 
> Also, did you spot this by inspection or do you have a test-case or bug
> report?  Should this have a Fixes: tag?

This is from code inspection. The race window should be really small thus hard to trigger
in real world. And yes, it seems Fixes tag is a really ancient commit:

	Fixes: bdc8cb984576 ("[PATCH] memory hotplug locking: zone span seqlock")

Thanks for your comment and reply.