From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 680A625771 for ; Tue, 26 May 2026 12:45:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779799531; cv=none; b=UJTqtbcrWuYyWSHZTm3/Ucra9QM6EY7C4oli9fIGvjFoOdNCFplQdPh2VHYRqnHncBYedr/olksIapkjosIS5CQo0J07CVjZPxrpJ2c9rqUBwENSxVF/0ArP9MzRchAr5FIcQK6NEm6IWP8TQIKgzdEhwdYfVWxxc7VltRe3St8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779799531; c=relaxed/simple; bh=JO6q9eoc30NoSzl4pjHnMA4ymxhAVXNZEdRBd/Cn48U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sbIcfvMreBwixF74UR2DN0OUjFA6ioYbKmkJBQLxuxrmfErWXSJRMLXXHg00XSpI+Z5ZIQQORAgPMnHQ9X0M+P07GWLgd2a8+aGawMFx13PWtaYTWTgdIqcXtfkbk1CYZL5edkoatF5tEVNoRKMMpVrBDo3tXaP3zBuP5h5W9HU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gwoMLsnP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kNcUypTY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gwoMLsnP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kNcUypTY" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64QBUUqj1763299 for ; Tue, 26 May 2026 12:45:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o7qburXdLogQXlPc8cleXsXcVe/PjiYelTmyym6qtSk=; b=gwoMLsnPxlLHwBV8 WQr182rtxj0/J8RYM3TkoqyxXfBDVgTphGde+to3/LhQYQOUeocG0clXFRTXgyQy YBOXXSM1Vje1ZeULVNuBPAZOWV82HJ4VhYkmVluVoSaJCQXfKV2xrGFnNMM7hj35 dukIBY8DtrWhBlDI/E3Nvdd9CK5j46xfeifb6XcCMbrxH1XW59O0cZNT9nW9lixF MMM0dIxMUb8bOO23ulCBIwEQDiBcv88ojgMtSENSxOZb+j30ubc7j7tRfdq1w1f+ XNr8c/R5EwlAsHIIHsEAgSPQ5i9XsIaKXkRbM62P7Z1fWF3f9hCjcYRdrUFyHTzh bH0p2w== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ed5vghqa0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 12:45:29 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-304950e5901so844917eec.0 for ; Tue, 26 May 2026 05:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779799528; x=1780404328; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o7qburXdLogQXlPc8cleXsXcVe/PjiYelTmyym6qtSk=; b=kNcUypTYGFvaoE4QJ7oQYY9MCtIWXkulgtePxCo8McsF06+JMqjHjn83z9DptHY2po 45SOA455cphovd/5vWtts0UBuXNPw6soLzKgHqtERrYxMZhmmRH0oxnV6KHrpQ2k0+bp LU+HpJNIa5yTfq2OgOezBphJfXuAYKDqY5Xt9sqVpvvIvWQmRgRBkmZOKYv2bR1+iAIS eednyiUvutC5CrZBIVIeTcFCoOuSJRV0Ttta8SgUaZyNj4k5LWz6xdGobNJDASEikNgp sqLe3ZcGiOZ5K+63r3WoPFUxSEH/tG82oyrIiwweKndyWsjmomoLJJOui40RgIpYVyMN nLhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779799528; x=1780404328; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o7qburXdLogQXlPc8cleXsXcVe/PjiYelTmyym6qtSk=; b=WWVgF4sJstdTh5159RxnWaECDvF1HnDFm716RvycsPcBliyACOOsjTOXDyAP4VJaPh BUEg/Rm8g2LV6ODLsNMYRi/tpj/0s/bywl7mdOAdHqxgsaRpwOi/LQXOiYNSdrH2LCbF x7dc7aC3lTnNk/l/ODH/GUfBb6mmPHUDEwAE0xPqca1lmyh50Ihy2v8AKxpJ7G6GRNIn Lo96YW9mIW/YyUhIfAo4Nh/1FcLJDlh2u92FoPE6sba3foI9BQAhmRAPkXfCJbWFTftr ww8X/0X03ogisS8sdkQZvZOob9SMZm7MJLXBOCadGZ3dSA1EzYHqtkygsZzXodglYBP/ GXrQ== X-Forwarded-Encrypted: i=1; AFNElJ+JLJZhmCVajEaG8saYrkRZgh+vFHglqBV5mQvq+Q0/dmZo3mSDR+OpDo9Exz+LPgNcFZhUT3BOI/Gg3dE=@vger.kernel.org X-Gm-Message-State: AOJu0YwESCIgPKyb3H8NagFUGV9/Bww3FdZdaDUb5jrXIjTz/TT7hD17 fQfJgrD3iKn1Pj2zIwHlbI1Xbz/pD7XXWelCkpvWw3t3JAOBbEwarQ7BMfVWDbgYun5EpMVVhN5 0eRxMByFhSbd81E7AssLgv7NbSMSUsHicCrrGeMyFzfad1/WKAseH65yl1nL+B73SUXQ= X-Gm-Gg: Acq92OGq6dUmsUpcfQzSe+hd47PUxveqNuyrI1Lsxci9l7IpL79bmvNPm2Qn/UbPNB3 m/qtX9p0MJzySSahvdGmQs5U/HaIjS9g3OazohSowAb/LFCp1lLxBfCOLsMqzKl7cqjbi2Bi9/t 8Y0+nw7X1j9VrePHQYOiS+QlLaDX5oKAAUSAcicL+QQ8s7QQCRg3ifShx60cN+xJrhixTkBNUtI DqCCFqsrr+7oripeI7skY2U8TtBmakWpwtJbzBBLo0ETADyjRt41zHIzot1B8tfP61vPmSvzpWt 8pF8D5dL/msygcW1FcBVjxshVZG4bVF4bpUoifUssNXbaCfziJU+vr9Qi+c6bo5s7WjqJVBGD/1 Bs8IBCvFELTvQzs5ffekvE2r6Ic77X86KRi5GwIAaHvIC5rWa3ctg X-Received: by 2002:a05:693c:639a:10b0:304:ad0:e91 with SMTP id 5a478bee46e88-3044a3f9bd2mr4384932eec.4.1779799528119; Tue, 26 May 2026 05:45:28 -0700 (PDT) X-Received: by 2002:a05:693c:639a:10b0:304:ad0:e91 with SMTP id 5a478bee46e88-3044a3f9bd2mr4384916eec.4.1779799527411; Tue, 26 May 2026 05:45:27 -0700 (PDT) Received: from [10.68.117.51] ([146.0.28.136]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30458ab1a46sm10193303eec.24.2026.05.26.05.45.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 05:45:26 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 18:15:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] media: qcom: iris: add support for decoding 10bit formats To: Neil Armstrong , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Bryan O'Donoghue References: <20260521-topic-sm8x50-iris-10bit-decoding-v4-0-8ff8fce3f904@linaro.org> <12102d68-da35-47ea-a972-28cb6d54ce1c@linaro.org> Content-Language: en-US From: Vikash Garodia In-Reply-To: <12102d68-da35-47ea-a972-28cb6d54ce1c@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=IrYutr/g c=1 sm=1 tr=0 ts=6a1595e9 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=iVdU4/i4LgW7qdSeEk1S9w==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=bC-a23v3AAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=poQuPI4Y3rRwBnmNrTsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 a=Vxmtnl_E_bksehYqCbjh:22 a=FO4_E8m0qiDe52t0p3_H:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: WLpLMCsVARVg2bHeK79bT2WMFqAvAMwB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDExMCBTYWx0ZWRfX5n6IfGj/BYtC FZgvHKimT5KuShPOqwPRi44YqNYbKY2qymn1rp7ZwSy6vU5UPwSE4WIaqfLOyPs6bUTsOXPc1MO Qkf5REgCT91JRhsZyHq/wq0elcJ/Q8dYRSBGCfaFlf7FcTXhejRZkmQh6Cz8qyTslP1QnGak//h GExUv3fz3lHgPUiAf+aI0rFkgArYTDHkrpVhTiqr9rhPlRanmwWLNRiAZMWYDeWKrEo3zmux9tZ 7Y/MVIekOMISqRr0m5X4IOf600oPEc3kA6J0RHtjYRVdMk4pT0alp9o32ZxI++VDcW75g/xB7zZ 9N+jKHkaxUxeb9U9cCMqAn/7yTydutv5SBkLKgY4BRoeduZr99QM8vfvzEqTTsahvZ2OqJCWCGk hQHSoNx4CrJ9HEuI+oWWBIYytfoQbNAD9NNj2WfxItQgZ1aDJPQIEQMB9aZZc1H4krwMM7fyehE tFRrsbTwfUBrPl+jkTw== X-Proofpoint-GUID: WLpLMCsVARVg2bHeK79bT2WMFqAvAMwB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-26_02,2026-05-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260110 On 5/26/2026 6:09 PM, Neil Armstrong wrote: > On 5/26/26 09:53, Vikash Garodia wrote: >> >> On 5/21/2026 2:54 PM, Neil Armstrong wrote: >>> This adds the plumbing to support decoding HEVC, VP9 and AV1 >>> streams into 10bit pixel formats, linear and compressed. >>> >>> This has only been tested on SM8550 & SM8650 with HEVC, and was >>> inspired by Venus, DRM MSM and the downstream vidc driver for the >>> buffer calculations and HFI messages. >>> >>> Gstreamer support for QC08 and QC10 need the MR at [1] to be applied, >>> but NV12 and P010 works out of the box with mainline Gstreamer. >>> >>> Fluster HEVC results on SM8650 using Gstreamer: >>> >>> ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - >>> 141/147 >>> The failing test case: >>> - Pixel Format mismatch >>>   - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but >>> decoder returns P010 >>> - Unsupported resolution >>>   - PICSIZE_A_Bossen_1 - resolution is higher than max supported >>>   - PICSIZE_B_Bossen_1 - resolution is higher than max supported >>>   - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported >>>   - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported >>> - CRC mismatch >>>   - RAP_A_docomo_6 >>> >> >> >> >> >>> >>> Total for iris_driver device /dev/video0: 54, Succeeded: 54, Failed: >>> 0, Warnings: 0 >>> >>> [1] https://gitlab.freedesktop.org/gstreamer/gstreamer/-/ >>> merge_requests/8195 >>> >>> Signed-off-by: Neil Armstrong >>> --- >>> Changes in v4: >>> - Picked review tags >>> - Use u32 instead of __u32 >>> - Explicit DPB >>> - Drop NULL and use >>1 in q10c buffer calc >>> - Drop selicolon after switch statementr >>> - Correctly align HFI_PROP_UBWC_STRIDE_SCANLINE entry >> >> Its not very clear. Does this fix the issue reported here [1] ? >> >> https://lore.kernel.org/linux-media/fb377b11-c54c-4bd9-bf12- >> cf19d6484c66@oss.qualcomm.com/ > > I wasn't able to reproduce the issue, and the reporter never answered my > questions so far. > > Neil It would be nice to add the reviewers directly as well. adding Wangao now. > >> >>> - Rebase on media next tree after the file split >>> - Link to v3: https://patch.msgid.link/20260511-topic-sm8x50- >>> iris-10bit-decoding-v3-0-7fc049b93042@linaro.org >>> >>> Changes in v3: >>> - Added review tag on patch 1 >>> - Limited stride command to AV1 decoding only >>> - Link to v2: https://patch.msgid.link/20260417-topic-sm8x50- >>> iris-10bit-decoding-v2-0-c987b65a31d5@linaro.org >>> >>> Changes in v2: >>> - Fixed bug breaking 8bit decoding >>> - Dropped filtering on G_FMT while waiting for soure change >>> - Dropped format filtering on ENUMFMT >>> - Switched ALIGN(x, 192) to roundup(x, 192) because ALIGN works only >>> with Power Of Two numbers >>> - Cleaned and refactors the width/height/stride calculations >>> - Cleaned and redesigned the buffer calculations functions with >>> proper comments and var names >>> - Passed fluster and v4l2-compliance to check for non regression >>> - Tested on SM8550 >>> - Added missing V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 with made >>> gstreamer fail decoding >>> - Link to v1: https://patch.msgid.link/20260408-topic-sm8x50- >>> iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org >>> >>> --- >>> Neil Armstrong (6): >>>        media: qcom: iris: add helpers for 8bit and 10bit formats >>>        media: qcom: iris: add QC10C & P010 buffer size calculations >>>        media: qcom: iris: gen2: add support for 10bit decoding >>>        media: qcom: iris: vdec: update size and stride calculations >>> for 10bit formats >>>        media: qcom: iris: vdec: update find_format to handle 8bit and >>> 10bit formats >>>        media: qcom: iris: vdec: allow GEN2 decoding into 10bit format >>> >>>   drivers/media/platform/qcom/iris/iris_buffer.c     | 195 ++++++++++ >>> ++++++++++- >>>   drivers/media/platform/qcom/iris/iris_hfi_gen2.c   |   8 +- >>>   .../platform/qcom/iris/iris_hfi_gen2_command.c     |  75 +++++++- >>>   .../platform/qcom/iris/iris_hfi_gen2_defines.h     |   1 + >>>   .../platform/qcom/iris/iris_hfi_gen2_response.c    |  37 +++- >>>   drivers/media/platform/qcom/iris/iris_instance.h   |   2 + >>>   .../platform/qcom/iris/iris_platform_common.h      |   1 + >>>   drivers/media/platform/qcom/iris/iris_utils.c      |  16 +- >>>   drivers/media/platform/qcom/iris/iris_utils.h      |   2 + >>>   drivers/media/platform/qcom/iris/iris_vdec.c       |  42 ++++- >>>   10 files changed, 364 insertions(+), 15 deletions(-) >>> --- >>> base-commit: 86693e86019a7466be961fd4f45d407cc0b0ba0a >>> change-id: 20260408-topic-sm8x50-iris-10bit-decoding-074c3ac7975c >>> >>> Best regards, >>> -- >>> Neil Armstrong >>> >> >> Regards, >> Vikash >