From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F013CC43140 for ; Fri, 6 Sep 2019 14:21:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9205205ED for ; Fri, 6 Sep 2019 14:21:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394119AbfIFOVy (ORCPT ); Fri, 6 Sep 2019 10:21:54 -0400 Received: from foss.arm.com ([217.140.110.172]:57040 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732020AbfIFOVx (ORCPT ); Fri, 6 Sep 2019 10:21:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E10228; Fri, 6 Sep 2019 07:21:53 -0700 (PDT) Received: from [10.1.197.50] (e120937-lin.cambridge.arm.com [10.1.197.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8AA123F718; Fri, 6 Sep 2019 07:21:51 -0700 (PDT) Subject: Re: [PATCH ARM64] selftests, arm64: add kernel headers path for tags_test To: Andrey Konovalov , Will Deacon Cc: Linux ARM , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , Will Deacon , Mark Rutland , Catalin Marinas , Evgeniy Stepanov , Kostya Serebryany , Amit Kachhap , Vincenzo Frascino , Dmitry Vyukov References: <20190906135151.d74nq3qzjmhe4mb5@willie-the-truck> From: Cristian Marussi Message-ID: Date: Fri, 6 Sep 2019 15:21:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/2019 14:55, Andrey Konovalov wrote: > On Fri, Sep 6, 2019 at 3:51 PM Will Deacon wrote: >> >> On Wed, Sep 04, 2019 at 06:41:00PM +0200, Andrey Konovalov wrote: >>> tags_test.c relies on PR_SET_TAGGED_ADDR_CTRL/PR_TAGGED_ADDR_ENABLE being >>> present in system headers. When this is not the case the build of this >>> test fails with undeclared identifier errors. >>> >>> Fix by providing the path to the KSFT installed kernel headers in CFLAGS. >>> >>> Reported-by: Cristian Marussi >>> Suggested-by: Cristian Marussi >>> Signed-off-by: Andrey Konovalov >>> --- >>> tools/testing/selftests/arm64/Makefile | 1 + >>> 1 file changed, 1 insertion(+) >> >> Damn, I just tagged the arm64 queue for 5.4 and didn't spot this patch. >> >> I'll queue it at -rc1 instead, if that's ok? It doesn't look urgent. > > Sorry, I guess I should have pinged you directly. > > I think it should be fine to leave it for rc1. It might cause a build > error in some kernel CI systems if they run kselftests though. > It won't be a big issue probably. Cristian