From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47CC21BEF76 for ; Wed, 22 Jan 2025 07:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737531872; cv=none; b=cv76NyjQV3WGDoC72ixn+a6NvUO6Rp7gbmXq8szBPjLU3OsNCYeBP1qRYEsHUEYnKQ/08BYcgOy2K/XWwY5a2nCAc1nCuZAe+86NkPTwdAtsUV5nuu5fhZjsBH0lBEKLL199Uy8g5dglScinwK5mNdu9UqW+nHcSoL9DJfj25xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737531872; c=relaxed/simple; bh=QLnRU0MWnrg9x3301DNkdRln9BGx5mG+TSPmx9dhhsQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CMGVA6HBLDwtkE+Mg7YCYN4gWxgVBBVDswo794bdswdqz0SKqppNspEJgVbgZ9uaW6hHRN94cqO/F/+1GI6A4FnqhvQTyU3ImjOOT//j8S6cM1AF+JHMU08Mf8z86ZeoHx6TBlB2EviqCNFDeAPwNJX0LH8Gx4T+vrT0pMX3b8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WyJeshxm; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WyJeshxm" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-436202dd730so47455005e9.2 for ; Tue, 21 Jan 2025 23:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737531868; x=1738136668; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Bsmxo8ok0PWoDNVNxNxbEGNCPBLfV7kz8NTtIfG+KwI=; b=WyJeshxmgqGcPjZyubLTtboT0emKZT3sWSN0HK8XaqQIBotackXGRIn8y/XJdiXBA3 0hD2BS/NSY/4sYbqyTbtoCBMPfieHbAyvNRKcoPwR8rOxkFBtO4cFZqxcWs3pi83LVqF 778awf+bFhQyYKX8dHX+SCvfV+WlaY0/9EDl6ANwSRMtRqmjHcmyBltLtk/RnucAq86L Yg28WvqZt0nsgofiq7ln8cdtrVNCkdmxRuYp5Baxds+2kgTppRx8tNLVHEBUYJRiD9ye LdkdLPKPALXxMc1n+XZ3yLvAJ2ZV2vLwZBI1/GS4gR64doBg7hR8uEqk4r08inKsf7VV nrpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737531868; x=1738136668; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bsmxo8ok0PWoDNVNxNxbEGNCPBLfV7kz8NTtIfG+KwI=; b=eadqeTIDZBZ8xTmpgyCbFHO9juFXrB+HlZLX5A7hrahxChFNOKpoc8A3zRgMw0iN5j NWDwOPlRcD/YF0kVaBIgSjKCaqxHn7ZADfzElgkZv/Znb+eet5MZnyLP0dxIwCEbCHuO zVWFqC2mRcr1vI4vY9tIOHqSLQn1PQrsv65jM49fpEvw8hP0X32FfDhUjrmDFUNxK9fW vuqqg1Yst2Q8HJLJ6DztHt8aBfqFnf3bCIQpoXkbOJwBtBG4hY21LcunTGpjtA75ZD/D dEMV2w2rf3u7lhma5P77Ymlyke2gGjFSc6oljuJPIMGmkQGfM9Ma9zLQ0nEAGJ4ktAgx sttg== X-Forwarded-Encrypted: i=1; AJvYcCVyHVvDbFAYQ3VQ6dgjUAJJqY1LBgFFACKNVpfrkXMe5H97NUYf5AiyKpEKMQuB5Dq4j3BF9lNLajIzWVI=@vger.kernel.org X-Gm-Message-State: AOJu0YxbFVGT5BB9OqzR6dItBHoNi8Ny9nJqULYoxX5xuTuruXTSsgiu trgVfEOtDn+lM/oEpMio/0LtxDwWFgksXvKuL8+NF5FvvWI2d4zKCnTMJ+PsXeI= X-Gm-Gg: ASbGncvvlh/qQnp8/MP+vDdQ5NmdOrGVCyC8hbGmA+4+U3IWhN54KrXKdOQA77lEWkN /z5VFuXGTCaMD2MKJbHQEVKKfLepqoBE/Snizs+l5rnGQpbuY7NFpGtrXbTUiIm6/aV3NWblHxU +yxArYIOp4N0JXJIqvmRcAicgSuBVKnnkWVp13anQ2Jy8nWwORaxhlasbBHVVhtClp2IY+hIw8J kEEoLmItL+fuJN/r6m5F9RrctWxu/6L5U0YodiTATs7izQS/4TJAcT+B9Aamw1nmFGdj7DEqn0= X-Google-Smtp-Source: AGHT+IFdii86nzRckkv7+ZhJvESX26haiGxkZ4n+5uLX7IO8Tv3+bylFRFp3PbXap4gvqUW3Z5V8ag== X-Received: by 2002:a05:600c:1987:b0:436:faf1:9da with SMTP id 5b1f17b1804b1-438913c68ebmr189076215e9.2.1737531868551; Tue, 21 Jan 2025 23:44:28 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf327574asm15586266f8f.68.2025.01.21.23.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 23:44:28 -0800 (PST) Date: Wed, 22 Jan 2025 10:44:24 +0300 From: Dan Carpenter To: Dave Penkler Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gpib: Make static and reduce forward declarations Message-ID: References: <20250121203342.20410-1-dpenkler@gmail.com> <6889992d-043d-4af8-869a-84eea9609148@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6889992d-043d-4af8-869a-84eea9609148@stanley.mountain> On Wed, Jan 22, 2025 at 10:37:33AM +0300, Dan Carpenter wrote: > On Tue, Jan 21, 2025 at 09:33:42PM +0100, Dave Penkler wrote: > > Declaring the entry points as static caused a warning that the > > serial_poll_status function of the agilent_82350b driver was > > unused. > > > > Add the entry point to the corresponding interface structure > > initializations where it was missing. > > ... > > > @@ -842,6 +824,7 @@ static gpib_interface_t agilent_82350b_unaccel_interface = { > > .primary_address = agilent_82350b_primary_address, > > .secondary_address = agilent_82350b_secondary_address, > > .serial_poll_response = agilent_82350b_serial_poll_response, > > + .serial_poll_status = agilent_82350b_serial_poll_status, > > .t1_delay = agilent_82350b_t1_delay, > > .return_to_local = agilent_82350b_return_to_local, > > }; > > @@ -869,12 +852,12 @@ static gpib_interface_t agilent_82350b_interface = { > > .primary_address = agilent_82350b_primary_address, > > .secondary_address = agilent_82350b_secondary_address, > > .serial_poll_response = agilent_82350b_serial_poll_response, > > + .serial_poll_status = agilent_82350b_serial_poll_status, > > .t1_delay = agilent_82350b_t1_delay, > > .return_to_local = agilent_82350b_return_to_local, > > }; > > So what happened is that Sparse was complaining and you were cleaning > up the code and you discovered this bug. Fine. But bug fixes need to > be in their own commit, not hidden inside a giant cleanup patch. They > need to have a commit message. s/commit message/Fixes tag/... regards, dan carpenter