From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbdKFJ2a (ORCPT ); Mon, 6 Nov 2017 04:28:30 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:49413 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbdKFJNt (ORCPT ); Mon, 6 Nov 2017 04:13:49 -0500 X-Google-Smtp-Source: ABhQp+SYhruu6buNvFay6NHwTp1EyTajBREUdMUel2v6YdCodSMdO9+LcHsyOaTHChWff0CAQqqRDw== Subject: Re: [PATCH v6] eeprom: at24: Add OF device ID table To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, Simon Horman , Andy Shevchenko , linux-i2c@vger.kernel.org, Geert Uytterhoeven References: <20171001104948.21663-1-javierm@redhat.com> <20171105215344.a5nyk7xmcdl22tpd@ninjato> From: Javier Martinez Canillas Message-ID: Date: Mon, 6 Nov 2017 10:13:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171105215344.a5nyk7xmcdl22tpd@ninjato> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Wolfram, On 11/05/2017 10:53 PM, Wolfram Sang wrote: > On Sun, Oct 01, 2017 at 12:49:48PM +0200, Javier Martinez Canillas wrote: >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C device registered via OF will always match a legacy I2C device ID and >> that the MODALIAS reported will always be of the form i2c:. >> >> But this could change in the future so the correct approach is to have an >> OF device ID table if the devices are registered via OF. >> >> To maintain backward compatibility with old Device Trees, only use the OF >> device ID table .data if the device was registered via OF and the OF node >> compatible matches an entry in the OF device ID table. >> >> Suggested-by: Wolfram Sang >> Signed-off-by: Javier Martinez Canillas >> > > Applied to for-next, thanks for keeping at it! > Great, thanks a lot for your feedback and suggestions on this series. Best regards, -- Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat