From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: <paulmck@kernel.org>, Joel Fernandes <joel@joelfernandes.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Josh Triplett <josh@joshtriplett.org>,
Boqun Feng <boqun.feng@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>, <rcu@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rcu: Don't dump the stalled CPU on where RCU GP kthread last ran twice
Date: Tue, 11 Jul 2023 11:26:30 +0800 [thread overview]
Message-ID: <fec44f45-f5d8-69e6-ebd5-f10fc70e4b2f@huawei.com> (raw)
In-Reply-To: <33ec8708-35be-446a-8cc5-58d366a6d75d@paulmck-laptop>
On 2023/7/11 4:32, Paul E. McKenney wrote:
> On Mon, Jul 10, 2023 at 03:55:16PM -0400, Joel Fernandes wrote:
>> On Mon, Jul 10, 2023 at 3:06 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>>>
>>> On Wed, Jul 05, 2023 at 03:30:20PM +0800, Zhen Lei wrote:
>>>> The stacks of all stalled CPUs will be dumped. If the CPU on where RCU GP
>>>> kthread last ran is stalled, its stack does not need to be dumped again.
>>>>
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>
>>> This one looks good. Please feel free to rebase it before 1/2 and repost.
>>
>> Just a small comment:
>> I wondered if this would make it harder to identify which stack among
>> the various CPU stacks corresponds to the one the GP kthread is
>> running on. However, this line does print the CPU number of the
>> thread, so it is perhaps not an issue:
>>
>> pr_err("%s kthread starved for %ld jiffies! g%ld f%#x
>> %s(%d) ->state=%#x ->cpu=%d\n",
>>
>> Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>
> Thank you! Zhen Lei, please feel free to add Joel's Reviewed-by on your
> next posting.
OK
>
> Thanx, Paul
> .
>
--
Regards,
Zhen Lei
prev parent reply other threads:[~2023-07-11 3:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:30 [PATCH 0/2] " Zhen Lei
2023-07-05 7:30 ` [PATCH 1/2] rcu: Delete a redundant check in rcu_check_gp_kthread_starvation() Zhen Lei
2023-07-10 19:03 ` Paul E. McKenney
2023-07-11 3:20 ` Leizhen (ThunderTown)
2023-07-11 16:48 ` Paul E. McKenney
2023-07-13 2:03 ` Leizhen (ThunderTown)
2023-07-05 7:30 ` [PATCH 2/2] rcu: Don't dump the stalled CPU on where RCU GP kthread last ran twice Zhen Lei
2023-07-05 8:17 ` Leizhen (ThunderTown)
2023-07-10 19:05 ` Paul E. McKenney
2023-07-10 19:55 ` Joel Fernandes
2023-07-10 20:32 ` Paul E. McKenney
2023-07-11 3:26 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec44f45-f5d8-69e6-ebd5-f10fc70e4b2f@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=qiang.zhang1211@gmail.com \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®