From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9EAA154425 for ; Sun, 22 Feb 2026 09:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771752702; cv=none; b=Bmfxs2LeKyPUbV8y8+7wKmS4Ma7h4EJZNxkz3y2VA98rDr54KR3A9JE89z24yzRPaULMeD4mGGwuSnu6rT60BYOZ+WdjmX4nVLpg9SlJfnqLaXjB0PGNJ4rPWgYFekn7gMHCxziu6fdsoWXjajT9Vb7ZRg941z5z0fPHNbCiiOk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771752702; c=relaxed/simple; bh=jVtRcetnItzqIICrqf4fSDzw7z8wCKY5rKNLHeR1a1w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m3gxVG/5Zb/vkqDQUQo6WaMRbm/GC763E5FPm3SxRqFse4A6tX8TucxY1sbH55sfxxQgAwgG86EHftR4GHFKVE4LlU3gS5flYoQ+6gQ/Kuj+CmyMGd00DuFaS+aXXbx5rnXQ3TvFFMijFgAO88Meca1yu2ngVORTEYVsF55wSqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dj7qDZOd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ghlA6yVV; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dj7qDZOd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ghlA6yVV" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61M8PP4s3995649 for ; Sun, 22 Feb 2026 09:31:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ACu3btGVkmCJZDXJw7qMC+4nsRBcyE8bkGP0SJhvN0k=; b=Dj7qDZOde61qUHSj tr/M8jQGhw02DHqT0Ssk9u6W2uEC++Th34gt2Gv4QpGrgVla+y3ufnLMTKuVMXBB AlcFYmc7fjttLYT1qHwWB16V9fK4XfE265aWyU2gjQ9jNfquTznNtAgdFh7ThFPA vr8zL8IwS0pyAZ0ojlqn2jroqFS5oEyGcRnfheIiQDJxD8gSdiC9mlUF0rHWNwtr +e5NIuKtUZtp8zS6BFs9K1lylafjMD7pZyoxHfeoqnv5EL2vl0fotiizX2+IxnRo hod624XcRYlDCb98r5BodP7EY5mzTjyrBXe5RoD4x5sh6fvN8r+ut0ncwH2yZoyX E29IIg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5x7t1fq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 22 Feb 2026 09:31:39 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb4b8e9112so313566585a.2 for ; Sun, 22 Feb 2026 01:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771752699; x=1772357499; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ACu3btGVkmCJZDXJw7qMC+4nsRBcyE8bkGP0SJhvN0k=; b=ghlA6yVVMT/LQRyZ/BcF27sDG6JmkPtFvTehJJq96jXKPMXUO00xWJNlbkJqwyHKlc Rjs9jajbNXu6VI0vJ+g+yH2l0eaXrvYTCwB004mG4WxMtZZRraC1BdBcjHnye5giRB04 E1rvgvrpF+/Cfzg/sagheiXYYow/75XHLkqf+FZwyq9EN9ycyueVs1gM+QkuqCiMJdMo ghRuaziA5Td9sbGz17l0eEM7ABqUPkk8rlDsnskKW9scPO/pK8+RsgroCoUpWlL1olCI zKsACinisiCgXaNwBLKRttok6RrCTCF4c+SyrBgHx719XpO1q/YwU56GpHabe59w9fF6 2iyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771752699; x=1772357499; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ACu3btGVkmCJZDXJw7qMC+4nsRBcyE8bkGP0SJhvN0k=; b=VRhjeVxqeMNInMetfw2ADSdYPRSr1hAFoCSAiHM6H6mL3ZRidPY+EQgCV7uz8zV9u3 QlFHtdTtJUniAJc0+SLebzqz4YPAltRauk7m6wxVpSJ2Ri+EvnFhwW2LVjKyCS3xmnhl vq4LuINSrozueVU9UvtqgjtF0Ot7ySJDPyK627s0luDNLqA9UgZVMKr7OBhD+05UmeYb KuRAY/ZWhnjOroR17qpYUFYPMyn3nf/2HpiHY5LJbd69KqJ8j+X9hfJ4Mdrcp+19ZqwR MTSeG1L6shcm3V8XbrF1KjEZKZFwSRPEUO2I5FgH3RQXkP2mtUtRtxQTObU7y508GheU EMpg== X-Forwarded-Encrypted: i=1; AJvYcCUyB93sTtixBOl424Pe67tFdSgexAAjEX8mordzuuXtbRGizwDuoFwBW4hVfVsE2GbmOOnCQRRIawsPmFs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsfmsh9ItS11k3nTg5pIBC6Ybjukvief61VFWU/ss6g5WGtOI3 Mx9Z2rM4ll0wBQGCxLdt/ju5KYeHGKyPQha4eIS2bwaR5D4gxH89/mndFyVBkRk29wQC+B/9e5J f+E25n6tvJPo16og+3plN4CVNGLtx8+U6XH1cXaQZnkdYLeHKmldjZPH9PhT5hsD3XC4= X-Gm-Gg: AZuq6aIJU25tGvmyQjROefM3pkn3/HfPHH0lwjWVtY0zWuaRlg/0WabCVZUKI+nqB4S STApQcDpBF8oXRZbnDClEM3LYZFGgXg2vWYU2A5uHpmAK4VV6bZyzqqPJN88jsOR0CAGzM0Jgt7 mo33H1rR8j8uJ4Fdh6SzYAoJb8rchxA046vBDpJ/aML5R3Vu4SpFLhQ3CnsyWRXui+IQ4PCW/Ij RMkbwTtNnGAWndnK+yoW8h8ihYybywDODvzY19rr36+XggMuhFg5XYmkH4bCTG8zFQOhuKbfCJF 6nooSBPTeDspGUNFHuL/7OTRecq6z1QiACl9u1GmnYQwldBNSHZ9fRXsvFXBjSMDL13yytQau30 bFaiHC92r521IJSnK68o6TC25qMarg7ODLK6B6sfFkrUgiQag X-Received: by 2002:a05:620a:25ca:b0:8c6:d309:f9c0 with SMTP id af79cd13be357-8cb8c9d036amr541425185a.8.1771752698908; Sun, 22 Feb 2026 01:31:38 -0800 (PST) X-Received: by 2002:a05:620a:25ca:b0:8c6:d309:f9c0 with SMTP id af79cd13be357-8cb8c9d036amr541423985a.8.1771752698475; Sun, 22 Feb 2026 01:31:38 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-43970d4c60bsm10446166f8f.27.2026.02.22.01.31.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Feb 2026 01:31:37 -0800 (PST) Message-ID: Date: Sun, 22 Feb 2026 09:31:37 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: arduino-imola: add support for sound To: Konrad Dybcio , lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, sboyd@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexey.klimov@linaro.org, r.mereu@arduino.cc References: <20260209142428.214428-1-srinivas.kandagatla@oss.qualcomm.com> <20260209142428.214428-4-srinivas.kandagatla@oss.qualcomm.com> <230d5d49-b86e-4696-937a-a6faaa9e45e0@oss.qualcomm.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <230d5d49-b86e-4696-937a-a6faaa9e45e0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIyMDA5MCBTYWx0ZWRfXwse2CKkMmJjF 0Nwd2Ph/ZYdoDmtmNjvaVKgTnzDT0jjs4HeskwEPCpBVbH890K00SVjPY9Zo8jRckRAFy9i0yb4 j2CVaaHxQ90nd1zip2A9hXj9/TBgVHN4gQA5ov8CSYct32gb0WWayhUi6d2MMfIqh+U7fQnWNRa 1P4wnLzYSUtvxCI+FoQG+XDx3FOj8USJGBYsYSrhekYfmnct34Y5VZCEtHUhN7gkwomBMBQ1/6r /KX+M8WzTVRgfB6tuVf/wSri0TvkYkVEsKtb0DS/H6VC61RADAgFxX7aoQPxDP4CRFFfv3IjmZF KfR8bBfRETXHEPutP4w/2vkB9to15lpWNZuSuP4dd+W1yGU0+GluXKHdk4llAzon7RrzDnuXIno WLYcPnaAp0pZsUxykJbu/FrGxi8tGFmM/O6JA8KlpT2ln6CtWrWrjnl0ixfl9inT+94rvedchKx 28LCTSGKKdPk/KubsuA== X-Proofpoint-GUID: tiCB59YtjFge7IdyDLulEdy-Rm-9h1ya X-Authority-Analysis: v=2.4 cv=X71f6WTe c=1 sm=1 tr=0 ts=699accfb cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=Ar_5JxPjAAAA:8 a=yUvOtWU7moQbhUsRCvEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: tiCB59YtjFge7IdyDLulEdy-Rm-9h1ya X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-22_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 adultscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602220090 On 2/10/26 10:07 AM, Konrad Dybcio wrote: > On 2/9/26 3:24 PM, Srinivas Kandagatla wrote: >> Add support for sound on Arduino UNO Q board, which includes >> - Headset playback and record. >> - Lineout > > Looking at the images, I can't see a speaker there.. > > And looking at https://docs.arduino.cc/resources/pinouts/ABX00162-full-pinout.pdf > I *thiiink* there's no I2S out (which is a little surprising) there isn't, there is only Ear, LIne, HP and MIc. > > [...] > >> + hph-playback-dai-link { >> + link-name = "HPH Playback"; >> + cpu { >> + sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>; >> + }; >> + >> + platform { >> + sound-dai = <&q6routing>; >> + }; >> + >> + codec { >> + sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>; >> + }; >> + }; >> + >> + lo-playback-dai-link { >> + link-name = "LO Playback"; > > "Line Out", "Headphones", etc.? I know if it's user-visible.. It will be via UCM. > >> + cpu { >> + sound-dai = <&q6afedai RX_CODEC_DMA_RX_0>; >> + }; >> + >> + platform { >> + sound-dai = <&q6routing>; >> + }; >> + >> + codec { >> + sound-dai = <&pmic4125_codec 0>, <&swr1 0>, <&rxmacro 0>; >> + }; >> + }; >> + >> + ear-playback-dai-link { >> + link-name = "Ear Playback"; >> + cpu { > > Let's uniformly keep a newline between the last property and the following > subnodes, and let's sort all these nodes alphabetically (i.e. both under > /sound and codec/cpu/platform within them) sure. > > [...] > >> +&spmi_bus { >> + pmic@0 { >> + pmic4125_codec: audio-codec@f000{ > > This definition should definitely live in pm4125.dtsi! agreed. > > missing space before '{' > >> + compatible = "qcom,pm4125-codec"; >> + reg =<0xf000>; > > missing space after '=' > >> + vdd-io-supply = <&pm4125_l15>; >> + vdd-cp-supply = <&pm4125_s4>; >> + vdd-pa-vpos-supply = <&pm4125_s4>; >> + >> + vdd-mic-bias-supply = <&pm4125_l22>; >> + qcom,micbias1-microvolt = <1800000>; >> + qcom,micbias2-microvolt = <1800000>; >> + qcom,micbias3-microvolt = <1800000>; >> + >> + qcom,rx-device = <&pm4125_rx>; >> + qcom,tx-device = <&pm4125_tx>; >> + #sound-dai-cells = <1>; >> + }; >> + }; >> +}; >> + >> +&swr0 { >> + pinctrl-0 = <&lpass_tx_swr_active>; >> + pinctrl-names = "default"; >> + status = "okay"; > > Please add a \n before status > > otherwise this looks ok > > Konrad