From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] fbdev/g364fb: fix build failure with mips
Date: Mon, 4 Sep 2023 09:59:40 +0200 [thread overview]
Message-ID: <fec93bb1-9aae-6202-ddaf-520d55892a27@suse.de> (raw)
In-Reply-To: <20230902095102.5908-1-sudip.mukherjee@codethink.co.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1387 bytes --]
Hi
Am 02.09.23 um 11:51 schrieb Sudip Mukherjee:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>
> Fix the typo which resulted in the driver using FB_DEFAULT_IOMEM_HELPERS
> instead of FB_DEFAULT_IOMEM_OPS as the fbdev I/O helpers.
>
> Fixes: 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Merged into drm-misc-next-fixes. Thanks for the patch.
Best regards
Thomas
> ---
> drivers/video/fbdev/g364fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/g364fb.c b/drivers/video/fbdev/g364fb.c
> index 7a1013b22fa7..ee6fe51e0a6b 100644
> --- a/drivers/video/fbdev/g364fb.c
> +++ b/drivers/video/fbdev/g364fb.c
> @@ -112,7 +112,7 @@ static int g364fb_blank(int blank, struct fb_info *info);
>
> static const struct fb_ops g364fb_ops = {
> .owner = THIS_MODULE,
> - FB_DEFAULT_IOMEM_HELPERS,
> + FB_DEFAULT_IOMEM_OPS,
> .fb_setcolreg = g364fb_setcolreg,
> .fb_pan_display = g364fb_pan_display,
> .fb_blank = g364fb_blank,
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2023-09-04 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 9:51 Sudip Mukherjee
2023-09-04 7:59 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec93bb1-9aae-6202-ddaf-520d55892a27@suse.de \
--to=tzimmermann@suse.de \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®