From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90947C43219 for ; Fri, 21 Oct 2022 14:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230159AbiJUO3t (ORCPT ); Fri, 21 Oct 2022 10:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbiJUO3g (ORCPT ); Fri, 21 Oct 2022 10:29:36 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D692B1DA6F for ; Fri, 21 Oct 2022 07:29:29 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id u7so1892355qvn.13 for ; Fri, 21 Oct 2022 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zYhXx3JshQE/tuoCTDyLMashoUzdUo4pZcMqABkRo/M=; b=srn3zByRrvEg+Yl6vV3ME0TTHd3gSfIVYc5ZsM/gQ0sujv8ybmnhpgntT0M6CLvr4P m/RzgyED/1GoDGFqUlL3LFyZgVLHf2kd4IOVgVaSQg2DCWp2il/4PLd7C2F3kVEEX79N nYke2DF0zLQX9jgzJm6HL3QMEw9CewFh3MPpKG5pu1vWUhzC7NEtPzbnnicUmuCSq8SS x7GbK2dbutqxSpzqpV5t9smW102A9VVnGQ2MOuDQ8sAKz4MTKPex7eTSjWRJ0M6m/J2R 7qnWcwXvMysRYCIvyFb4tfcjoGcLX1dAAikcq1J3fnjo2oP1dyuMLUL09n97fmm9WWbv kU3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zYhXx3JshQE/tuoCTDyLMashoUzdUo4pZcMqABkRo/M=; b=GZlCcwSCOoUns5kXHFQZkpchSJhrfAaxmJo/Upg1l2WcHn/+KtW6h9Z94qi/jq/zw+ Nptm0MR4b6rx5+mvIP0tmsYzFTbm/K3dF6SbwOpPR/nbrlcqE4+/GNg7kcmOsoC42dur ANhMc4M3+H1eE6BiWghJctGRtIpZfUqfRp1agalABPzlBbxMxwiid6E8z9/f1zPLtOOB TBDkySlaDTIX+1H7ZLebfG8SOQt5InKYQFAaMrbyPCrTR5x1DWLz1daznhA9z8XcsNQG Doq1CTO+ENnx6NAuXWHd3B356fxGq/FsrvK+/uxbA0myUUABNFi3Cwuvb9FCr5jQf3DH xHTw== X-Gm-Message-State: ACrzQf1LtkYLH849pTgW+Yf8B8EyrIPFVPTcolwH6p+O5y/lQuEgx4rZ +G3hLg4G5CbE7tt4zCWZzzGyKQ== X-Google-Smtp-Source: AMsMyM5rkcPzQyOOQTpTuNGSU0Y+0j9z9JKh5icS5aTFsqI2snnDhTn3uBhW8R+XpbEZuMtOlufWhw== X-Received: by 2002:a0c:e449:0:b0:4b9:cfc3:b31a with SMTP id d9-20020a0ce449000000b004b9cfc3b31amr5680781qvm.35.1666362568431; Fri, 21 Oct 2022 07:29:28 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id x6-20020ac86b46000000b0035ba48c032asm7936410qts.25.2022.10.21.07.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 07:29:27 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 10:29:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH net-next v5 5/5] ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller Content-Language: en-US To: Vladimir Oltean , Maxime Chevallier Cc: "davem@davemloft.net" , Rob Herring , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "thomas.petazzoni@bootlin.com" , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "linux-arm-kernel@lists.infradead.org" , Luka Perkov , Robert Marko References: <20221021124556.100445-1-maxime.chevallier@bootlin.com> <20221021124556.100445-1-maxime.chevallier@bootlin.com> <20221021124556.100445-6-maxime.chevallier@bootlin.com> <20221021124556.100445-6-maxime.chevallier@bootlin.com> <20221021142057.zbc3xfny4hfdshei@skbuf> From: Krzysztof Kozlowski In-Reply-To: <20221021142057.zbc3xfny4hfdshei@skbuf> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/10/2022 10:20, Vladimir Oltean wrote: > On Fri, Oct 21, 2022 at 02:45:56PM +0200, Maxime Chevallier wrote: >> @@ -591,6 +592,51 @@ wifi1: wifi@a800000 { >> status = "disabled"; >> }; >> >> + gmac: ethernet@c080000 { > > Pretty random ordering in this dts, you'd expect nodes are sorted by > address... Good point. > >> + compatible = "qcom,ipq4019-ess-edma"; >> + reg = <0xc080000 0x8000>; >> + resets = <&gcc ESS_RESET>; >> + reset-names = "ess"; >> + clocks = <&gcc GCC_ESS_CLK>; >> + clock-names = "ess"; >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; > > 32 interrupts, and no interrupt-names? :) There is no requirement for names, because entries must be ordered. Also Linux driver simply does not use them as it is slower to map, then just by index. For few other Qualcomm drivers we dropped the names as well. > >> + >> + status = "disabled"; >> + > > Could you drop these 2 blank lines? They aren't generally added between > properties. > ... and put status at the end. Best regards, Krzysztof