From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DC9C282E1 for ; Fri, 24 May 2019 22:04:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A286217F9 for ; Fri, 24 May 2019 22:04:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Upz4APO1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732126AbfEXWE6 (ORCPT ); Fri, 24 May 2019 18:04:58 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46104 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729552AbfEXWE6 (ORCPT ); Fri, 24 May 2019 18:04:58 -0400 Received: by mail-pl1-f196.google.com with SMTP id r18so4661222pls.13; Fri, 24 May 2019 15:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YnnyVNqUxh2k/cxJmn0sG9tavfiNdKrpTqEXdJVnlro=; b=Upz4APO1cM07lMLyjajBRGcUaIxxWc2xSIZPv0yCdbKk3bgt8lhoMg/RBm5woTdxPr nACGQHxt104QMt3YOOh2M23sdsn8KzWP43N33VaglrLr0tP4Uc0GjOGD2Enlhex9VIQJ /yNsLnXqaY7H7SRuzusM6LohshAGdco0DOPG58aQuYHlVn+khi52A4xolC0Syz96GUlg AONdEtSU9gMyoKyKxxlCZ+f2GCXI1k7BJOOgckQPYpu5r3jPA7qyv80idWO6GzETPGKv Wo6lFlJbmAFy8PTdZ+uLnfhPiv7bcyUp6FDJfa9Qo2vVvj1pDoHAB6fMuQ+tsu1ZewBH 2bYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YnnyVNqUxh2k/cxJmn0sG9tavfiNdKrpTqEXdJVnlro=; b=pfxKN3zAPReirnVmToZpIV4v+7tV/Ak2+nxzafvlHKZjwTsdo2/Jr8u7eAipS+lyEM +8t8jxxZ4GbpYv11Rgg0jBr5Ll+tb/Go5P5Xwe+Pf5GrFUJXjfByb15KSI6KzqWohd61 8iHAu2LQ84+EkL4/t1LbUMfiSeGwjB5krwygMIusvdnOihD6t/QM/GIFzn16qZ5Mn7fh J//+zFU9WGQzxLGevA9gqDQe6w7l1iuWTdjUixuK/9en6b+WLtgFw1F0qSC5NIAyBap5 37ElRdUiS5pT/c2EWKHkbiXgWozbnT6UjW5webZcPNq8oS6LGG7J45r1jUWcew+dYdbE dKTA== X-Gm-Message-State: APjAAAX3IrWp9sRilSWvxgD/N2s3Q1mY/wQvVMTHoi/JlWd97N4az+KA odJdgYycAeh2oVAv4nwv+mXOZ5tz X-Google-Smtp-Source: APXvYqypmiDhXsU+qDxVxiydwYZ6k6hTxblUTrBF2RHXWA3cgKgAk9DsWjvYxZl+U+7+y7nr6JubvQ== X-Received: by 2002:a17:902:a70f:: with SMTP id w15mr39764422plq.222.1558735497195; Fri, 24 May 2019 15:04:57 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:59ee:6a57:8906:e2a1? ([2601:282:800:fd80:59ee:6a57:8906:e2a1]) by smtp.googlemail.com with ESMTPSA id o7sm4736191pfp.168.2019.05.24.15.04.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 May 2019 15:04:56 -0700 (PDT) Subject: Re: [PATCH][next] ipv4: remove redundant assignment to n To: Colin King , "David S . Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190524215658.25432-1-colin.king@canonical.com> From: David Ahern Message-ID: Date: Fri, 24 May 2019 16:04:54 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190524215658.25432-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/19 3:56 PM, Colin King wrote: > From: Colin Ian King > > The pointer n is being assigned a value however this value is > never read in the code block and the end of the code block > continues to the next loop iteration. Clean up the code by > removing the redundant assignment. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > net/ipv4/fib_trie.c | 1 - > 1 file changed, 1 deletion(-) > This looks right to me -- n should have been dropped. It is used in fib_trie_free from which I created __fib_info_notify_update but __fib_info_notify_update does do the put_child_root or node_free, it only walks the tree looking for relevant entries that need to send the NEWROUTE notifications. Fixes: 1bff1a0c9bbda ("ipv4: Add function to send route updates") Reviewed-by: David Ahern