From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbdG1Lxo (ORCPT ); Fri, 28 Jul 2017 07:53:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751872AbdG1Lxn (ORCPT ); Fri, 28 Jul 2017 07:53:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2147B35AD1B Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH 0/2] KVM: nVMX: fixes to nested virt interrupt injection To: Mike Galbraith , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: jmattson@google.com, wanpeng.li@hotmail.com References: <20170728070310.4460-1-pbonzini@redhat.com> <1501230295.9055.12.camel@gmx.de> From: Paolo Bonzini Message-ID: Date: Fri, 28 Jul 2017 13:53:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501230295.9055.12.camel@gmx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 28 Jul 2017 11:53:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/2017 10:24, Mike Galbraith wrote: > On Fri, 2017-07-28 at 09:03 +0200, Paolo Bonzini wrote: >> With these two patches, KVM does not blindly pass the exit interruption >> info and exit qualification from the vmcs02 and vmcs12 when injecting >> an exception. There were two spots where this was done, namely >> nested_vmx_check_exception and vmx_inject_page_fault_nested. >> >> Patch 1 avoids writing the vmcs02's VM_EXIT_INTR_ERROR_CODE field, >> which as Jim noticed isn't possible on pre-Haswell machines, but >> otherwise has no semantic effect. >> >> Patch 2 is the actual bugfix. > > I was looking into oodles of lapic_timer.hv_timer_in_use warnings in > RT, introduced by KVM: LAPIC: Fix lapic timer injection delay, when I > noticed this post. Happily, I can report that they are history. This patch won't fix them. They are a race that comes and goes---but yes, it's fixed. Paolo