From: David Laight <David.Laight@ACULAB.COM>
To: "'michael@michaelkloos.com'" <michael@michaelkloos.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] Fixed: Misaligned memory access. Fixed pointer comparison.
Date: Sun, 23 Jan 2022 13:31:34 +0000 [thread overview]
Message-ID: <fed7ee473044432180c67b4adc0eb45d@AcuMS.aculab.com> (raw)
In-Reply-To: <20220123034518.3717116-1-michael@michaelkloos.com>
From: michael@michaelkloos.com
> Sent: 23 January 2022 03:45
>
> Rewrote the riscv memmove() assembly implementation. The
> previous implementation did not check memory alignment and it
> compared 2 pointers with a signed comparison. The misaligned
> memory access would cause the kernel to crash on systems that
> did not emulate it in firmware and did not support it in hardware.
> Firmware emulation is slow and may not exist. Additionally,
> hardware support may not exist and would likely still run slower
> than aligned accesses even if it did. The RISC-V spec does not
> guarantee that support for misaligned memory accesses will exist.
> It should not be depended on.
...
From the way my email client display the patch I think it is
using both tabs and spaces for indentation.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-01-23 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 3:45 Michael T. Kloos
2022-01-23 13:31 ` David Laight [this message]
2022-01-23 16:53 ` Michael T. Kloos
2022-01-23 22:35 ` David Laight
2022-01-23 23:03 ` Michael T. Kloos
2022-01-23 15:44 ` Jessica Clarke
2022-01-23 17:15 ` Michael T. Kloos
2022-01-24 9:21 ` David Laight
2022-01-24 19:19 ` Michael T. Kloos
2022-01-24 22:28 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed7ee473044432180c67b4adc0eb45d@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael@michaelkloos.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome