From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09244257821 for ; Fri, 27 Mar 2026 01:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774573419; cv=none; b=ARRDreXF+fIHMrK6t29b1W+gSz2o6PIXO85Thx//EeSzQBRwGyWOSA0F5MvcVZK/Aklwp/874eXUP5yU2EBvz4YCHYaBoJxxGSfhYxDGjIFOs4sqAT88HLzRR4OaasxWYUBNgEcjnPkDhLHic0LvW9zGwYby1Uaf1CysPWV0cYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774573419; c=relaxed/simple; bh=xUevR4UCtU4Tr6vB3xIsFHyUaTubgjvQmZ6CneW4wLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CtY3ifuVa8c1w3oYWQrlZCPjYfDZcHAGR8vjMnZYW8kT5GcJZzAZ4BggDipwvPZGk8+8BvswrrGGsPw2nObm6OyHmDlhKlkfFG2MnY16UXWedHFA5Wf7pL2/i6DDAUuQkLTciUgunvwmkez7+JSUhPA7ag1fAN2QctXWPZOQCkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Haf7dYA3; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Haf7dYA3" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48374014a77so19154505e9.3 for ; Thu, 26 Mar 2026 18:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774573407; x=1775178207; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=m9Niuzybzpc7ylc9yfsJfs0wdPfmTua5AraM+Dz5c0Q=; b=Haf7dYA34j6bw2yA2l+OXl/XmRygA9RnQfX7iKPLAjXk/WAvrHGMtOLWItyj1HZNh6 oOC/9E6EaVDketlvfObk6W4/NtGFwIMGxY94duJXk2hqezOcmjKLu4dC0w0qNTXTXd5r FW6Z40F7ewgI7tttu4fi5oR7iXOatd75kMDtmTi0IjGfCW2wF5kgCCkl2uWp5lRrHpF/ 4bj4gv2ZLfnZBoX/dddysFcj8mavVdMucjEk1Gp5UAdiJ1RpEca4QRgzWqxOBYAfQKR7 CZT8LhVcNY+Fe75lcMn2pVE4CHNvm5e8gfVc/mMR74262FmxDFCpe9czQZCFRBh3Lbjh Z8Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774573407; x=1775178207; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m9Niuzybzpc7ylc9yfsJfs0wdPfmTua5AraM+Dz5c0Q=; b=Wi55fKsA4Wu957PTUs3VsMHDoQ+V8PrRSybXoge2KMvc4SOVnhlPHxmnsndni2GEYp hqUTk3xpNe7vgApb3u6pjH4gWjzjSJQ/BVH/lNtCddqBcHVJUxB6naZM5MmfOKm83Gyo bOuiEW63hVm1a5dsVO1Dosk25sFJD2xNl5sSqneDWN2QMbkD7OSmGN12ef6JYAJl1kTB 5HhGQD2aSRt6gaPR9lHBDf3AHPIB0Z+IOZef4uEjJbawItTU6PEpxMNQQ9a2kVp3IUHM mG/j5XQvxvZMZqkvFs6rQLtsq4vJk5q8o55hkQGmnu8HhkEZyYLZmdtdz5o4PdYFG9l1 SA+A== X-Forwarded-Encrypted: i=1; AJvYcCUdiUJzyYVganxTXAD+hJVR4WtfaR+12s8vWRSRnqEgroZMZFss0a9XRZQVCWiecxkn7dTk3JdE+M/ZkDk=@vger.kernel.org X-Gm-Message-State: AOJu0YzFUX2o4OrOrsy7qw2enf/qdPh3e8IaFS+60vlHE+cgc0KsTiZj ID7jaQHHA9MCrk6VXaX4mrVGEg3chR/sz3OX5rfqpDWPvhvHrCC9hNG4yTpmlUQFzcM= X-Gm-Gg: ATEYQzwY5O33m88iyp8L+ntKj8lr61/ri8kOUcFXkr1NhYty9l1FwgiXJh156TU3yZ+ saUl5O1+gqgvU9XYaBnY7YfUe/iXSXsjwyuxY3/HJfNnYm7enJE7MQCYi0pGtoTDbqtdfJP7HVM eBPbL3Z+bTpfyz+tn+DGObJnfnC7dXX/pWwXRpv2xY1rGtWX6nBriHIV0mzhjzF5UQ6t6hLeMPo /U8SfrgzkkQcyL6UHixxsJmJmJrbHnjYjSjTpUjmUPJ33NeDMlXZDUBH4Zkgic4g2jRWl/IGnCQ BA8/ToHbOv1NWRSwTcxML7LNQ5zilSYGYemQHs7RT9RN4ebD9QcslyKf/fG4O2fsHkO5G2MsyCV hzltv+el1DY8lYLjNu53CtfDQ34xJhTkZb6u7Do/qUXMLHnw5mXk3zMlj6eLoFmRux2nfcg/jMy RE0iHSG8eltyk4L6eEIsZFlaxusjT5UMypX04c3rHyg+p+ww== X-Received: by 2002:a05:600c:1d1f:b0:486:d76c:fa57 with SMTP id 5b1f17b1804b1-48727eb81bbmr11253345e9.17.1774573407044; Thu, 26 Mar 2026 18:03:27 -0700 (PDT) Received: from [192.168.0.167] ([109.76.111.26]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b9179b212sm12084513f8f.0.2026.03.26.18.03.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2026 18:03:26 -0700 (PDT) Message-ID: Date: Fri, 27 Mar 2026 01:03:24 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema To: Vladimir Zapolskiy , Bryan O'Donoghue , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260326-x1e-csi2-phy-v5-0-0c0fc7f5c01b@linaro.org> <20260326-x1e-csi2-phy-v5-1-0c0fc7f5c01b@linaro.org> <72ef6c9e-feb6-4e57-b8cc-7801bd748698@linaro.org> <8ac55e5f-72ed-4331-bf42-92ccf97507dd@linaro.org> <5d7d5bf8-4420-4d75-b928-820bb9233e52@kernel.org> <99287afe-90cb-44d5-91db-14c6b0f729fd@linaro.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <99287afe-90cb-44d5-91db-14c6b0f729fd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 26/03/2026 14:49, Vladimir Zapolskiy wrote: > Here the description of hardware is done, and my point is that the new > PHY_QCOM_CSI2_MODE_SPLIT_DPHY phy type is simply not needed, since it's > possible to give a proper description of hardware without this invention. Perhaps I'm not understanding you. If we use PHY_TYPE_DPHY include/dt-bindings/phy/phy.h:#define PHY_TYPE_DPHY 10 We _must_ then add SPLIT_MODE to phy.h if/when we implement that support. Which means successfully arguing the toss of weather SPLIT_MODE is a Qualcommism - a vendor specific mode or not. <&phy PHY_TYPE_DPHY> committed to an upstream dts will then need to be supported perpetually. So for example qrb5615 - kona/rb5 support split mode. Pretend go with <&phy PHY_TYPE_DPHY>; and retrofit individual PHY support to this platform. Grand so far. The pretend we want to switch from one sensor to a split-mode sensor on the existing mezzanine. Then we need a representation of split mode in phy.h to represent that in DT. <&phy PHY_TYPE_DPHY_SPLIT_MODE>; Except split-mode is not an appropriate mode to define in phy.h since it is vendor specific - even if a few vendors support it, its not a generic PHY mode. Hence we would have an enormously difficult time justifying adding that mode to phy.h and rightly so. >> https://review.lineageos.org/c/LineageOS/ >> android_kernel_motorola_sm6375/+/423960/1/drivers/cam_sensor_module/ >> cam_csiphy/cam_csiphy_core.c#b285 >> >> There is disjunction all over this file depending on the mode. >> >> https://review.lineageos.org/c/LineageOS/ >> android_kernel_motorola_sm6375/+/423960/1/drivers/cam_sensor_module/ >> cam_csiphy/cam_csiphy_core.c#b767 OTOH - SPLIT_MODE will certainly require _both_ separate init sequences and specific logical disjunction for additional configuration steps lane-assignment and masking, etc. - That phy.h isn't the right location for SPLIT_MODE as its vendor specific. Just look at the modes we have for the USB PHYs same logic => include/dt-bindings/phy/phy-qcom-qmp.h same raison d'être - And that specifying PHY_TYPE_DPHY now binds us into an ABI that we cannot subsequently change - it will not be possible to introduce include/dt-bindings/phy/phy-qcom-mipi-csi2.h later on with our mode So therefore include/dt-bindings/phy/phy-qcom-mipi-csi2.h + PHY modes is the logical outcome. --- bod