From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4576535B63D for ; Tue, 3 Mar 2026 10:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772533360; cv=none; b=R46PyNPTkTUil0rY4rWLGjTvmP3AVI+xsjtT0sWXBWHnwCrxMIkI09RNo8gLC4C9kpVZJwJHr1xZH1Rmj2AHs7P+QTor4Or1scSh1T5mrvRcxJXJnt5Edi26su98LGa+o4e6ytI+rnQB+7e0a39I/Qo9srhP7TPVXTJoU76u/c0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772533360; c=relaxed/simple; bh=gp4JzzebzKmENzHs2wBTVHycLWXBIoLkaRQ/pc/I+z8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YFGPjxqe9X3wWzYMbN+ioB8jeoIUhc5OvLN6DMGj65+vQ+XJPnQVVNIl4noRBD40Xs4+VhCtvmmnzhKH5fE4hDIb0boE3VFCMaGbvZALehhUT3wtUYmTlnhoRzpJaFdgds0QPwQHa1x+C/dHHNi9ysyQuKjiaq6LRQR5Ki0ubQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eppOPCUx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dP3HccxL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eppOPCUx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dP3HccxL" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6239mqpD2773409 for ; Tue, 3 Mar 2026 10:22:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gp4JzzebzKmENzHs2wBTVHycLWXBIoLkaRQ/pc/I+z8=; b=eppOPCUxZfrgrBdf PcJOFZYfEvc9pXXmVKXCdsKXSUeYcJyuL1+B23i3pFkGR4aXJmwqDavXNeIsuthd 4NnGNJEm4598saqLbQSoGqOU9NohcedljTSIudsJ+mANc7g5E9UDIM8IlJ2Wc11c +7b6gOvmVjHUPOGzn4GKVziixThbb/FnVVR/S8C72P3pREp5LMtPHkgL+oq9Yyxm YvcPVdNa/JxhpKxR1Isp1gbSLOEQGmpi/CY3HfBmOUisByyCAzhjiPFsUo0x92YJ Q7/aPiqfy7lXJxxl45Jx0wGapHoGZLkKbMpexFe7x0OkTMgBoWBNJyAKSWTHu848 8mbKSw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cnsjm119h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Mar 2026 10:22:37 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb456d53a5so486387885a.2 for ; Tue, 03 Mar 2026 02:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772533356; x=1773138156; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gp4JzzebzKmENzHs2wBTVHycLWXBIoLkaRQ/pc/I+z8=; b=dP3HccxLuTecx9KWt4Tni7D8wcpf+T3E+spvhT+gmOYhu6ZsYjxisVEpNqprpCq/Ws OzzgQub3nMtcBnBB8XIVI/WsHCLp33Eq8koQIcMvWjKGwYD7bDvdQrjmoE95ENGm4E2y KaqvCgLm7Q6LVOb4vnQjuF2HqS5bhcEjBwySS/dwgl3biCUx2Syy4nFCyaWgyvtHtN8n 9DsHmOQryW2hjx1ZIavFHhHuS6N3Aicna4pVV9HXnKTeKwxNVBgjsyLn2qX70+1DY/fn gIVCDLfuxWD8RzLczIAxV61GMA6Dvo4V3XjXYiGLXSsfRpPHiAH6hfpvntKcsaNyp1gU 11wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772533356; x=1773138156; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gp4JzzebzKmENzHs2wBTVHycLWXBIoLkaRQ/pc/I+z8=; b=iiKoLNSirtR6FsP7f+ufSrvdVA75dQRnInPY80HrIgHc9V4c3N4gCR4EIHhvDfKD1f Q7Aw2AYtDap1utS6uu8fQXzO0JUUkvKuW1CN1mvGHo2J0q8W8/Z4zs1xksb1fdL8sAk/ Xk79gLaoTNl792IiXO8PZsA0yccn42WCIULrdQPjSxLal8fAKBTLUc7PonVlo9C4rKmD jbXLYvUCOBJRvofhhsd+KV2no14McwgyhWnwy5ycy33dlGVwROSKRHZG22dVX4SJC890 tF+8Ra0rk4vwlqBUZ+TYZlzQg5dN5CDIzBtyNurq8L63KLlHx/drpIeMVejBG5huWTBw xkNQ== X-Forwarded-Encrypted: i=1; AJvYcCWUu8qSArm//FH9E/wJ1uRHzFSgyV/Gewg6t1cgMSlQVz2PcqIunKulT9WLjbARoWIfX5OCfopwLyeW3/w=@vger.kernel.org X-Gm-Message-State: AOJu0YxCbgAsrTz+rU1qcEl7ZAUuaMJysGQcOHWIlCLpkHYJaSaga1AS 3HGcy+rojogHKkjFJiI1xKyckbT3SeNAmS1ICvhLTi9+WM3bpdS9pFXcRXP1xiFmByslgCENiaV jz9YFoBOBwE8FTLINsPVTI4R4UuEkMNt2u3TY1bzX040+TT1Z+1EGoaYx9nVH7QDEuOc= X-Gm-Gg: ATEYQzx4wI99a2JUNrspg9S0Z2Tix8wuUTErvbFnfBBD+Hwzr7ACOAxi7BjdneJT4UG Cd6hZdYn26wx8dEjAoGjIPiOqVKw0GC6z/dSb0ZTc4ryXEPVHw0vdsQWErtTeZIc8pdnT+3FV2Q oth3Ew6wxEypUylpHHyUlvdnXCBde5nn3O4uEEUKgV3bd5/md2qNT2CYyroSWK79zYsNkYudY24 bzADxodhWJZgXnD1n5Rd/FXTaARBFR9UJAbWhNbeKw2FaEPGezGv7qsp8GUd3P6N4qLaRtubL2m TTWV4c2QsvejqVfLUGVBx5EY0Wam1hxISbKkzOzaCMSBKHhIYxEsb7+vy9Z2caTVwNdB5Y5s6uy GkdKXBZs9O7KnDuszKOOOYpP/ut1gj0dIQHCWs0hNmjiq9Ew8FMzss3IYFzu33Mw7mgSsh2QsiF Z6vhA= X-Received: by 2002:a05:620a:f0c:b0:8c0:c999:df5a with SMTP id af79cd13be357-8cbc8ef8d68mr1595219985a.6.1772533356434; Tue, 03 Mar 2026 02:22:36 -0800 (PST) X-Received: by 2002:a05:620a:f0c:b0:8c0:c999:df5a with SMTP id af79cd13be357-8cbc8ef8d68mr1595217685a.6.1772533355995; Tue, 03 Mar 2026 02:22:35 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ae666c9sm554838366b.39.2026.03.03.02.22.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 02:22:35 -0800 (PST) Message-ID: Date: Tue, 3 Mar 2026 11:22:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH WIP v4 6/9] media: qcom: camss: csiphy-3ph: Update Gen2 v1.1 MIPI CSI-2 CPHY init To: David Heidelberg , Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , Casey Connolly , "Dr. Git" Cc: Joel Selvaraj , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260301-qcom-cphy-v4-0-e53316d2cc65@ixit.cz> <20260301-qcom-cphy-v4-6-e53316d2cc65@ixit.cz> <4f29492f-c5c0-402c-b2aa-0e1886299d59@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: n_SMNHBMYgLOQnfdPMusqjES0mBTPg1C X-Authority-Analysis: v=2.4 cv=GIUF0+NK c=1 sm=1 tr=0 ts=69a6b66d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=-y82mbY2qW1znAYjJDkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: n_SMNHBMYgLOQnfdPMusqjES0mBTPg1C X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAzMDA3OSBTYWx0ZWRfX2TpLAQ+3dmBN DoiA42+VQHHLELXy6DlRHzFYoRjeuzklSZQ7l/TZfpSjoA4lozm8bAw5ChNs6A1AibMYoaDpo0N FFCDwWKUQx4leWJqTaJd27iLqN2x87XqFxnwOtzBB9FVciyxekhZqO/IwtCXGq/9oDkve054Nda /x4oGsO9ekBPEAGDJ8JzwwCAbyZMuXp3cz144JzHFny+Ozc4Phs8IPygHstni6Y/Kb6sdQp5HQ+ Oi+dD9/YFuORTcQoT2TX+9F9gzFtIFERRFVqSDEwUpmwL2FVgUxlyz2XKM5v7OsVs7ZZazANTL3 qC7/CErIpZpMkVzlzozuppHVlWIIG3+d7doNKMnj114nf6q6KdO71xNGNQHuDnuWH3n8vzFfRoH KPZf4/DAWIK3hFBoPzrjSuC+I4Rs0JsG3QW7pNO8ePKRgV/fYqpCZ85sIrLymflk/YY/xK8kjfS z+B6VwR2pKgWRCvIq1w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603030079 On 3/3/26 11:00 AM, David Heidelberg wrote: > On 03/03/2026 10:55, Bryan O'Donoghue wrote: >> On 01/03/2026 00:51, David Heidelberg via B4 Relay wrote: >>> From: David Heidelberg >>> >>> These values should improve C-PHY behaviour. Should match most recent >>> Qualcomm code. >>> >>> Signed-off-by: David Heidelberg >>> --- >>>   .../media/platform/qcom/camss/camss-csiphy-3ph-1-0.c   | 18 +++++++++--------- >>>   1 file changed, 9 insertions(+), 9 deletions(-) >>> >>> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/ drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >>> index 5482fb5163e17..c612192ee727a 100644 >>> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >>> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >>> @@ -225,9 +225,9 @@ csiphy_lane_regs lane_regs_sdm845[] = { >>>   /* 3 entries: 3 lanes (C-PHY) */ >>>   static const struct >>>   csiphy_lane_regs lane_regs_sdm845_3ph[] = { >>> -    {0x015c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x0168, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x016c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x015c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x0168, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x016c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x0104, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x010c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, >>>       {0x0108, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, >>> @@ -245,9 +245,9 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = { >>>       {0x0164, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x01dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x035c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x0368, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x036c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x035c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x0368, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x036c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x0304, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x030c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, >>>       {0x0308, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, >>> @@ -265,9 +265,9 @@ csiphy_lane_regs lane_regs_sdm845_3ph[] = { >>>       {0x0364, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x03dc, 0x51, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x055c, 0x43, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x0568, 0xa0, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> -    {0x056c, 0x25, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x055c, 0x63, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x0568, 0xac, 0x00, CSIPHY_DEFAULT_PARAMS}, >>> +    {0x056c, 0xa5, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x0504, 0x06, 0x00, CSIPHY_DEFAULT_PARAMS}, >>>       {0x050c, 0x12, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, >>>       {0x0508, 0x00, 0x00, CSIPHY_SETTLE_CNT_HIGHER_BYTE}, >>> >> >> Squash down and Co-developed-by Suggested-by, perhaps Co-developed-by usually reflects pair programming and requires a s-o-b, and that carries legal meaning. Konrad