From: Yijie Yang <quic_yijiyang@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<quic_tingweiz@quicinc.com>, <quic_aiquny@quicinc.com>
Subject: Re: [PATCH v2 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi
Date: Mon, 28 Oct 2024 09:20:17 +0800 [thread overview]
Message-ID: <fee8f3fe-f5b7-4c07-bef0-edd58cb621ee@quicinc.com> (raw)
In-Reply-To: <d08b8dd0-18f9-42e2-b0ac-b4283df0af79@oss.qualcomm.com>
On 2024-10-26 01:55, Konrad Dybcio wrote:
> On 17.10.2024 12:27 PM, YijieYang wrote:
>> From: Yijie Yang <quic_yijiyang@quicinc.com>
>>
>> In order to support multiple revisions of the qcs8300-ride board, create
>> a .dtsi containing the common parts and split out the ethernet bits into
>> the actual board file as they will change in revision 2.
>>
>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
>> ---
>
> [...]
>
>> chosen {
>> - stdout-path = "serial0:115200n8";
>> + stdout-path = "serial0: 115200n8";
>> };
>
> This looks unintended
>
> The rest looks good, except I think you forgot to drop /dts-v1/
> from the dtsi
Thanks for reminding me. I will fix it.
>
> Konrad
--
Best Regards,
Yijie
next prev parent reply other threads:[~2024-10-28 1:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 10:27 [PATCH v2 0/5] Enable ethernet for qcs8300 YijieYang
2024-10-17 10:27 ` [PATCH v2 1/5] dt-bindings: arm: qcom: add qcs8300-ride Rev 2 YijieYang
2024-10-18 6:24 ` Krzysztof Kozlowski
2024-10-17 10:27 ` [PATCH v2 2/5] arm64: dts: qcom: qcs8300: add the first 1Gb ethernet YijieYang
2024-10-17 10:27 ` [PATCH v2 3/5] arm64: dts: qcom: qcs8300-ride: enable ethernet0 YijieYang
2024-10-25 17:53 ` Konrad Dybcio
2024-10-17 10:27 ` [PATCH v2 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi YijieYang
2024-10-25 17:55 ` Konrad Dybcio
2024-10-28 1:20 ` Yijie Yang [this message]
2024-10-17 10:27 ` [PATCH v2 5/5] arm64: dts: qcom: qcs8300-ride-r2: add new board file YijieYang
2024-10-25 17:55 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee8f3fe-f5b7-4c07-bef0-edd58cb621ee@quicinc.com \
--to=quic_yijiyang@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®