From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>, benniciemanuel78@gmail.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>,
Sebastian Ott <sebott@linux.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] pci: hotplug: ibmphp: Fix 'line over 80 characters' Warning
Date: Wed, 05 Jun 2019 02:01:07 -0700 [thread overview]
Message-ID: <fee93f8714deec96657e5b6df2a987960de4473f.camel@perches.com> (raw)
In-Reply-To: <CAHp75VfEREXJTr_QpADTsqBr10t16SaJqeM+tbxp6QZgc8Gfjg@mail.gmail.com>
On Wed, 2019-06-05 at 11:41 +0300, Andy Shevchenko wrote:
> On Sun, Jun 2, 2019 at 7:25 PM Emanuel Bennici
> <benniciemanuel78@gmail.com> wrote:
[]
> > + debug("%s - call process_changeinstatus for"
> > + "slot[%d]\n", __func__, i);
>
> Do not split string literals like this.
Especially because it's common to miss the
space required between words when the
compiler coalesces the string fragments.
Like here.
prev parent reply other threads:[~2019-06-05 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 16:25 Emanuel Bennici
2019-06-05 8:41 ` Andy Shevchenko
2019-06-05 9:01 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fee93f8714deec96657e5b6df2a987960de4473f.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=benniciemanuel78@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael.j.wysocki@intel.com \
--cc=sebott@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®